From: Thomas Gleixner <tglx@linutronix.de>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Paul Cercueil <paul@crapouillou.net>,
Maarten ter Huurne <maarten@treewalker.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH v2] clocksource: ingenic-ost: define pm functions properly in platform_driver struct
Date: Thu, 01 Dec 2022 12:00:00 +0100 [thread overview]
Message-ID: <87mt87s827.ffs@tglx> (raw)
In-Reply-To: <20221123083159.22821-1-lukas.bulwahn@gmail.com>
Lukas!
On Wed, Nov 23 2022 at 09:31, Lukas Bulwahn wrote:
> Commit ca7b72b5a5f2 ("clocksource: Add driver for the Ingenic JZ47xx OST")
> adds the struct platform_driver ingenic_ost_driver, with the definition of
> pm functions under the non-existing config PM_SUSPEND, which means the
> intended pm functions were never actually included in any build.
>
> As the only callbacks are .suspend_noirq and .resume_noirq, we can assume
> that it is intended to be CONFIG_PM_SLEEP.
>
> Since commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate
> old ones"), the default pattern for platform_driver definitions
> conditional for CONFIG_PM_SLEEP is to use pm_sleep_ptr().
>
> As __maybe_unused annotations on the dev_pm_ops structure and its callbacks
> are not needed anymore, remove these as well.
>
> Suggested-by: Paul Cercueil <paul@crapouillou.net>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
just a minor nit. The subsystem prefix should be:
clocksource/drivers/ingenic-ost:
git log --one-line $FILE is usually a good hint for the subsystem
specific prefix choice.
Fixed it up while applying.
Thanks,
tglx
next prev parent reply other threads:[~2022-12-01 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 8:31 [PATCH v2] clocksource: ingenic-ost: define pm functions properly in platform_driver struct Lukas Bulwahn
2022-11-23 17:54 ` Paul Cercueil
2022-12-01 11:00 ` Thomas Gleixner [this message]
2022-12-01 11:05 ` [tip: timers/core] clocksource/drivers/ingenic-ost: Define " tip-bot2 for Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt87s827.ffs@tglx \
--to=tglx@linutronix.de \
--cc=daniel.lezcano@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=maarten@treewalker.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.