From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48206ECAAD8 for ; Wed, 21 Sep 2022 15:24:54 +0000 (UTC) Received: from localhost ([::1]:40682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ob1an-0005u3-DP for qemu-devel@archiver.kernel.org; Wed, 21 Sep 2022 11:24:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ob1Bc-0006EJ-JE for qemu-devel@nongnu.org; Wed, 21 Sep 2022 10:58:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:28631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ob1Ba-0005gR-3v for qemu-devel@nongnu.org; Wed, 21 Sep 2022 10:58:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663772329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NPcoKO72jui4B5SKZN97MFAWpvw5x4340T7da1lwJU4=; b=WNVu0IUhqwRwpYXWoSf9ugBPJRdaYwuwv7x85lOPltAGpLa5/JVBb9vckLHPo8KFenhlkQ EF7I40yTwV8YGueVs3cuvtB11R6VWnwKMGTL1nkGNmYbqmhTTK2wC2Lf54H1vjaVs7K3TM tEstWmVC6dS+kIzzKeAXVzb4a/i9EG0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-179-_mW9hpDOMSmhK6xLD0hJRg-1; Wed, 21 Sep 2022 10:58:45 -0400 X-MC-Unique: _mW9hpDOMSmhK6xLD0hJRg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7C9F1101CC67; Wed, 21 Sep 2022 14:58:45 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C27D2028E98; Wed, 21 Sep 2022 14:58:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1299F21E6900; Wed, 21 Sep 2022 16:58:44 +0200 (CEST) From: Markus Armbruster To: Laurent Vivier Cc: qemu-devel@nongnu.org, Jason Wang , Paolo Bonzini , Gregory Kurz , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Eric Blake , Thomas Huth , David Gibson , "Dr. David Alan Gilbert" Subject: Re: [PATCH v8 13/14] net: stream: move to QIO References: <20220913064000.79353-1-lvivier@redhat.com> <20220913064000.79353-14-lvivier@redhat.com> Date: Wed, 21 Sep 2022 16:58:44 +0200 In-Reply-To: <20220913064000.79353-14-lvivier@redhat.com> (Laurent Vivier's message of "Tue, 13 Sep 2022 08:39:59 +0200") Message-ID: <87mtasai57.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Laurent Vivier writes: > Use QIOChannel, QIOChannelSocket and QIONetListener. > > Signed-off-by: Laurent Vivier > --- [...] > diff --git a/qemu-options.hx b/qemu-options.hx > index ee2436ae14a7..a0b5b70c80cb 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2732,8 +2732,8 @@ DEF("netdev", HAS_ARG, QEMU_OPTION_netdev, > "-netdev socket,id=str[,fd=h][,udp=host:port][,localaddr=host:port]\n" > " configure a network backend to connect to another network\n" > " using an UDP tunnel\n" > - "-netdev stream,id=str[,server=on|off],addr.type=inet,addr.host=host,addr.port=port\n" > - "-netdev stream,id=str[,server=on|off],addr.type=unix,addr.path=path\n" > + "-netdev stream,id=str[,server=on|off],addr.type=inet,addr.host=host,addr.port=port[,to=maxport][,numeric=on|off][,keep-alive=on|off][,mptcp=on|off][,addr.ipv4=on|off][,addr.ipv6=on|off]\n" > + "-netdev stream,id=str[,server=on|off],addr.type=unix,addr.path=path[,abstract=on|off][,tight=on|off]\n" > "-netdev stream,id=str[,server=on|off],addr.type=fd,addr.str=h\n" > " configure a network backend to connect to another network\n" > " using a socket connection in stream mode.\n" The commit message didn't prepare me for this change. Could you explain?