From: Peter Korsgaard <peter@korsgaard.com>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: br015@umbiko.net, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3 4/5] package/ifupdown-scripts: add wifi configuration when enabled
Date: Sun, 18 Sep 2022 12:03:05 +0200 [thread overview]
Message-ID: <87mtaxgfty.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220705073206.1442280-5-angelo@amarulasolutions.com> (Angelo Compagnucci's message of "Tue, 5 Jul 2022 09:32:05 +0200")
>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:
> Add a proper wpa-conf line to the interfaces files to let the system
> bringup the wifi interface and the related wpa supplicant.
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> Changes:
> v3:
> * add "|| true" lo let the command exit without error when
> BR2_SYSTEM_CONNECT_WIFI is empty (me)
> package/ifupdown-scripts/ifupdown-scripts.mk | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/package/ifupdown-scripts/ifupdown-scripts.mk b/package/ifupdown-scripts/ifupdown-scripts.mk
> index 5ef032142c..ebaf234143 100644
> --- a/package/ifupdown-scripts/ifupdown-scripts.mk
> +++ b/package/ifupdown-scripts/ifupdown-scripts.mk
> @@ -28,6 +28,8 @@ define IFUPDOWN_SCRIPTS_DHCP
> echo " pre-up /etc/network/nfs_check"; \
> echo " wait-delay 15"; \
> echo " hostname \$$(hostname)"; \
> + test -n "$(BR2_SYSTEM_CONNECT_WIFI)" && \
> + echo " wpa-conf /etc/wpa_supplicant.conf" || true; \
> ) >> $(TARGET_DIR)/etc/network/interfaces
Maybe we should do this unconditionally if we overwrite
/etc/network/interfaces and wpa_supplicant is enabled?
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-09-18 10:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 7:32 [Buildroot] [PATCH v3 0/5] Configure default wifi through kconfig Angelo Compagnucci
2022-07-05 7:32 ` [Buildroot] [PATCH v3 1/5] system: adding options for configuring wifi Angelo Compagnucci
2022-09-18 9:57 ` Peter Korsgaard
2022-10-03 15:42 ` Angelo Compagnucci
2022-10-04 9:05 ` Andreas Ziegler
2022-10-04 9:14 ` Angelo Compagnucci
2022-07-05 7:32 ` [Buildroot] [PATCH v3 2/5] package/wpa_supplicant: configure wifi on systemv when enabled Angelo Compagnucci
2022-07-05 7:32 ` [Buildroot] [PATCH v3 3/5] package/wpa_supplicant: configure wifi on systemd " Angelo Compagnucci
2022-09-18 10:00 ` Peter Korsgaard
2022-10-03 15:44 ` Angelo Compagnucci
2022-07-05 7:32 ` [Buildroot] [PATCH v3 4/5] package/ifupdown-scripts: add wifi configuration " Angelo Compagnucci
2022-09-18 10:03 ` Peter Korsgaard [this message]
2022-10-03 15:50 ` Angelo Compagnucci
2022-07-05 7:32 ` [Buildroot] [PATCH v3 5/5] package/initscripts: add service to load kernel modules at boot Angelo Compagnucci
2022-09-18 10:10 ` Peter Korsgaard
2022-10-03 15:53 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtaxgfty.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=angelo@amarulasolutions.com \
--cc=br015@umbiko.net \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.