From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CDFAC43334 for ; Thu, 23 Jun 2022 18:29:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B24BC10E340; Thu, 23 Jun 2022 18:29:50 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7145C10E340 for ; Thu, 23 Jun 2022 18:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656008989; x=1687544989; h=from:to:subject:in-reply-to:references:date:message-id: mime-version:content-transfer-encoding; bh=pvMAva/b2xptk7S394XE3gf3SAa2Jd2NCB71L3njzVw=; b=TW8YkerwDd3v2wcWOVpqG+5rPxCCH+Zn+W39WEamrPP+Us2RNXexWxe5 8lcD83Ea9pSmR6T8UnO49/fZMD01Y8v36PanJUYcKPbA53sB8+hGEy2dC 3XAslHFlYx4Z9xq7l8VPpK/DXoz3654O12f3Vl4DANGqviQ6ZZSGzIO+V nuHqG4nhHZYAsguCmvxaU4WrL3HgrW3UbsafdMS2yDoifZDZ7ckiCaeAh 7sq+251F/s8x4Q03pnHkG5SXsrx1zifNSwLjmocdJwwY3nkXzB1vty/ue gSGeGoggPbjw6j6OHFOjsnoAd7QWArX3UwhEQdxARqctGaNxjigbfjoO/ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10387"; a="306266437" X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="306266437" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 11:29:48 -0700 X-IronPort-AV: E=Sophos;i="5.92,216,1650956400"; d="scan'208";a="644870781" Received: from anefedov-mobl.ccr.corp.intel.com (HELO localhost) ([10.252.38.20]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2022 11:29:46 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org In-Reply-To: <87pmizmdzw.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220623130900.26078-1-ville.syrjala@linux.intel.com> <87pmizmdzw.fsf@intel.com> Date: Thu, 23 Jun 2022 21:29:42 +0300 Message-ID: <87mte3mdwp.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 0/9] drm/i915: Display info cleanup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 23 Jun 2022, Jani Nikula wrote: > On Thu, 23 Jun 2022, Ville Syrjala wrote: >> From: Ville Syrj=C3=A4l=C3=A4 >> >> Collect more stuff under INTEL_INFO->display, and clean up >> some messy stuff in the related register macros. > > Makes me wonder if we should have DISPLAY_INFO(i915) macro that returns > a pointer to the display sub-struct. > > Anyway, the series is > > Reviewed-by: Jani Nikula PS. Here's a somewhat related device info cleanup: https://patchwork.freedesktop.org/series/105358/ > > >> >> Ville Syrj=C3=A4l=C3=A4 (9): >> drm/i915: Move dbuf details to INTEL_INFO->display >> drm/i195: Move pipe_offsets[] & co. to INTEL_INFO->display >> drm/i915: Move display_mmio_offset under INTEL_INFO->display >> drm/i915: Make pipe_offsets[] & co. u32 >> drm/i915: s/_CURSOR2/_MMIO_CURSOR2// >> drm/i915: Use _MMIO_TRANS2() where appropriate >> drm/i915: Use _MMIO_PIPE2() where appropriate >> drm/i915: Get rid of XE_LPD_CURSOR_OFFSETS >> drm/i915: Move the color stuff under INTEL_INFO->display >> >> drivers/gpu/drm/i915/display/intel_color.c | 28 ++--- >> drivers/gpu/drm/i915/display/intel_display.h | 2 +- >> .../drm/i915/display/intel_display_power.c | 2 +- >> drivers/gpu/drm/i915/i915_pci.c | 112 +++++++++--------- >> drivers/gpu/drm/i915/i915_reg.h | 47 ++++---- >> drivers/gpu/drm/i915/intel_device_info.h | 39 +++--- >> drivers/gpu/drm/i915/intel_pm.c | 8 +- >> 7 files changed, 117 insertions(+), 121 deletions(-) --=20 Jani Nikula, Intel Open Source Graphics Center