From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33086C43334 for ; Wed, 22 Jun 2022 08:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351259AbiFVIDw (ORCPT ); Wed, 22 Jun 2022 04:03:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354477AbiFVIDc (ORCPT ); Wed, 22 Jun 2022 04:03:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAF6F377C7 for ; Wed, 22 Jun 2022 01:03:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 24250B81C61 for ; Wed, 22 Jun 2022 08:03:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5952C34114; Wed, 22 Jun 2022 08:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655885008; bh=5O/HOhRSOCVpFinFHziNj7uoZPyFmF9ojf/VPNXiAFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O4986NoBk4BmT9lZ5QmZtICebhUQ+G7rSHPfLN+fb/mNS3/yNEjHgwzeWSTf3vDiY kJNQopvHRnNx4gkv5gfp7ZtJbrd6KMdKkJTtVuUUi8kzaa/YKIEcroE3Jf8byDxs5d I9FltDJggPenyFqteZ0OBdPub56Xe2JNIYM8MWBAv+ETfgUv+d+vHchTkYTk4eouWp nWIgmPLo2bNPaIpfojoGGZQ7PcwbX/vYvE2GHgdTGoaMUyb/9ZIm+JQb1f9/3pdBgx K7De7cDvnDzanRJ0TWKMNDJO0hLRW2Bq8+0ux9eLQiNs01jQ1Z5NRuaPRtD/yRt+0V y8E5M0UP8l+nA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o3vKg-002FT3-Gs; Wed, 22 Jun 2022 09:03:26 +0100 Date: Wed, 22 Jun 2022 09:03:26 +0100 Message-ID: <87mte52khd.wl-maz@kernel.org> From: Marc Zyngier To: Liang He Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, Miaoqian Lin Subject: Re: [PATCH] irqchip: Add missing of_ndoe_get() in its_of_probe() In-Reply-To: <20220622062138.4095598-1-windhl@126.com> References: <20220622062138.4095598-1-windhl@126.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: windhl@126.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, linmq006@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Miaoqian Lin On Wed, 22 Jun 2022 07:21:38 +0100, Liang He wrote: > > We need to add missing of_node_get() for of_find_matching_node() to > keep refcount balance. > > Note: of_find_matching_node() will decrease the refcount of its first > arg. > > Signed-off-by: Liang He [...] Please send these refcount fixes as a series for all the irqchip drivers, not one every other day. And please synchronise with Miaoqian Lin, as you are obviously both chasing the same bugs. Thanks, M. -- Without deviation from the norm, progress is not possible.