From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFA1DC433F5 for ; Fri, 20 May 2022 08:01:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 18FA41727; Fri, 20 May 2022 10:00:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 18FA41727 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1653033680; bh=BNhFbqn75SZjOLAjT8wFWKFcIMqwznG0G3VjD27H2T0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XbkGlr3qo/XOcIR4Jshdj7VFuGmkuqeF/M6kg3DVDcvlCOeuf6f2UE47mwvxlRsPh mhptd/gAc3qvQhqdFPMYeXGgIrD6UBNz1ujw1xKKu33EJcXRW1VN8vghrbdPhJlYxX bev1RmytyC5x0JKYys2RXUP6RKb59P9VQwKTNITc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AB02BF80153; Fri, 20 May 2022 10:00:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 652F9F8019D; Fri, 20 May 2022 10:00:28 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 78825F80109 for ; Fri, 20 May 2022 10:00:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 78825F80109 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="c8aF8z94"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="e5fyizbY" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 5E2C41F894; Fri, 20 May 2022 08:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1653033618; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kMKh/Uy0Fns4/DVHh6qKhq/hSbzRGo3igA2tqZ9EFDk=; b=c8aF8z9411V6NZY1bfOQpBZUqrNA0TtQggHEsriTXMomPg3VrgKzxBi1qmba5LP+2GDu7N 9ZDIlIIwgm3g7vY4pqprmwTu20syL/4HiH1Qz5C8P4w6sXgA+ZmLSaNEkeA2lmTaTYsCeB 7A+9HcqURLGSvpzwSXaL2SL5mq6YDVk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1653033618; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kMKh/Uy0Fns4/DVHh6qKhq/hSbzRGo3igA2tqZ9EFDk=; b=e5fyizbYQmJwGI/73KkgRbu2+OWQo0fz9mPNBt7gd1hB6k+eq4mVf2cEqAG+mrkV9W6dy+ 50JyoEMNSeS85CCw== Received: from valkyrie.site.suse.de (unknown [10.163.18.242]) by relay2.suse.de (Postfix) with ESMTP id 2F3C02C141; Fri, 20 May 2022 08:00:18 +0000 (UTC) Date: Fri, 20 May 2022 10:00:18 +0200 Message-ID: <87mtfcr5v1.wl-tiwai@suse.de> From: Takashi Iwai To: Vitaly Rodionov Subject: Re: [PATCH v3 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading In-Reply-To: <20220519174749.15459-5-vitalyr@opensource.cirrus.com> References: <20220519174749.15459-1-vitalyr@opensource.cirrus.com> <20220519174749.15459-5-vitalyr@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/27 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Takashi Iwai , linux-kernel@vger.kernel.org, Mark Brown , Vitaly Rodionov X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 19 May 2022 19:47:36 +0200, Vitaly Rodionov wrote: > > From: Vitaly Rodionov > > This patch adds support for the CS35L41 DSP. > The DSP allows for extra features, such as running > speaker protection algorithms and hibernations. > > To utilize these features, the driver must load > firmware into the DSP, as well as various tuning > files which allow for cusomtization for specific > models. Wouldn't this sequence be required after S3/S4 resume? I thought cs35l41_hda_bind() is called only at the first binding. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D25DDC433F5 for ; Fri, 20 May 2022 08:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346750AbiETIAb (ORCPT ); Fri, 20 May 2022 04:00:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346789AbiETIA0 (ORCPT ); Fri, 20 May 2022 04:00:26 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E8A815D335 for ; Fri, 20 May 2022 01:00:19 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 5E2C41F894; Fri, 20 May 2022 08:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1653033618; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kMKh/Uy0Fns4/DVHh6qKhq/hSbzRGo3igA2tqZ9EFDk=; b=c8aF8z9411V6NZY1bfOQpBZUqrNA0TtQggHEsriTXMomPg3VrgKzxBi1qmba5LP+2GDu7N 9ZDIlIIwgm3g7vY4pqprmwTu20syL/4HiH1Qz5C8P4w6sXgA+ZmLSaNEkeA2lmTaTYsCeB 7A+9HcqURLGSvpzwSXaL2SL5mq6YDVk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1653033618; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kMKh/Uy0Fns4/DVHh6qKhq/hSbzRGo3igA2tqZ9EFDk=; b=e5fyizbYQmJwGI/73KkgRbu2+OWQo0fz9mPNBt7gd1hB6k+eq4mVf2cEqAG+mrkV9W6dy+ 50JyoEMNSeS85CCw== Received: from valkyrie.site.suse.de (unknown [10.163.18.242]) by relay2.suse.de (Postfix) with ESMTP id 2F3C02C141; Fri, 20 May 2022 08:00:18 +0000 (UTC) Date: Fri, 20 May 2022 10:00:18 +0200 Message-ID: <87mtfcr5v1.wl-tiwai@suse.de> From: Takashi Iwai To: Vitaly Rodionov Cc: Jaroslav Kysela , Takashi Iwai , "Mark Brown" , , , , Vitaly Rodionov Subject: Re: [PATCH v3 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading In-Reply-To: <20220519174749.15459-5-vitalyr@opensource.cirrus.com> References: <20220519174749.15459-1-vitalyr@opensource.cirrus.com> <20220519174749.15459-5-vitalyr@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/27 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 19 May 2022 19:47:36 +0200, Vitaly Rodionov wrote: > > From: Vitaly Rodionov > > This patch adds support for the CS35L41 DSP. > The DSP allows for extra features, such as running > speaker protection algorithms and hibernations. > > To utilize these features, the driver must load > firmware into the DSP, as well as various tuning > files which allow for cusomtization for specific > models. Wouldn't this sequence be required after S3/S4 resume? I thought cs35l41_hda_bind() is called only at the first binding. thanks, Takashi