From mboxrd@z Thu Jan  1 00:00:00 1970
References: <20220402142127.944138-1-rpm@xenomai.org>
 <CAFLxGvx7v5PyoxW0SaFaNLh6eO9i0k0Wo7nu+1Tjz1QU5LzbcQ@mail.gmail.com>
From: Philippe Gerum <rpm@xenomai.org>
Subject: Re: [PATCH 1/4] sched: dovetail: pass thread-info bits to
 arch_dovetail_switch_finish()
Date: Sun, 03 Apr 2022 16:40:03 +0200
In-reply-to: <CAFLxGvx7v5PyoxW0SaFaNLh6eO9i0k0Wo7nu+1Tjz1QU5LzbcQ@mail.gmail.com>
Message-ID: <87mth2ns7l.fsf@xenomai.org>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: Discussions about the Xenomai project <xenomai.xenomai.org>
List-Unsubscribe: <https://xenomai.org/mailman/options/xenomai>,
 <mailto:xenomai-request@xenomai.org?subject=unsubscribe>
List-Archive: <http://xenomai.org/pipermail/xenomai/>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-request@xenomai.org?subject=help>
List-Subscribe: <https://xenomai.org/mailman/listinfo/xenomai>,
 <mailto:xenomai-request@xenomai.org?subject=subscribe>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: Xenomai <xenomai@xenomai.org>


Richard Weinberger <richard.weinberger@gmail.com> writes:

> On Sat, Apr 2, 2022 at 4:23 PM Philippe Gerum via Xenomai
> <xenomai@xenomai.org> wrote:
>
>> -       arch_dovetail_switch_finish(leave_inband);
>> +       ti_work = READ_ONCE(current_thread_info()->flags);
>> +       arch_dovetail_switch_finish(leave_inband, ti_work);
>
> Why are you passing ti_work as parameter? AFAIU you can
> use current_thread_info()->flags directly in arch_dovetail_switch_finish().

Agreed, this affects the signature of arch_dovetail_switch_finish() for
no good reason. Besides, this patch is missing a case (task resuming
after oob -> inband transition). v2 follows (tested ok here).

-- 
Philippe.