From: Markus Armbruster <armbru@redhat.com>
To: Victor Toso <victortoso@redhat.com>
Cc: John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2.1] qapi: fix example of BLOCK_IMAGE_CORRUPTED event
Date: Mon, 28 Mar 2022 13:16:54 +0200 [thread overview]
Message-ID: <87mtha9vix.fsf@pond.sub.org> (raw)
In-Reply-To: <20220328090531.7332-1-victortoso@redhat.com> (Victor Toso's message of "Mon, 28 Mar 2022 11:05:31 +0200")
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @fatal. Provide it.
>
> Example output shows a value of @msg no version of the code
> produces. No big deal, but replace it anyway by one that
> today's code does produce.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/block-core.json | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index e89f2dfb5b..63c30a5378 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -5006,10 +5006,9 @@
> # Example:
> #
> # <- { "event": "BLOCK_IMAGE_CORRUPTED",
> -# "data": { "device": "ide0-hd0", "node-name": "node0",
> -# "msg": "Prevented active L1 table overwrite", "offset": 196608,
> -# "size": 65536 },
> -# "timestamp": { "seconds": 1378126126, "microseconds": 966463 } }
> +# "data": { "device": "", "node-name": "drive", "fatal": false,
> +# "msg": "L2 table offset 0x2a2a2a00 unaligned (L1 index: 0)" },
> +# "timestamp": { "seconds": 1648243240, "microseconds": 906060 } }
> #
> # Since: 1.7
> ##
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2022-03-28 11:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 22:06 [PATCH v2 00/14] Fix some qapi examples and a TODO section Victor Toso
2022-03-25 22:06 ` [PATCH v2 01/14] qapi: BlockExportRemoveMode: move comments to TODO Victor Toso
2022-03-25 22:06 ` [PATCH v2 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Victor Toso
2022-03-28 8:54 ` Markus Armbruster
2022-03-28 9:06 ` Victor Toso
2022-03-28 11:19 ` Markus Armbruster
2022-03-28 13:22 ` Victor Toso
2022-03-28 9:05 ` [PATCH v2.1] " Victor Toso
2022-03-28 11:16 ` Markus Armbruster [this message]
2022-03-25 22:06 ` [PATCH v2 03/14] qapi: fix example of BLOCK_IO_ERROR event Victor Toso
2022-03-25 22:06 ` [PATCH v2 04/14] qapi: fix example of BLOCK_JOB_PENDING event Victor Toso
2022-03-25 22:06 ` [PATCH v2 05/14] qapi: fix example of DUMP_COMPLETED event Victor Toso
2022-03-25 22:06 ` [PATCH v2 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Victor Toso
2022-03-25 22:07 ` [PATCH v2 07/14] qapi: fix example of UNPLUG_PRIMARY event Victor Toso
2022-03-25 22:07 ` [PATCH v2 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Victor Toso
2022-03-25 22:07 ` [PATCH v2 09/14] qapi: fix examples: SHUTDOWN and RESET events Victor Toso
2022-03-25 22:07 ` [PATCH v2 10/14] qapi: run-state examples: add missing timestamp Victor Toso
2022-03-25 22:07 ` [PATCH v2 11/14] qapi: fix example of MEMORY_FAILURE Victor Toso
2022-03-25 22:07 ` [PATCH v2 12/14] qapi: ui examples: add missing websocket member Victor Toso
2022-03-25 22:07 ` [PATCH v2 13/14] qapi: fix example of ACPI_DEVICE_OST event Victor Toso
2022-03-25 22:07 ` [PATCH v2 14/14] qapi: fix example of dump-guest-memory Victor Toso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtha9vix.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=victortoso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.