Re: [PATCH v20 2/7] net/vmnet: add vmnet backends to qapi/net

[Markus Armbruster <armbru@redhat.com>]

Vladislav Yaroshchuk <vladislav.yaroshchuk@jetbrains.com> writes:

> On Wed, Mar 16, 2022 at 4:58 PM Markus Armbruster <armbru@redhat.com> wrote:
>
>> Vladislav Yaroshchuk <vladislav.yaroshchuk@jetbrains.com> writes:
>>
>> > Create separate netdevs for each vmnet operating mode:
>> > - vmnet-host
>> > - vmnet-shared
>> > - vmnet-bridged
>> >
>> > Signed-off-by: Vladislav Yaroshchuk <Vladislav.Yaroshchuk@jetbrains.com>
>>
>> Any QAPI schema changes since v15?  I'm asking because I acked v8, v13,
>> and v15, but each time you neglected to carry my Acked-by lines in later
>> revisions.
>>
>>
> QAPI is not changed, but the "Since" statement was updated
> for new netdevs (7.0 -> 7.1). That's the reason why I dropped
> your Acked-by. I've also mentioned this in cover letter:

You mean I'm supposed to read the cover letter?!?  (I am).

> v15 -> v16
> [...]
>  - QAPI: change version to 7.1 (cause 7.0 feature freeze
>    happened). This is the only change in QAPI, Markus Armbruster,
>    please confirm if you can (decided to drop your Acked-by due
>    to this change)

Clerical change, keeping my Acked-by would've been fine.

> [...]

QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>

Thanks!