From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Wenli Looi <wlooi@ucalgary.ca>, Kalle Valo <kvalo@kernel.org>
Cc: ath9k-devel@qca.qualcomm.com,
Miaoqing Pan <miaoqing@codeaurora.org>,
linux-wireless@vger.kernel.org
Subject: Re: QCN5502 support in ath9k
Date: Thu, 10 Mar 2022 00:24:08 +0100 [thread overview]
Message-ID: <87mthyvhev.fsf@toke.dk> (raw)
In-Reply-To: <CAKe_nd3Hc+5u9O0Bd31oFF_mTOJU9bx5hmcS1TkSy0FMtQamBA@mail.gmail.com>
Wenli Looi <wlooi@ucalgary.ca> writes:
> I've managed to get QCN5502 working in ath9k in a very hacky way, by
> mainly treating it as QCA956x, including the initvals:
>
> https://github.com/openwrt/openwrt/pull/9389
>
> It would be great if anyone could provide comments on the code, as
> well as the ideas for incorporating this cleanly into ath9k (and
> whether there would be interest in doing so).
I certainly wouldn't mind merging this support if it can be implemented
in a clean way; we'd have to be sure it doesn't break anything on
existing devices, of course.
You'll have to split out the code to co-exist with the ar9003. My
immediate thought would be that it would be a mistake to employ too
clever tricks to maximise code reuse. By all means, try to reuse as much
code as possible, but I'd rather take a bit of code duplication than end
up with something that works in non-obvious ways :)
Hope that helps!
-Toke
next prev parent reply other threads:[~2022-03-09 23:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKe_nd1jthFhJhojQLXMeU741AoTks74K+J1v5FqS6ABB6gW-Q@mail.gmail.com>
2022-02-08 11:08 ` QCN5502 support in ath9k Kalle Valo
2022-03-09 22:38 ` Wenli Looi
2022-03-09 23:24 ` Toke Høiland-Jørgensen [this message]
2022-03-11 1:55 ` Wenli Looi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mthyvhev.fsf@toke.dk \
--to=toke@redhat.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing@codeaurora.org \
--cc=wlooi@ucalgary.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.