From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 00/17] drm/i915: M/N cleanup
Date: Mon, 31 Jan 2022 17:10:01 +0200 [thread overview]
Message-ID: <87mtjcuek6.fsf@intel.com> (raw)
In-Reply-To: <20220128103757.22461-1-ville.syrjala@linux.intel.com>
On Fri, 28 Jan 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Rehashed version of the M/N cleanup after Jani (rightly)
> complained about the legibility of some of the patches in
> the v1 series. These are chunked to a finer pulp, some got
> revised a bit, and I left out a few of the FDI related
> things for now. I'll revisit the PCH port/FDI topic later,
> for now I just slapped in an extra patch to make sure we
> don't try to use DRRS on PCH ports.
I've commented on one bug that needs fixing, and some nitpicks and
future suggestions, but overall the series is
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
> Ville Syrjälä (17):
> drm/i915: Nuke intel_dp_set_m_n()
> drm/i915: Nuke intel_dp_get_m_n()
> drm/i915: Nuke ilk_get_fdi_m_n_config()
> drm/i915: Split intel_cpu_transcoder_set_m_n() into M1/N1 vs. M2/N2
> variants
> drm/i915: Split intel_cpu_transcoder_get_m_n() into M1/N1 vs. M2/N2
> variants
> drm/i915: Pass crtc+cpu_transcoder to intel_cpu_transcoder_set_m_n()
> drm/i915: Move PCH transcoder M/N setup into the PCH code
> drm/i915: Move M/N setup to a more logical place on ddi platforms
> drm/i915: Extract {i9xx,ilk}_configure_cpu_transcoder()
> drm/i915: Disable DRRS on IVB/HSW port != A
> drm/i915: Extract can_enable_drrs()
> drm/i915: Fix intel_cpu_transcoder_has_m2_n2()
> drm/i915: Clear DP M2/N2 when not doing DRRS
> drm/i915: Program pch transcoder m2/n2
> drm/i915: Dump dp_m2_n2 always
> drm/i915: Always check dp_m2_n2 on pre-bdw
> drm/i915: Document BDW+ DRRS M/N programming requirements
>
> drivers/gpu/drm/i915/display/g4x_dp.c | 18 +-
> drivers/gpu/drm/i915/display/intel_ddi.c | 14 +-
> drivers/gpu/drm/i915/display/intel_display.c | 266 ++++++++----------
> drivers/gpu/drm/i915/display/intel_display.h | 32 ++-
> .../drm/i915/display/intel_display_types.h | 19 --
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 -
> drivers/gpu/drm/i915/display/intel_drrs.c | 50 +++-
> .../gpu/drm/i915/display/intel_pch_display.c | 54 +++-
> .../gpu/drm/i915/display/intel_pch_display.h | 6 +
> 9 files changed, 259 insertions(+), 202 deletions(-)
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2022-01-31 15:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 10:37 [Intel-gfx] [PATCH v2 00/17] drm/i915: M/N cleanup Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 01/17] drm/i915: Nuke intel_dp_set_m_n() Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 02/17] drm/i915: Nuke intel_dp_get_m_n() Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 03/17] drm/i915: Nuke ilk_get_fdi_m_n_config() Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 04/17] drm/i915: Split intel_cpu_transcoder_set_m_n() into M1/N1 vs. M2/N2 variants Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 05/17] drm/i915: Split intel_cpu_transcoder_get_m_n() " Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 06/17] drm/i915: Pass crtc+cpu_transcoder to intel_cpu_transcoder_set_m_n() Ville Syrjala
2022-01-31 14:37 ` Jani Nikula
2022-01-31 18:29 ` Ville Syrjälä
2022-01-31 18:42 ` Ville Syrjälä
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 07/17] drm/i915: Move PCH transcoder M/N setup into the PCH code Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 08/17] drm/i915: Move M/N setup to a more logical place on ddi platforms Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 09/17] drm/i915: Extract {i9xx, ilk}_configure_cpu_transcoder() Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 10/17] drm/i915: Disable DRRS on IVB/HSW port != A Ville Syrjala
2022-01-28 10:37 ` Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 11/17] drm/i915: Extract can_enable_drrs() Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 12/17] drm/i915: Fix intel_cpu_transcoder_has_m2_n2() Ville Syrjala
2022-01-31 15:05 ` Jani Nikula
2022-01-31 18:39 ` Ville Syrjälä
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 13/17] drm/i915: Clear DP M2/N2 when not doing DRRS Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 14/17] drm/i915: Program pch transcoder m2/n2 Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 15/17] drm/i915: Dump dp_m2_n2 always Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 16/17] drm/i915: Always check dp_m2_n2 on pre-bdw Ville Syrjala
2022-01-28 10:37 ` [Intel-gfx] [PATCH v2 17/17] drm/i915: Document BDW+ DRRS M/N programming requirements Ville Syrjala
2022-01-28 11:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: M/N cleanup (rev3) Patchwork
2022-01-28 11:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-01-28 13:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: M/N cleanup (rev4) Patchwork
2022-01-28 14:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-28 21:36 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-01-31 15:10 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtjcuek6.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.