From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB183C433EF for ; Mon, 10 Jan 2022 14:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235694AbiAJOoW (ORCPT ); Mon, 10 Jan 2022 09:44:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234981AbiAJOoV (ORCPT ); Mon, 10 Jan 2022 09:44:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 686A0C06173F for ; Mon, 10 Jan 2022 06:44:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E61CC60E33 for ; Mon, 10 Jan 2022 14:44:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BBB9C36AE3; Mon, 10 Jan 2022 14:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641825860; bh=QTlLtVmA4M6A/doosWcn+xwS48663pzABVMvW6Gyr4M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EgfaRDFnEHM8wW0auRDMXieHj6JQR1i6sQ/AQUPzl2To/Di+UjDQCQx1SaNNZJLUV kEuD+EQvJiqLHZrAFh+cuy9mPf3lK8KzbrAsXrrd0MfrydpsNb/4NH1DnADC3qL/P/ JJkzzf+qkZ7mPJtwn4mVOstZ4XokLm50gUy70hibpwLWXY5Q8IWSUX4HPXlKxQ5BMe sDJEMjDPYWOcdDZGFZaJJNcLc3Dy/My5Xti0vJeS/HMzIbuTz9+xzjZ0FoxCZYGKkn iTUFoBl9IFnfuhRUXh6x6zyVc4j1P4x/Z5yVrY5ZAMzdJYzLZbs5BHWTBWjsgde80K /JYuFi4b7mB+A== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n6vuD-00H9ok-V5; Mon, 10 Jan 2022 14:44:18 +0000 Date: Mon, 10 Jan 2022 14:44:17 +0000 Message-ID: <87mtk3tzum.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Marek =?UTF-8?B?QmVow7pu?= , Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 23/23] PCI: aardvark: Make main irq_chip structure a static driver structure In-Reply-To: <20220110105324.jud6bzdtmoiuvyas@pali> References: <20220110015018.26359-1-kabel@kernel.org> <20220110015018.26359-24-kabel@kernel.org> <20220110105324.jud6bzdtmoiuvyas@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, kabel@kernel.org, lorenzo.pieralisi@arm.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 10 Jan 2022 10:53:24 +0000, Pali Roh=C3=A1r wrote: >=20 > On Monday 10 January 2022 09:28:39 Marc Zyngier wrote: > > On 2022-01-10 01:50, Marek Beh=C3=BAn wrote: > > > Marc Zyngier says [1] that we should use struct irq_chip as a global > > > static struct in the driver. Even though the structure currently > > > contains a dynamic member (parent_device), Marc says [2] that he plans > > > to kill it and make the structure completely static. > > >=20 > > > We have already converted others irq_chip structures in this driver in > > > this way, but we omitted this one because the .name member is > > > dynamically created from device's name, and the name is displayed in > > > sysfs, so changing it would break sysfs ABI. > > >=20 > > > The rationale for changing the name (to "advk-INT") in spite of sysfs > > > ABI, and thus allowing to convert to a static structure, is that after > > > the other changes we made in this series, the IRQ chip is basically > > > something different: it no logner generates ERR and PME interrupts (t= hey > > > are generated by emulated bridge's rp_irq_chip). > >=20 > > There is no 'is spite of the ABI'. If you don't understand why > > we don't break the ABI, you have an even bigger problem. > >=20 > > So NAK to this patch, now and forever. Any change to the structure to > > make it read-only must allow the preservation of the existing names > > when they are generated by the driver. >=20 > Marc, you already presented that you do not like Armada 3720 platform > and that you do not care about it. What I like or not is irrelevant here. What I ask for is that userspace ABIs are not broken. > But please do not slowdown development for this platform. That's quite an accusation. > Arguments about ABIs, breaking it and similar are not relevant here as > this current kernel implementation is broken. And has to be replaced by > a working one. We are doing on it for more than year. > > It really does not make sense to try doing some backward compatibility > with something which is broken by design and does not work. It just take > lot of time without any value. >=20 > We really need to more forward and fix driver as in current state is > PCIe on Armada 3720 unusable. This patch doesn't fix anything. It has the potential to break userspace, and I'm not having any of it. You may not care about backward compatibility, but this is thankfully *not* your pet playground. You can claim that I am doing a bad job. In which case, feel free to submit a patch removing me from the MAINTAINER file, and we can have that discussion. In the meantime, I will continue to oppose these kind of patches that pretend to 'fix' things without adding any value. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8784FC433F5 for ; Mon, 10 Jan 2022 14:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Iqp9qdrQh06oy4QWHBbhJwjEAhetITSQu9CQaNaBj+g=; b=vYzqHThf1Hz8jc fJRy2E4TmntOLpXDg4+zKuIjE3ZRxA5a+EA/WcdcsOqEGPoZ4gIbMRkxw4DU1yEbsazziFDOPIm+k YBZ9RBao7tdP6K5tvfi1JOmea2gU3KyRkMV5/N9fbmzQK8awa7DyXFPT8k0b3jtyItO2qCkgWkpY8 YpgiG33VVREUKlvxs0l5u5TkTjQMC9KyReBsH5iY5EkwQnWZ1ha+HebCl5ofzjG67RF9Cmt87aQkL Uq/d30/YoCBOwl1DRIXLFzNGydFEdYgSnyoIKAJg2NCB1ug/+ut8dRUdthKF/P/A3raDqvwfAKaMi OVfVFQHD3nKXwMaOj+7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6vuN-00BskX-3i; Mon, 10 Jan 2022 14:44:27 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6vuI-00BsiV-VS for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 14:44:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 77D84B81662; Mon, 10 Jan 2022 14:44:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BBB9C36AE3; Mon, 10 Jan 2022 14:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1641825860; bh=QTlLtVmA4M6A/doosWcn+xwS48663pzABVMvW6Gyr4M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EgfaRDFnEHM8wW0auRDMXieHj6JQR1i6sQ/AQUPzl2To/Di+UjDQCQx1SaNNZJLUV kEuD+EQvJiqLHZrAFh+cuy9mPf3lK8KzbrAsXrrd0MfrydpsNb/4NH1DnADC3qL/P/ JJkzzf+qkZ7mPJtwn4mVOstZ4XokLm50gUy70hibpwLWXY5Q8IWSUX4HPXlKxQ5BMe sDJEMjDPYWOcdDZGFZaJJNcLc3Dy/My5Xti0vJeS/HMzIbuTz9+xzjZ0FoxCZYGKkn iTUFoBl9IFnfuhRUXh6x6zyVc4j1P4x/Z5yVrY5ZAMzdJYzLZbs5BHWTBWjsgde80K /JYuFi4b7mB+A== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n6vuD-00H9ok-V5; Mon, 10 Jan 2022 14:44:18 +0000 Date: Mon, 10 Jan 2022 14:44:17 +0000 Message-ID: <87mtk3tzum.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Marek =?UTF-8?B?QmVow7pu?= , Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 23/23] PCI: aardvark: Make main irq_chip structure a static driver structure In-Reply-To: <20220110105324.jud6bzdtmoiuvyas@pali> References: <20220110015018.26359-1-kabel@kernel.org> <20220110015018.26359-24-kabel@kernel.org> <20220110105324.jud6bzdtmoiuvyas@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: pali@kernel.org, kabel@kernel.org, lorenzo.pieralisi@arm.com, helgaas@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_064423_312286_1678B531 X-CRM114-Status: GOOD ( 41.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxMCBKYW4gMjAyMiAxMDo1MzoyNCArMDAwMCwKUGFsaSBSb2jDoXIgPHBhbGlAa2Vy bmVsLm9yZz4gd3JvdGU6Cj4gCj4gT24gTW9uZGF5IDEwIEphbnVhcnkgMjAyMiAwOToyODozOSBN YXJjIFp5bmdpZXIgd3JvdGU6Cj4gPiBPbiAyMDIyLTAxLTEwIDAxOjUwLCBNYXJlayBCZWjDum4g d3JvdGU6Cj4gPiA+IE1hcmMgWnluZ2llciBzYXlzIFsxXSB0aGF0IHdlIHNob3VsZCB1c2Ugc3Ry dWN0IGlycV9jaGlwIGFzIGEgZ2xvYmFsCj4gPiA+IHN0YXRpYyBzdHJ1Y3QgaW4gdGhlIGRyaXZl ci4gRXZlbiB0aG91Z2ggdGhlIHN0cnVjdHVyZSBjdXJyZW50bHkKPiA+ID4gY29udGFpbnMgYSBk eW5hbWljIG1lbWJlciAocGFyZW50X2RldmljZSksIE1hcmMgc2F5cyBbMl0gdGhhdCBoZSBwbGFu cwo+ID4gPiB0byBraWxsIGl0IGFuZCBtYWtlIHRoZSBzdHJ1Y3R1cmUgY29tcGxldGVseSBzdGF0 aWMuCj4gPiA+IAo+ID4gPiBXZSBoYXZlIGFscmVhZHkgY29udmVydGVkIG90aGVycyBpcnFfY2hp cCBzdHJ1Y3R1cmVzIGluIHRoaXMgZHJpdmVyIGluCj4gPiA+IHRoaXMgd2F5LCBidXQgd2Ugb21p dHRlZCB0aGlzIG9uZSBiZWNhdXNlIHRoZSAubmFtZSBtZW1iZXIgaXMKPiA+ID4gZHluYW1pY2Fs bHkgY3JlYXRlZCBmcm9tIGRldmljZSdzIG5hbWUsIGFuZCB0aGUgbmFtZSBpcyBkaXNwbGF5ZWQg aW4KPiA+ID4gc3lzZnMsIHNvIGNoYW5naW5nIGl0IHdvdWxkIGJyZWFrIHN5c2ZzIEFCSS4KPiA+ ID4gCj4gPiA+IFRoZSByYXRpb25hbGUgZm9yIGNoYW5naW5nIHRoZSBuYW1lICh0byAiYWR2ay1J TlQiKSBpbiBzcGl0ZSBvZiBzeXNmcwo+ID4gPiBBQkksIGFuZCB0aHVzIGFsbG93aW5nIHRvIGNv bnZlcnQgdG8gYSBzdGF0aWMgc3RydWN0dXJlLCBpcyB0aGF0IGFmdGVyCj4gPiA+IHRoZSBvdGhl ciBjaGFuZ2VzIHdlIG1hZGUgaW4gdGhpcyBzZXJpZXMsIHRoZSBJUlEgY2hpcCBpcyBiYXNpY2Fs bHkKPiA+ID4gc29tZXRoaW5nIGRpZmZlcmVudDogaXQgbm8gbG9nbmVyIGdlbmVyYXRlcyBFUlIg YW5kIFBNRSBpbnRlcnJ1cHRzICh0aGV5Cj4gPiA+IGFyZSBnZW5lcmF0ZWQgYnkgZW11bGF0ZWQg YnJpZGdlJ3MgcnBfaXJxX2NoaXApLgo+ID4gCj4gPiBUaGVyZSBpcyBubyAnaXMgc3BpdGUgb2Yg dGhlIEFCSScuIElmIHlvdSBkb24ndCB1bmRlcnN0YW5kIHdoeQo+ID4gd2UgZG9uJ3QgYnJlYWsg dGhlIEFCSSwgeW91IGhhdmUgYW4gZXZlbiBiaWdnZXIgcHJvYmxlbS4KPiA+IAo+ID4gU28gTkFL IHRvIHRoaXMgcGF0Y2gsIG5vdyBhbmQgZm9yZXZlci4gQW55IGNoYW5nZSB0byB0aGUgc3RydWN0 dXJlIHRvCj4gPiBtYWtlIGl0IHJlYWQtb25seSBtdXN0IGFsbG93IHRoZSBwcmVzZXJ2YXRpb24g b2YgdGhlIGV4aXN0aW5nIG5hbWVzCj4gPiB3aGVuIHRoZXkgYXJlIGdlbmVyYXRlZCBieSB0aGUg ZHJpdmVyLgo+IAo+IE1hcmMsIHlvdSBhbHJlYWR5IHByZXNlbnRlZCB0aGF0IHlvdSBkbyBub3Qg bGlrZSBBcm1hZGEgMzcyMCBwbGF0Zm9ybQo+IGFuZCB0aGF0IHlvdSBkbyBub3QgY2FyZSBhYm91 dCBpdC4KCldoYXQgSSBsaWtlIG9yIG5vdCBpcyBpcnJlbGV2YW50IGhlcmUuIFdoYXQgSSBhc2sg Zm9yIGlzIHRoYXQKdXNlcnNwYWNlIEFCSXMgYXJlIG5vdCBicm9rZW4uCgo+IEJ1dCBwbGVhc2Ug ZG8gbm90IHNsb3dkb3duIGRldmVsb3BtZW50IGZvciB0aGlzIHBsYXRmb3JtLgoKVGhhdCdzIHF1 aXRlIGFuIGFjY3VzYXRpb24uCgo+IEFyZ3VtZW50cyBhYm91dCBBQklzLCBicmVha2luZyBpdCBh bmQgc2ltaWxhciBhcmUgbm90IHJlbGV2YW50IGhlcmUgYXMKPiB0aGlzIGN1cnJlbnQga2VybmVs IGltcGxlbWVudGF0aW9uIGlzIGJyb2tlbi4gQW5kIGhhcyB0byBiZSByZXBsYWNlZCBieQo+IGEg d29ya2luZyBvbmUuIFdlIGFyZSBkb2luZyBvbiBpdCBmb3IgbW9yZSB0aGFuIHllYXIuCj4KPiBJ dCByZWFsbHkgZG9lcyBub3QgbWFrZSBzZW5zZSB0byB0cnkgZG9pbmcgc29tZSBiYWNrd2FyZCBj b21wYXRpYmlsaXR5Cj4gd2l0aCBzb21ldGhpbmcgd2hpY2ggaXMgYnJva2VuIGJ5IGRlc2lnbiBh bmQgZG9lcyBub3Qgd29yay4gSXQganVzdCB0YWtlCj4gbG90IG9mIHRpbWUgd2l0aG91dCBhbnkg dmFsdWUuCj4gCj4gV2UgcmVhbGx5IG5lZWQgdG8gbW9yZSBmb3J3YXJkIGFuZCBmaXggZHJpdmVy IGFzIGluIGN1cnJlbnQgc3RhdGUgaXMKPiBQQ0llIG9uIEFybWFkYSAzNzIwIHVudXNhYmxlLgoK VGhpcyBwYXRjaCBkb2Vzbid0IGZpeCBhbnl0aGluZy4gSXQgaGFzIHRoZSBwb3RlbnRpYWwgdG8g YnJlYWsKdXNlcnNwYWNlLCBhbmQgSSdtIG5vdCBoYXZpbmcgYW55IG9mIGl0LiBZb3UgbWF5IG5v dCBjYXJlIGFib3V0CmJhY2t3YXJkIGNvbXBhdGliaWxpdHksIGJ1dCB0aGlzIGlzIHRoYW5rZnVs bHkgKm5vdCogeW91ciBwZXQKcGxheWdyb3VuZC4KCllvdSBjYW4gY2xhaW0gdGhhdCBJIGFtIGRv aW5nIGEgYmFkIGpvYi4gSW4gd2hpY2ggY2FzZSwgZmVlbCBmcmVlIHRvCnN1Ym1pdCBhIHBhdGNo IHJlbW92aW5nIG1lIGZyb20gdGhlIE1BSU5UQUlORVIgZmlsZSwgYW5kIHdlIGNhbiBoYXZlCnRo YXQgZGlzY3Vzc2lvbi4KCkluIHRoZSBtZWFudGltZSwgSSB3aWxsIGNvbnRpbnVlIHRvIG9wcG9z ZSB0aGVzZSBraW5kIG9mIHBhdGNoZXMgdGhhdApwcmV0ZW5kIHRvICdmaXgnIHRoaW5ncyB3aXRo b3V0IGFkZGluZyBhbnkgdmFsdWUuCgoJTS4KCi0tIApXaXRob3V0IGRldmlhdGlvbiBmcm9tIHRo ZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==