From: Markus Armbruster <armbru@redhat.com>
To: Alistair Francis <Alistair.Francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
Palmer Dabbelt <palmer@dabbelt.com>
Cc: qemu-devel@nongnu.org
Subject: Bad error handling in machine sifive-u
Date: Mon, 06 Dec 2021 13:53:45 +0100 [thread overview]
Message-ID: <87mtldlwrq.fsf@dusky.pond.sub.org> (raw)
Watch this:
$ ../qemu/bld/qemu-system-riscv64 -M sifive_u -S -monitor stdio -display none -drive if=pflash
QEMU 6.1.93 monitor - type 'help' for more information
(qemu) Unexpected error in sifive_u_otp_realize() at ../hw/misc/sifive_u_otp.c:229:
qemu-system-riscv64: OTP drive size < 16K
Aborted (core dumped)
sifive_u_machine_init() calls
qdev_realize(DEVICE(&s->soc), NULL, &error_abort);
My reproducer demonstrates that passing &error_abort is wrong: this
realize can fail.
&error_fatal should do here.
Please check the other uses of &error_abort in this machine for similar
misuse.
next reply other threads:[~2021-12-06 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 12:53 Markus Armbruster [this message]
2021-12-07 12:16 ` Bad error handling in machine sifive-u Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtldlwrq.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.