From: Jani Nikula <jani.nikula@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
"Juha-Pekka Heikkila" <juhapekka.heikkila@gmail.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915/fb: Fold modifier CCS type/tiling attribute to plane caps
Date: Wed, 27 Oct 2021 11:05:08 +0300 [thread overview]
Message-ID: <87mtmuj3kb.fsf@intel.com> (raw)
In-Reply-To: <20211027063342.GA2792152@ideak-desk.fi.intel.com>
On Wed, 27 Oct 2021, Imre Deak <imre.deak@intel.com> wrote:
> On Tue, Oct 26, 2021 at 08:52:12PM +0300, Jani Nikula wrote:
>> AFAICT there are no intel_plane_caps references anywhere after this, and
>> it no longer looks like an enum, so perhaps it just shouldn't be an enum
>> anymore? Just make them macros?
>
> There are other instances of bitfield enums in the kernel, but yes in C
> there's no benefit of enums for this over the simpler macro approach.
> Will change this.
Semantically I think enums are good for enumerating and naming the bit
*positions*, but not so much the shifted bit values. See e.g. enum
drm_dp_quirk, where the values aren't important, but they're used with
BIT() in drm_dp_has_quirk().
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-10-27 8:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 16:15 [Intel-gfx] [PATCH 0/3] drm/i915/fb: Simplify modifier handling more Imre Deak
2021-10-26 16:15 ` [Intel-gfx] [PATCH 1/3] drm/i915/fb: Don't report MC CCS plane capability on GEN<12 Imre Deak
2021-10-26 16:15 ` [Intel-gfx] [PATCH 2/3] drm/i915/fb: Don't store bitmasks in the intel_plane_caps enum Imre Deak
2021-10-26 16:15 ` [Intel-gfx] [PATCH 3/3] drm/i915/fb: Fold modifier CCS type/tiling attribute to plane caps Imre Deak
2021-10-26 17:52 ` Jani Nikula
2021-10-27 6:33 ` Imre Deak
2021-10-27 8:05 ` Jani Nikula [this message]
2021-10-27 12:51 ` [Intel-gfx] [PATCH v2 " Imre Deak
2021-10-26 20:24 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/fb: Simplify modifier handling more Patchwork
2021-10-27 16:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fb: Simplify modifier handling more (rev2) Patchwork
2021-10-27 20:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-29 14:39 ` Imre Deak
2021-10-28 14:21 ` [Intel-gfx] [PATCH 0/3] drm/i915/fb: Simplify modifier handling more Juha-Pekka Heikkila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtmuj3kb.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.