From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 4/5] tests/gem_exec_schedule: Adopt to use allocator
Date: Mon, 16 Aug 2021 21:11:29 -0700 [thread overview]
Message-ID: <87mtpgzp5a.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <87o89wzub2.wl-ashutosh.dixit@intel.com>
On Mon, 16 Aug 2021 19:20:01 -0700, Dixit, Ashutosh wrote:
>
> > + for (i = 0; i < GEM_MAX_ENGINES; i++)
> > + if (sema[i])
> > + igt_spin_free(i915, sema[i]);
>
> Did we create this array etc. to avoid the stall when the spin is freed and
> the offset is reused? Or is there a different reason?
A one line comment about why this was done would be nice prior to merging.
>
> Otherwise this is:
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2021-08-17 4:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 11:56 [igt-dev] [PATCH i-g-t 0/5] Adopt to use allocator Zbigniew Kempczyński
2021-08-16 11:56 ` [igt-dev] [PATCH i-g-t 1/5] tests/gem_exec_capture: Remove unnecessary multiprocess stop() call Zbigniew Kempczyński
2021-08-17 0:25 ` Dixit, Ashutosh
2021-08-16 11:56 ` [igt-dev] [PATCH i-g-t 2/5] tests/gem_exec_big: Move check of pressumed offset out of no-reloc scope Zbigniew Kempczyński
2021-08-17 0:31 ` Dixit, Ashutosh
2021-08-16 11:56 ` [igt-dev] [PATCH i-g-t 3/5] tests/gem_exec_fence: Adopt to use allocator Zbigniew Kempczyński
2021-08-16 11:56 ` [igt-dev] [PATCH i-g-t 4/5] tests/gem_exec_schedule: " Zbigniew Kempczyński
2021-08-17 2:20 ` Dixit, Ashutosh
2021-08-17 4:11 ` Dixit, Ashutosh [this message]
2021-08-17 5:21 ` Zbigniew Kempczyński
2021-08-17 5:18 ` Zbigniew Kempczyński
2021-08-16 11:56 ` [igt-dev] [PATCH i-g-t 5/5] HAX: remove gttfill for tgl ci Zbigniew Kempczyński
2021-08-16 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success for Adopt to use allocator (rev3) Patchwork
2021-08-16 17:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-08-17 6:31 [igt-dev] [PATCH i-g-t 0/5] Adopt to use allocator Zbigniew Kempczyński
2021-08-17 6:31 ` [igt-dev] [PATCH i-g-t 4/5] tests/gem_exec_schedule: " Zbigniew Kempczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtpgzp5a.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.