Re: [Intel-gfx] [PATCH] drm/i915/dp: remove superfluous EXPORT_SYMBOL()

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 16 Aug 2021, Imre Deak <imre.deak@intel.com> wrote:
> On Mon, Aug 16, 2021 at 10:17:37AM +0300, Jani Nikula wrote:
>> The symbol isn't needed outside of i915.ko.
>> 
>> Fixes: b30edfd8d0b4 ("drm/i915: Switch to LTTPR non-transparent mode link training")
>> Fixes: 264613b406eb ("drm/i915: Disable LTTPR support when the DPCD rev < 1.4")
>> Cc: Imre Deak <imre.deak@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Thanks for catching it, not sure why I thought the export is needed :/
> Reviewed-by: Imre Deak <imre.deak@intel.com>

Thanks, pushed.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_dp_link_training.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
>> index 08bceae40aa8..053a3c2f7267 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
>> @@ -206,7 +206,6 @@ int intel_dp_init_lttpr_and_dprx_caps(struct intel_dp *intel_dp)
>>  
>>  	return lttpr_count;
>>  }
>> -EXPORT_SYMBOL(intel_dp_init_lttpr_and_dprx_caps);
>>  
>>  static u8 dp_voltage_max(u8 preemph)
>>  {
>> -- 
>> 2.20.1
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center