From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Matthew Wilcox <willy@infradead.org>,
Nicholas Piggin <npiggin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Yang Shi <shy828301@gmail.com>,
linux-mm@kvack.org, Alexey Kardashevskiy <aik@ozlabs.ru>
Subject: Re: [PATCH] mm/migrate: fix page state accounting type conversion underflow
Date: Wed, 28 Jul 2021 19:45:53 +0530 [thread overview]
Message-ID: <87mtq6ttgm.fsf@linux.ibm.com> (raw)
In-Reply-To: <YQAyJQXdI3E6sq3r@casper.infradead.org>
Matthew Wilcox <willy@infradead.org> writes:
> This patch is insufficient ... mem_cgroup_move_account() has the same bug.
Do we have similar issue mem_cgroup_move_account()?
void __mod_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx,
int val)
{
/* Update node */
__mod_node_page_state(lruvec_pgdat(lruvec), idx, val);
the int val -> long val update happens as expected right?
-aneesh
prev parent reply other threads:[~2021-07-28 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 5:48 [PATCH] mm/migrate: fix page state accounting type conversion underflow Nicholas Piggin
2021-07-22 7:27 ` David Hildenbrand
2021-07-22 19:20 ` Andrew Morton
2021-07-26 1:43 ` Nicholas Piggin
2021-07-27 16:19 ` Matthew Wilcox
2021-07-28 14:15 ` Aneesh Kumar K.V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtq6ttgm.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=npiggin@gmail.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.