Re: [bpf-next:master 15/30] kernel/bpf/devmap.c:1030:40: sparse: sparse: cast removes address space '__rcu' of expression

[Toke Høiland-Jørgensen <toke@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]

"Paul E. McKenney" <paulmck@kernel.org> writes:

> On Sat, Jun 26, 2021 at 12:00:55PM +0200, Toke Høiland-Jørgensen wrote:
>> +Paul - any idea why unrcu_pointer() isn't working here?
>
> Hello, Toke!
>
> My distro version of sparse core-dumped before getting that far along.
>
> I cloned and built the latest version, and got only the following errors
> from kernel/bpf/devmap.c:
>
> ------------------------------------------------------------------------
>
>   CHECK   scripts/mod/empty.c
>   CALL    scripts/checksyscalls.sh
>   CALL    scripts/atomic/check-atomics.sh
>   DESCEND objtool
>   CC      kernel/bpf/devmap.o
>   CHECK   kernel/bpf/devmap.c
> kernel/bpf/devmap.c:561:29: warning: incorrect type in assignment (different address spaces)
> kernel/bpf/devmap.c:561:29:    expected struct bpf_dtab_netdev *dst
> kernel/bpf/devmap.c:561:29:    got struct bpf_dtab_netdev [noderef] __rcu *
> kernel/bpf/devmap.c:657:29: warning: incorrect type in assignment (different address spaces)
> kernel/bpf/devmap.c:657:29:    expected struct bpf_dtab_netdev *dst
> kernel/bpf/devmap.c:657:29:    got struct bpf_dtab_netdev [noderef] __rcu *

Hmm, but those shouldn't be there either. Seems I missed those when
rebasing, will send a follow-up patch...

-Toke