From: "Aurélien Aptel" <aaptel@suse.com>
To: Paulo Alcantara <pc@cjr.nz>,
linux-cifs@vger.kernel.org, smfrench@gmail.com
Cc: Paulo Alcantara <pc@cjr.nz>
Subject: Re: [PATCH 4/4] cifs: do not send close in compound create+close requests
Date: Mon, 08 Mar 2021 16:29:58 +0100 [thread overview]
Message-ID: <87mtvdvf2h.fsf@suse.com> (raw)
In-Reply-To: <20210308150050.19902-4-pc@cjr.nz>
Paulo Alcantara <pc@cjr.nz> writes:
> In case of interrupted syscalls, prevent sending CLOSE commands for
> compound CREATE+CLOSE requests by introducing an
> CIFS_CP_CREATE_CLOSE_OP flag to indicate lower layers that it should
> not send a CLOSE command to the MIDs corresponding the compound
> CREATE+CLOSE request.
Sounds and looks good to me, good catch!
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)
next prev parent reply other threads:[~2021-03-08 15:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 15:00 [PATCH 1/4] cifs: print MIDs in decimal notation Paulo Alcantara
2021-03-08 15:00 ` [PATCH 2/4] cifs: change noisy error message to FYI Paulo Alcantara
2021-03-08 15:12 ` Aurélien Aptel
2021-03-09 0:40 ` ronnie sahlberg
2021-03-08 15:00 ` [PATCH 3/4] cifs: return proper error code in statfs(2) Paulo Alcantara
2021-03-08 15:13 ` Aurélien Aptel
2021-03-08 21:08 ` Steve French
2021-03-08 22:21 ` Paulo Alcantara
2021-03-09 0:40 ` ronnie sahlberg
2021-03-08 15:00 ` [PATCH 4/4] cifs: do not send close in compound create+close requests Paulo Alcantara
2021-03-08 15:29 ` Aurélien Aptel [this message]
2021-03-08 21:06 ` Steve French
2021-03-08 22:22 ` Paulo Alcantara
2021-03-09 0:43 ` ronnie sahlberg
2021-03-08 15:10 ` [PATCH 1/4] cifs: print MIDs in decimal notation Aurélien Aptel
2021-03-09 0:39 ` ronnie sahlberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtvdvf2h.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@cjr.nz \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.