From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: remove useless use of inline
Date: Thu, 14 Jan 2021 10:12:01 +0200 [thread overview]
Message-ID: <87mtxcq6ni.fsf@intel.com> (raw)
In-Reply-To: <X/8GcN3sCtcPd9JG@intel.com>
On Wed, 13 Jan 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Jan 13, 2021 at 04:37:26PM +0200, Jani Nikula wrote:
>> skl_scaler_get_filter_select() isn't static and can't be inline.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, pushed.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index 0189d379a55e..cf9860ff9a89 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -5810,7 +5810,7 @@ static void cnl_program_nearest_filter_coefs(struct drm_i915_private *dev_priv,
>> intel_de_write_fw(dev_priv, CNL_PS_COEF_INDEX_SET(pipe, id, set), 0);
>> }
>>
>> -inline u32 skl_scaler_get_filter_select(enum drm_scaling_filter filter, int set)
>> +u32 skl_scaler_get_filter_select(enum drm_scaling_filter filter, int set)
>> {
>> if (filter == DRM_SCALING_FILTER_NEAREST_NEIGHBOR) {
>> return (PS_FILTER_PROGRAMMED |
>> --
>> 2.20.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-14 8:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 14:37 [Intel-gfx] [PATCH] drm/i915/display: remove useless use of inline Jani Nikula
2021-01-13 14:40 ` Ville Syrjälä
2021-01-14 8:12 ` Jani Nikula [this message]
2021-01-13 18:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-01-13 23:06 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtxcq6ni.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.