From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 2/7] rocker: Revamp fp_port_get_info
Date: Wed, 13 Jan 2021 13:57:45 +0100 [thread overview]
Message-ID: <87mtxd0zau.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20201223221102.390740-3-eblake@redhat.com> (Eric Blake's message of "Wed, 23 Dec 2020 16:10:57 -0600")
Eric Blake <eblake@redhat.com> writes:
> Instead of modifying the value member of a list element passed as a
> parameter, and open-coding the manipulation of that list, it's nicer
> to just return a freshly allocated value to be prepended to a list
> using QAPI_LIST_PREPEND.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Alread in master as commit fe4d7e338f.
next prev parent reply other threads:[~2021-01-13 12:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 22:10 [PATCH v3 0/7] Common macros for QAPI list growth Eric Blake
2020-12-23 22:10 ` [PATCH v3 1/7] net: Clarify early exit condition Eric Blake
2021-01-13 12:57 ` Markus Armbruster
2020-12-23 22:10 ` [PATCH v3 2/7] rocker: Revamp fp_port_get_info Eric Blake
2021-01-13 12:57 ` Markus Armbruster [this message]
2020-12-23 22:10 ` [PATCH v3 3/7] migration: Refactor migrate_cap_add Eric Blake
2021-01-13 12:58 ` Markus Armbruster
2020-12-23 22:10 ` [PATCH v3 4/7] qapi: Use QAPI_LIST_PREPEND() where possible Eric Blake
2020-12-23 22:10 ` Eric Blake
2021-01-13 13:00 ` Markus Armbruster
2020-12-23 22:11 ` [PATCH v3 5/7] qapi: Introduce QAPI_LIST_APPEND Eric Blake
2020-12-24 6:14 ` Vladimir Sementsov-Ogievskiy
2021-01-13 13:04 ` Markus Armbruster
2021-01-13 14:08 ` Eric Blake
2020-12-23 22:11 ` [PATCH v3 6/7] qapi: Use QAPI_LIST_APPEND in trivial cases Eric Blake
2020-12-23 22:11 ` Eric Blake
2020-12-24 9:56 ` Vladimir Sementsov-Ogievskiy
2020-12-24 9:56 ` Vladimir Sementsov-Ogievskiy
2021-01-13 14:10 ` Eric Blake
2021-01-13 14:10 ` Eric Blake
2021-01-13 13:16 ` Markus Armbruster
2021-01-13 13:16 ` Markus Armbruster
2021-01-13 14:11 ` Eric Blake
2021-01-13 14:11 ` Eric Blake
2020-12-23 22:11 ` [PATCH v3 7/7] qapi: More complex uses of QAPI_LIST_APPEND Eric Blake
2020-12-24 11:35 ` Vladimir Sementsov-Ogievskiy
2021-01-13 13:31 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtxd0zau.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.