From: Petr Machata <me@pmachata.org>
To: David Ahern <dsahern@gmail.com>
Cc: Petr Machata <me@pmachata.org>,
netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [PATCH iproute2-next 7/9] dcb: Support -n to suppress translation to nice names
Date: Fri, 01 Jan 2021 22:34:35 +0100 [thread overview]
Message-ID: <87mtxswdck.fsf@nvidia.com> (raw)
In-Reply-To: <8ae5ec88-937e-2e05-b0f2-a99c72e74a06@gmail.com>
David Ahern <dsahern@gmail.com> writes:
> On 12/23/20 11:25 AM, Petr Machata wrote:
>> diff --git a/dcb/dcb.c b/dcb/dcb.c
>> index a59b63ac9159..e6cda7337924 100644
>> --- a/dcb/dcb.c
>> +++ b/dcb/dcb.c
>> @@ -467,7 +467,8 @@ static void dcb_help(void)
>> " dcb [ -f | --force ] { -b | --batch } filename [ -N | --Netns ] netnsname\n"
>> "where OBJECT := { buffer | ets | maxrate | pfc }\n"
>> " OPTIONS := [ -V | --Version | -i | --iec | -j | --json\n"
>> - " | -p | --pretty | -s | --statistics | -v | --verbose]\n");
>> + " | -n | --no-nice-names | -p | --pretty\n"
>
>
> iproute2 commands really should have a consistent user interface.
> Unfortunately -N and -n are inconsistent with the newer commands like
> devlink. dcb has not been released yet so time to fix this.
>
> devlink is the only one using the horribly named 'no-nice-names', and we
> should avoid propagating that to dcb. At a minimum it should be
> 'numeric' which is consistent with the others.
>
> My preference is also to have dcb follow ip and tc (vs ss) with '-n' to
> mean -netns and -N' to mean numeric.
Agreed on all counts.
next prev parent reply other threads:[~2021-01-01 21:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 18:25 [PATCH iproute2-next 0/9] dcb: Support APP, DCBX objects Petr Machata
2020-12-23 18:25 ` [PATCH iproute2-next 1/9] dcb: Set values with RTM_SETDCB type Petr Machata
2020-12-23 18:25 ` [PATCH iproute2-next 2/9] dcb: Plug a leaking DCB socket buffer Petr Machata
2020-12-23 18:25 ` [PATCH iproute2-next 3/9] lib: rt_names: Add rtnl_dsfield_get_name() Petr Machata
2020-12-23 18:25 ` [PATCH iproute2-next 4/9] lib: Generalize parse_mapping() Petr Machata
2020-12-23 18:25 ` [PATCH iproute2-next 5/9] dcb: Generalize dcb_set_attribute() Petr Machata
2020-12-23 18:25 ` [PATCH iproute2-next 6/9] dcb: Generalize dcb_get_attribute() Petr Machata
2020-12-23 18:25 ` [PATCH iproute2-next 7/9] dcb: Support -n to suppress translation to nice names Petr Machata
2020-12-31 17:11 ` David Ahern
2021-01-01 21:34 ` Petr Machata [this message]
2020-12-23 18:25 ` [PATCH iproute2-next 8/9] dcb: Add a subtool for the DCB APP object Petr Machata
2020-12-23 18:25 ` [PATCH iproute2-next 9/9] dcb: Add a subtool for the DCBX object Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtxswdck.fsf@nvidia.com \
--to=me@pmachata.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.