From: Thomas Gleixner <tglx@linutronix.de>
To: Yunfeng Ye <yeyunfeng@huawei.com>
Cc: linux-kernel@vger.kernel.org, Shiyuan Hu <hushiyuan@huawei.com>,
Hewenliang <hewenliang4@huawei.com>,
Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH] genirq/proc: Show percpu irq affinity
Date: Sat, 22 Aug 2020 13:35:10 +0200 [thread overview]
Message-ID: <87mu2moqvl.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <aa537126-4646-08e2-6bea-833f71b20ade@huawei.com>
On Sat, Aug 22 2020 at 17:33, Yunfeng Ye wrote:
> On 2020/8/13 16:27, Thomas Gleixner wrote:
> For example, the cmdline "irqaffinity=0,1,126,127" on the 128 cores system：
>
> [root@localhost ~]# cat /proc/irq/4/smp_affinity_list
> 0-1,126-127
>
> The irq 4 is "arch_timer" interrupt, which is a percpu interrupt.
>
> So is it necessary to show the percpu irq affinity correct?
Yes, it makes sense to do so, but you used the wrong check. The correct
one is:
irq_settings_is_per_cpu_devid()
which will not wreckage the output for other per cpu marked interrupts
which never set the percpu_affinity pointer with the obvious
consequences... The pointer would need a NULL check in any case, but it
might be more straight forward to update affinity when percpu_affinity
is initialized. Haven't looked in detail though.
Thanks,
tglx
next prev parent reply other threads:[~2020-08-22 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 2:29 [PATCH] genirq/proc: Show percpu irq affinity Yunfeng Ye
2020-08-13 8:27 ` Thomas Gleixner
2020-08-22 9:33 ` Yunfeng Ye
2020-08-22 11:35 ` Thomas Gleixner [this message]
2020-08-25 9:39 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu2moqvl.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=hewenliang4@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.