All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Laxminarayan Bharadiya\,
	Pankaj" <pankaj.laxminarayan.bharadiya@intel.com>,
	Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: RE: [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro
Date: Thu, 27 Feb 2020 10:29:50 +0200	[thread overview]
Message-ID: <87mu94qvpd.fsf@intel.com> (raw)
In-Reply-To: <E92BA18FDE0A5B43B7B3DA7FCA03128605776BFE@BGSMSX107.gar.corp.intel.com>

On Thu, 27 Feb 2020, "Laxminarayan Bharadiya, Pankaj"	<pankaj.laxminarayan.bharadiya@intel.com> wrote:
> Hi Chris,
>
>> -----Original Message-----
>> From: Chris Wilson <chris@chris-wilson.co.uk>
>> Sent: 25 February 2020 19:32
>> To: David Airlie <airlied@linux.ie>; Joonas Lahtinen
>> <joonas.lahtinen@linux.intel.com>; Laxminarayan Bharadiya, Pankaj
>> <pankaj.laxminarayan.bharadiya@intel.com>; Vivi, Rodrigo
>> <rodrigo.vivi@intel.com>; daniel@ffwll.ch; dri-devel@lists.freedesktop.org;
>> intel-gfx@lists.freedesktop.org; jani.nikula@linux.intel.com
>> Cc: Laxminarayan Bharadiya, Pankaj
>> <pankaj.laxminarayan.bharadiya@intel.com>
>> Subject: Re: [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based
>> MISSING_CASE macro
>> 
>> Quoting Pankaj Bharadiya (2020-02-25 13:47:00)
>> > Now that we have struct drm_device based drm_WARN, introduce struct
>> > drm_i915_private based i915_MISSING_CASE macro which uses
>> drm_WARN so
>> > that device specific information will also get printed in backtrace.
>> >
>> > i915_MISSING_CASE macro should be preferred over MISSING_CASE,
>> > wherever possible.
>> 
>> Whatever for? MISSING_CASE() itself should be a complete picture for the
>> forgotten code.
>
> Are you saying, no need to have a new device specific macro?
>
> We want convert all the calls of WARN* with device specific drm_WARN* 
> in i915, hence I introduced new i915_MISSING_CASE macro.
>
> Jani, Will you please share your opinion on this?

In general, many or most WARNs are device specific, and the device
information is useful. However MISSING_CASE is about the *code*. That
was the intent anyway. Perhaps there are cases where the device
information might be useful, but for most cases probably not.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Laxminarayan Bharadiya\,
	Pankaj" <pankaj.laxminarayan.bharadiya@intel.com>,
	Chris Wilson <chris@chris-wilson.co.uk>
Cc: David Airlie <airlied@linux.ie>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro
Date: Thu, 27 Feb 2020 10:29:50 +0200	[thread overview]
Message-ID: <87mu94qvpd.fsf@intel.com> (raw)
In-Reply-To: <E92BA18FDE0A5B43B7B3DA7FCA03128605776BFE@BGSMSX107.gar.corp.intel.com>

On Thu, 27 Feb 2020, "Laxminarayan Bharadiya, Pankaj"	<pankaj.laxminarayan.bharadiya@intel.com> wrote:
> Hi Chris,
>
>> -----Original Message-----
>> From: Chris Wilson <chris@chris-wilson.co.uk>
>> Sent: 25 February 2020 19:32
>> To: David Airlie <airlied@linux.ie>; Joonas Lahtinen
>> <joonas.lahtinen@linux.intel.com>; Laxminarayan Bharadiya, Pankaj
>> <pankaj.laxminarayan.bharadiya@intel.com>; Vivi, Rodrigo
>> <rodrigo.vivi@intel.com>; daniel@ffwll.ch; dri-devel@lists.freedesktop.org;
>> intel-gfx@lists.freedesktop.org; jani.nikula@linux.intel.com
>> Cc: Laxminarayan Bharadiya, Pankaj
>> <pankaj.laxminarayan.bharadiya@intel.com>
>> Subject: Re: [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based
>> MISSING_CASE macro
>> 
>> Quoting Pankaj Bharadiya (2020-02-25 13:47:00)
>> > Now that we have struct drm_device based drm_WARN, introduce struct
>> > drm_i915_private based i915_MISSING_CASE macro which uses
>> drm_WARN so
>> > that device specific information will also get printed in backtrace.
>> >
>> > i915_MISSING_CASE macro should be preferred over MISSING_CASE,
>> > wherever possible.
>> 
>> Whatever for? MISSING_CASE() itself should be a complete picture for the
>> forgotten code.
>
> Are you saying, no need to have a new device specific macro?
>
> We want convert all the calls of WARN* with device specific drm_WARN* 
> in i915, hence I introduced new i915_MISSING_CASE macro.
>
> Jani, Will you please share your opinion on this?

In general, many or most WARNs are device specific, and the device
information is useful. However MISSING_CASE is about the *code*. That
was the intent anyway. Perhaps there are cases where the device
information might be useful, but for most cases probably not.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-02-27  8:29 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 13:46 [Intel-gfx][PATCH 00/10] drm/i915: Introduce i915 based i915_MISSING_CASE macro and us it in i915 Pankaj Bharadiya
2020-02-25 13:46 ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 14:01   ` [Intel-gfx][PATCH " Chris Wilson
2020-02-25 14:01     ` [Intel-gfx] [PATCH " Chris Wilson
2020-02-27  6:33     ` [Intel-gfx][PATCH " Laxminarayan Bharadiya, Pankaj
2020-02-27  6:33       ` [Intel-gfx] [PATCH " Laxminarayan Bharadiya, Pankaj
2020-02-27  8:29       ` Jani Nikula [this message]
2020-02-27  8:29         ` Jani Nikula
2020-02-28  5:02         ` [Intel-gfx][PATCH " Laxminarayan Bharadiya, Pankaj
2020-02-28  5:02           ` [Intel-gfx] [PATCH " Laxminarayan Bharadiya, Pankaj
2020-02-25 13:47 ` [Intel-gfx][PATCH 02/10] drm/i915/display/cdclk: Make MISSING_CASE backtrace i915 specific Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 03/10] drm/i915/display/ddi: " Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 04/10] drm/i915/display/display: " Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 05/10] drm/i915/dp: " Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 06/10] drm/i915/display/hdmi: " Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 07/10] drm/i915/display: " Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 08/10] drm/i915/gem: " Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 09/10] drm/i915/gt: " Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-25 13:47 ` [Intel-gfx][PATCH 10/10] drm/i915: " Pankaj Bharadiya
2020-02-25 13:47   ` [Intel-gfx] [PATCH " Pankaj Bharadiya
2020-02-26 16:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce i915 based i915_MISSING_CASE macro and us it in i915 Patchwork
2020-02-26 17:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-27  6:37 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu94qvpd.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=pankaj.laxminarayan.bharadiya@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.