From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B2EC2BA83 for ; Wed, 12 Feb 2020 10:46:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD8302082F for ; Wed, 12 Feb 2020 10:46:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gDNJCQQk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD8302082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1pXR-00074e-SY for qemu-devel@archiver.kernel.org; Wed, 12 Feb 2020 05:46:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37063) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1pWn-0006SA-0F for qemu-devel@nongnu.org; Wed, 12 Feb 2020 05:45:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1pWl-0003hP-Md for qemu-devel@nongnu.org; Wed, 12 Feb 2020 05:45:56 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:36562) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1pWl-0003fx-FP for qemu-devel@nongnu.org; Wed, 12 Feb 2020 05:45:55 -0500 Received: by mail-wm1-x32f.google.com with SMTP id p17so1659253wma.1 for ; Wed, 12 Feb 2020 02:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=NG5Q74p4U0R1gem/m1+/RnE1RYMvid2sFG732VYjE74=; b=gDNJCQQkWrHnjJ8LZww14g9RSh8A9t7+QASgv2V8YixHcBb43Ro8WlJnS4t58SNkXD IX2W89iChhguo5kLxuLaeQNXYOriRAAWTgxH2WBk5dEM66tKL90TYCQhDkPLL0nIK+uV w00/eeIIpIim28DHpNhBnmiL5aYiB/NRC9mvngdBXjZUNC0IxmnSM68Pvosc+tLyty55 nomEGboVtdQiCH5EexrOb7OT7yDZTMyVBGQitd15mv6kQxR449wRp8fI7EU+rLRawhjD sBrnkm95ttOF9Nd7MZCCkBw2RdjuWTpheRB+nSf8HbKqku4Gme8V08lYMjRDPTK0K/iq iKYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=NG5Q74p4U0R1gem/m1+/RnE1RYMvid2sFG732VYjE74=; b=JVeC4F1Y1r6CKhYCYaRa4XjzZZj2Db9kkgNDYdb701wrnN6hAgxm6DI68tgDdZ3Bk7 Sw585wu0fuQcPqHyzf4BlvDOWPosz3YbpCLmUs5qItxyAgWY3pkDfmHa+yfamFlI+DhH m7YOeZnfeTiIotrbrH+MOTDsudBPPPqWpZLlhLyzXXlGVt1d9mjWwwQLyxgVDzZCth21 fqpC37qp4n/Fy6nnKZ0OE/w79AtV721IqnURQjcK2KQdSkiGdgT5pOUGN1qBrfWxUETj AYpwQVOH7qi1pA2ZWOJjukoCpXUBL4ITaqlrWvsZEaGKy/CWV4zFKl1Eabq4BtzsvVYX Bs2Q== X-Gm-Message-State: APjAAAUbukiVAAnBlGBTC2nY9SSqD3lxQYjbwfBei3xSQxgnv5laqRKb WBn1GHfIUKFiw4kOIDHOuDO++g== X-Google-Smtp-Source: APXvYqy0yLwkp+a3KZ35JYrn1qwdmA+m85JxSkAkw1X06yKnhB1Ee2ObcfKdQ6jo2Fo/T2cBrowYfA== X-Received: by 2002:a1c:ddd6:: with SMTP id u205mr12584857wmg.151.1581504353320; Wed, 12 Feb 2020 02:45:53 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id g17sm156731wru.13.2020.02.12.02.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 02:45:51 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E0FCB1FF87; Wed, 12 Feb 2020 10:45:50 +0000 (GMT) References: <20200130213814.334195-1-stefanha@redhat.com> <20200130213814.334195-6-stefanha@redhat.com> <906a4b84-8f4f-fe12-3357-02d02d5dac7d@linaro.org> User-agent: mu4e 1.3.8; emacs 26.1 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Subject: Re: [PULL 5/5] qemu_set_log_filename: filename argument may be NULL In-reply-to: <906a4b84-8f4f-fe12-3357-02d02d5dac7d@linaro.org> Date: Wed, 12 Feb 2020 10:45:50 +0000 Message-ID: <87mu9oxew1.fsf@zen.linaroharston> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32f X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org, Salvador Fandino , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Richard Henderson writes: > On 1/30/20 1:38 PM, Stefan Hajnoczi wrote: >> From: Salvador Fandino >>=20 >> NULL is a valid log filename used to indicate we want to use stderr >> but qemu_set_log_filename (which is called by bsd-user/main.c) was not >> handling it correctly. >>=20 >> That also made redundant a couple of NULL checks in calling code which >> have been removed. >>=20 >> Signed-off-by: Salvador Fandino >> Message-Id: <20200123193626.19956-1-salvador@qindel.com> >> Signed-off-by: Stefan Hajnoczi >> --- >> trace/control.c | 4 +--- >> util/log.c | 28 ++++++++++++++++------------ >> vl.c | 5 +---- >> 3 files changed, 18 insertions(+), 19 deletions(-) > > This patch has broken -D for *-linux-user. > After e144a605a, all logging goes to stderr. I posted: Subject: [PATCH] tracing: only allow -trace to override -D if set Date: Tue, 11 Feb 2020 11:10:54 +0000 Message-Id: <20200211111054.27538-1-alex.bennee@linaro.org> as a fix which partially reverted this. > >> + if (filename) { >> + char *pidstr =3D strstr(filename, "%"); >> + if (pidstr) { > > Also, the indentation is off. > > > r~ --=20 Alex Benn=C3=A9e