From: Baruch Siach <baruch@tkos.co.il>
To: u-boot@lists.denx.de
Subject: [PATCH 07/10] arm: mvebu: clearfog: add SPI offsets
Date: Sun, 12 Jan 2020 12:42:48 +0200 [thread overview]
Message-ID: <87muatymzb.fsf@tarshish> (raw)
In-Reply-To: <20200111193639.19022-7-mrjoel@lixil.net>
Hi Joel,
On Sat, Jan 11 2020, Joel Johnson wrote:
> Add reasonable default SPI offsets and ENV size when configured to
> boot from SPI flash.
>
> Signed-off-by: Joel Johnson <mrjoel@lixil.net>
> ---
>
> board/solidrun/clearfog/Kconfig | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/board/solidrun/clearfog/Kconfig b/board/solidrun/clearfog/Kconfig
> index fd880ee591..ce7fcf653f 100644
> --- a/board/solidrun/clearfog/Kconfig
> +++ b/board/solidrun/clearfog/Kconfig
> @@ -37,4 +37,16 @@ config CLEARFOG_2GB_SOM
> Enable support for the 2GB RAM SOM variant. If this option is not
> enabled then the more common 1GB version will be used.
>
> +config ENV_SECT_SIZE
> + hex "Environment Sector-Size"
> + # Use SPI flash erase block size of 4 KiB
> + default 0x1000 if MVEBU_SPL_BOOT_DEVICE_SPI
> + # Use optimistic 64 KiB erase block, will vary between actual media
> + default 0x10000 if MVEBU_SPL_BOOT_DEVICE_MMC
Duplication of config symbols in platform specific Kconfig goes against
common practice. Platform specific values should go in
defconfig. Support for Clearfog SPI boot should be in a dedicated
defconfig, I think.
Same comment on patches #9 and #10.
> +config SYS_SPI_U_BOOT_OFFS
> + hex "address of u-boot payload in SPI flash"
> + default 0x20000
> + depends on MVEBU_SPL_BOOT_DEVICE_SPI
It might be better to add u-boot,spl-payload-offset property to the
U-Boot specific -u-boot.dtsi file instead.
> +
> endmenu
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2020-01-12 10:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 19:36 [PATCH 01/10] arm: mvebu: fix SerDes table alignment Joel Johnson
2020-01-11 19:36 ` [PATCH 02/10] arm: mvebu: solidrun: remove hardcoded DTS MAC address Joel Johnson
2020-01-13 8:21 ` Stefan Roese
2020-01-11 19:36 ` [PATCH 03/10] arm: mvebu: clearfog: initial ClearFog Base variant Joel Johnson
2020-01-12 10:14 ` Baruch Siach
2020-01-12 15:16 ` Joel Johnson
2020-01-13 8:19 ` Stefan Roese
2020-01-11 19:36 ` [PATCH 04/10] arm: mvebu: clearfog: Add SATA mode flags Joel Johnson
2020-01-11 19:36 ` [PATCH 05/10] arm: mvebu: clearfog: Add option for 2.5 Gbps SFP Joel Johnson
2020-01-12 10:21 ` Baruch Siach
2020-01-12 15:07 ` Joel Johnson
2020-01-11 19:36 ` [PATCH 06/10] arm: mvebu: clearfog: Add config for 2GB SOM Joel Johnson
2020-01-12 10:33 ` Baruch Siach
2020-01-12 15:48 ` Joel Johnson
2020-01-12 16:44 ` Baruch Siach
2020-01-11 19:36 ` [PATCH 07/10] arm: mvebu: clearfog: add SPI offsets Joel Johnson
2020-01-12 10:42 ` Baruch Siach [this message]
2020-01-12 15:30 ` Joel Johnson
2020-01-12 16:28 ` Baruch Siach
2020-01-11 19:36 ` [PATCH 08/10] arm: mvebu: enable working default boot support Joel Johnson
2020-01-11 21:07 ` Joel Johnson
2020-01-13 8:26 ` Stefan Roese
2020-01-11 19:36 ` [PATCH 09/10] arm: mvebu: clearfog: move ENV params to Kconfig Joel Johnson
2020-01-13 8:29 ` Stefan Roese
2020-01-11 19:36 ` [PATCH 10/10] arm: mvebu: clearfog: don't assume MMC booting Joel Johnson
2020-01-12 10:49 ` Baruch Siach
2020-01-12 15:40 ` Joel Johnson
2020-01-12 16:34 ` Baruch Siach
2020-01-13 6:48 ` Stefan Roese
2020-01-13 11:40 ` Baruch Siach
2020-01-13 11:42 ` Stefan Roese
2020-01-14 12:55 ` Baruch Siach
2020-01-14 13:01 ` Stefan Roese
2020-01-14 14:53 ` Baruch Siach
2020-01-14 15:06 ` Stefan Roese
2020-01-15 7:04 ` Baruch Siach
2020-01-13 8:18 ` [PATCH 01/10] arm: mvebu: fix SerDes table alignment Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muatymzb.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.