From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6C1EC32771 for ; Thu, 9 Jan 2020 09:05:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A312220678 for ; Thu, 9 Jan 2020 09:05:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A312220678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F24689C89; Thu, 9 Jan 2020 09:05:14 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A2EB89C89 for ; Thu, 9 Jan 2020 09:05:12 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 01:05:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,413,1571727600"; d="scan'208";a="216236911" Received: from gaia.fi.intel.com ([10.237.72.192]) by orsmga008.jf.intel.com with ESMTP; 09 Jan 2020 01:05:02 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id 1E79A5C1DE9; Thu, 9 Jan 2020 11:04:31 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org In-Reply-To: <20200109085839.873553-11-chris@chris-wilson.co.uk> References: <20200109085839.873553-1-chris@chris-wilson.co.uk> <20200109085839.873553-11-chris@chris-wilson.co.uk> Date: Thu, 09 Jan 2020 11:04:31 +0200 Message-ID: <87muaxf1b4.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH 11/14] drm/i915: Drop the shadow ring state from the error capture X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Chris Wilson writes: > The shadow ring regs (ring->head, ring->tail) are meaningless in the > post-mortem dump as they do not related to anything on HW. Remove them > from the coredump. We have been dumping these just to check that our bookkeepping matches? -Mika > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_gpu_error.c | 5 ----- > drivers/gpu/drm/i915/i915_gpu_error.h | 4 ---- > 2 files changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c > index b45c128d0a17..a35aad439281 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -553,8 +553,6 @@ static void error_print_engine(struct drm_i915_error_state_buf *m, > ee->vm_info.pp_dir_base); > } > } > - err_printf(m, " ring->head: 0x%08x\n", ee->cpu_ring_head); > - err_printf(m, " ring->tail: 0x%08x\n", ee->cpu_ring_tail); > err_printf(m, " engine reset count: %u\n", ee->reset_count); > > for (n = 0; n < ee->num_ports; n++) { > @@ -1428,9 +1426,6 @@ intel_engine_coredump_add_request(struct intel_engine_coredump *ee, > if (HAS_BROKEN_CS_TLB(rq->i915)) > vma = capture_vma(vma, ee->engine->gt->scratch, "WA batch", gfp); > > - ee->cpu_ring_head = rq->ring->head; > - ee->cpu_ring_tail = rq->ring->tail; > - > ee->rq_head = rq->head; > ee->rq_post = rq->postfix; > ee->rq_tail = rq->tail; > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h > index 0df9d8c32056..8f4579d64d8c 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.h > +++ b/drivers/gpu/drm/i915/i915_gpu_error.h > @@ -66,10 +66,6 @@ struct intel_engine_coredump { > /* position of active request inside the ring */ > u32 rq_head, rq_post, rq_tail; > > - /* our own tracking of ring head and tail */ > - u32 cpu_ring_head; > - u32 cpu_ring_tail; > - > /* Register state */ > u32 ccid; > u32 start; > -- > 2.25.0.rc1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx