From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Date: Wed, 04 Dec 2019 06:31:06 +0000 Subject: Re: [Intel-gfx] [PATCH v3 04/12] video: fbdev: uvesafb: modify the static fb_ops directly Message-Id: <87muc8haad.fsf@intel.com> List-Id: References: <20191203170351.GH624164@phenom.ffwll.local> In-Reply-To: <20191203170351.GH624164@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org On Tue, 03 Dec 2019, Daniel Vetter wrote: > On Tue, Dec 03, 2019 at 06:38:46PM +0200, Jani Nikula wrote: >> Avoid modifying the fb_ops via info->fbops to let us make the pointer >> const in the future. >> >> Cc: linux-fbdev@vger.kernel.org >> Signed-off-by: Jani Nikula >> --- >> drivers/video/fbdev/uvesafb.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c >> index 439565cae7ab..53d08d1b56f5 100644 >> --- a/drivers/video/fbdev/uvesafb.c >> +++ b/drivers/video/fbdev/uvesafb.c >> @@ -1440,7 +1440,7 @@ static void uvesafb_init_info(struct fb_info *info, struct vbe_mode_ib *mode) >> >> /* Disable blanking if the user requested so. */ >> if (!blank) >> - info->fbops->fb_blank = NULL; >> + uvesafb_ops.fb_blank = NULL; >> >> /* >> * Find out how much IO memory is required for the mode with >> @@ -1510,7 +1510,7 @@ static void uvesafb_init_info(struct fb_info *info, struct vbe_mode_ib *mode) >> (par->ypan ? FBINFO_HWACCEL_YPAN : 0); >> >> if (!par->ypan) >> - info->fbops->fb_pan_display = NULL; >> + uvesafb_ops.fb_pan_display = NULL; >> } > > I read code. > > I cried. > > Reviewed-by: Daniel Vetter > > Also, with more reading and more bad dreams I'll get about this, I'm > revising my take on patches 1&2 in this series. On those also > > Reviewed-by: Daniel Vetter > > as-is. Thanks. I feel you. And remember, all I ever wanted to do was -static struct fb_ops intelfb_ops = { +static const struct fb_ops intelfb_ops = { in drivers/gpu/drm/i915/display/intel_fbdev.c. BR, Jani. > > Cheers, Daniel >> >> static void uvesafb_init_mtrr(struct fb_info *info) >> -- >> 2.20.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B95EC2BC73 for ; Wed, 4 Dec 2019 06:51:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F16F24663 for ; Wed, 4 Dec 2019 06:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F16F24663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E92546E077; Wed, 4 Dec 2019 06:31:04 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBE666E077; Wed, 4 Dec 2019 06:31:02 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 22:31:02 -0800 X-IronPort-AV: E=Sophos;i="5.69,276,1571727600"; d="scan'208";a="205276496" Received: from huberth-mobl4.ger.corp.intel.com (HELO localhost) ([10.252.34.172]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 22:30:59 -0800 From: Jani Nikula To: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH v3 04/12] video: fbdev: uvesafb: modify the static fb_ops directly In-Reply-To: <20191203170351.GH624164@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191203170351.GH624164@phenom.ffwll.local> Date: Wed, 04 Dec 2019 08:31:06 +0200 Message-ID: <87muc8haad.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCAwMyBEZWMgMjAxOSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBUdWUsIERlYyAwMywgMjAxOSBhdCAwNjozODo0NlBNICswMjAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gQXZvaWQgbW9kaWZ5aW5nIHRoZSBmYl9vcHMgdmlhIGluZm8tPmZib3BzIHRv IGxldCB1cyBtYWtlIHRoZSBwb2ludGVyCj4+IGNvbnN0IGluIHRoZSBmdXR1cmUuCj4+IAo+PiBD YzogbGludXgtZmJkZXZAdmdlci5rZXJuZWwub3JnCj4+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlr dWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy92aWRlby9mYmRl di91dmVzYWZiLmMgfCA0ICsrLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9mYmRldi91 dmVzYWZiLmMgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3V2ZXNhZmIuYwo+PiBpbmRleCA0Mzk1NjVj YWU3YWIuLjUzZDA4ZDFiNTZmNSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy92aWRlby9mYmRldi91 dmVzYWZiLmMKPj4gKysrIGIvZHJpdmVycy92aWRlby9mYmRldi91dmVzYWZiLmMKPj4gQEAgLTE0 NDAsNyArMTQ0MCw3IEBAIHN0YXRpYyB2b2lkIHV2ZXNhZmJfaW5pdF9pbmZvKHN0cnVjdCBmYl9p bmZvICppbmZvLCBzdHJ1Y3QgdmJlX21vZGVfaWIgKm1vZGUpCj4+ICAKPj4gIAkvKiBEaXNhYmxl IGJsYW5raW5nIGlmIHRoZSB1c2VyIHJlcXVlc3RlZCBzby4gKi8KPj4gIAlpZiAoIWJsYW5rKQo+ PiAtCQlpbmZvLT5mYm9wcy0+ZmJfYmxhbmsgPSBOVUxMOwo+PiArCQl1dmVzYWZiX29wcy5mYl9i bGFuayA9IE5VTEw7Cj4+ICAKPj4gIAkvKgo+PiAgCSAqIEZpbmQgb3V0IGhvdyBtdWNoIElPIG1l bW9yeSBpcyByZXF1aXJlZCBmb3IgdGhlIG1vZGUgd2l0aAo+PiBAQCAtMTUxMCw3ICsxNTEwLDcg QEAgc3RhdGljIHZvaWQgdXZlc2FmYl9pbml0X2luZm8oc3RydWN0IGZiX2luZm8gKmluZm8sIHN0 cnVjdCB2YmVfbW9kZV9pYiAqbW9kZSkKPj4gIAkJCShwYXItPnlwYW4gPyBGQklORk9fSFdBQ0NF TF9ZUEFOIDogMCk7Cj4+ICAKPj4gIAlpZiAoIXBhci0+eXBhbikKPj4gLQkJaW5mby0+ZmJvcHMt PmZiX3Bhbl9kaXNwbGF5ID0gTlVMTDsKPj4gKwkJdXZlc2FmYl9vcHMuZmJfcGFuX2Rpc3BsYXkg PSBOVUxMOwo+PiAgfQo+Cj4gSSByZWFkIGNvZGUuCj4KPiBJIGNyaWVkLgo+Cj4gUmV2aWV3ZWQt Ynk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4KPiBBbHNvLCB3aXRo IG1vcmUgcmVhZGluZyBhbmQgbW9yZSBiYWQgZHJlYW1zIEknbGwgZ2V0IGFib3V0IHRoaXMsIEkn bQo+IHJldmlzaW5nIG15IHRha2Ugb24gcGF0Y2hlcyAxJjIgaW4gdGhpcyBzZXJpZXMuIE9uIHRo b3NlIGFsc28KPgo+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZm d2xsLmNoPgo+Cj4gYXMtaXMuCgpUaGFua3MuIEkgZmVlbCB5b3UuCgpBbmQgcmVtZW1iZXIsIGFs bCBJIGV2ZXIgd2FudGVkIHRvIGRvIHdhcwoKLXN0YXRpYyBzdHJ1Y3QgZmJfb3BzIGludGVsZmJf b3BzID0geworc3RhdGljIGNvbnN0IHN0cnVjdCBmYl9vcHMgaW50ZWxmYl9vcHMgPSB7CgppbiBk cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2ZiZGV2LmMuCgoKQlIsCkphbmkuCgoK Pgo+IENoZWVycywgRGFuaWVsCj4+ICAKPj4gIHN0YXRpYyB2b2lkIHV2ZXNhZmJfaW5pdF9tdHJy KHN0cnVjdCBmYl9pbmZvICppbmZvKQo+PiAtLSAKPj4gMi4yMC4xCj4+IAo+PiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5p a3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EBAAC3F68F for ; Wed, 4 Dec 2019 06:51:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA96D24662 for ; Wed, 4 Dec 2019 06:31:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA96D24662 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E9B186E889; Wed, 4 Dec 2019 06:31:04 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBE666E077; Wed, 4 Dec 2019 06:31:02 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 22:31:02 -0800 X-IronPort-AV: E=Sophos;i="5.69,276,1571727600"; d="scan'208";a="205276496" Received: from huberth-mobl4.ger.corp.intel.com (HELO localhost) ([10.252.34.172]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 22:30:59 -0800 From: Jani Nikula To: Daniel Vetter In-Reply-To: <20191203170351.GH624164@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191203170351.GH624164@phenom.ffwll.local> Date: Wed, 04 Dec 2019 08:31:06 +0200 Message-ID: <87muc8haad.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v3 04/12] video: fbdev: uvesafb: modify the static fb_ops directly X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gVHVlLCAwMyBEZWMgMjAxOSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBUdWUsIERlYyAwMywgMjAxOSBhdCAwNjozODo0NlBNICswMjAwLCBKYW5pIE5pa3Vs YSB3cm90ZToKPj4gQXZvaWQgbW9kaWZ5aW5nIHRoZSBmYl9vcHMgdmlhIGluZm8tPmZib3BzIHRv IGxldCB1cyBtYWtlIHRoZSBwb2ludGVyCj4+IGNvbnN0IGluIHRoZSBmdXR1cmUuCj4+IAo+PiBD YzogbGludXgtZmJkZXZAdmdlci5rZXJuZWwub3JnCj4+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlr dWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy92aWRlby9mYmRl di91dmVzYWZiLmMgfCA0ICsrLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9mYmRldi91 dmVzYWZiLmMgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3V2ZXNhZmIuYwo+PiBpbmRleCA0Mzk1NjVj YWU3YWIuLjUzZDA4ZDFiNTZmNSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy92aWRlby9mYmRldi91 dmVzYWZiLmMKPj4gKysrIGIvZHJpdmVycy92aWRlby9mYmRldi91dmVzYWZiLmMKPj4gQEAgLTE0 NDAsNyArMTQ0MCw3IEBAIHN0YXRpYyB2b2lkIHV2ZXNhZmJfaW5pdF9pbmZvKHN0cnVjdCBmYl9p bmZvICppbmZvLCBzdHJ1Y3QgdmJlX21vZGVfaWIgKm1vZGUpCj4+ICAKPj4gIAkvKiBEaXNhYmxl IGJsYW5raW5nIGlmIHRoZSB1c2VyIHJlcXVlc3RlZCBzby4gKi8KPj4gIAlpZiAoIWJsYW5rKQo+ PiAtCQlpbmZvLT5mYm9wcy0+ZmJfYmxhbmsgPSBOVUxMOwo+PiArCQl1dmVzYWZiX29wcy5mYl9i bGFuayA9IE5VTEw7Cj4+ICAKPj4gIAkvKgo+PiAgCSAqIEZpbmQgb3V0IGhvdyBtdWNoIElPIG1l bW9yeSBpcyByZXF1aXJlZCBmb3IgdGhlIG1vZGUgd2l0aAo+PiBAQCAtMTUxMCw3ICsxNTEwLDcg QEAgc3RhdGljIHZvaWQgdXZlc2FmYl9pbml0X2luZm8oc3RydWN0IGZiX2luZm8gKmluZm8sIHN0 cnVjdCB2YmVfbW9kZV9pYiAqbW9kZSkKPj4gIAkJCShwYXItPnlwYW4gPyBGQklORk9fSFdBQ0NF TF9ZUEFOIDogMCk7Cj4+ICAKPj4gIAlpZiAoIXBhci0+eXBhbikKPj4gLQkJaW5mby0+ZmJvcHMt PmZiX3Bhbl9kaXNwbGF5ID0gTlVMTDsKPj4gKwkJdXZlc2FmYl9vcHMuZmJfcGFuX2Rpc3BsYXkg PSBOVUxMOwo+PiAgfQo+Cj4gSSByZWFkIGNvZGUuCj4KPiBJIGNyaWVkLgo+Cj4gUmV2aWV3ZWQt Ynk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4KPiBBbHNvLCB3aXRo IG1vcmUgcmVhZGluZyBhbmQgbW9yZSBiYWQgZHJlYW1zIEknbGwgZ2V0IGFib3V0IHRoaXMsIEkn bQo+IHJldmlzaW5nIG15IHRha2Ugb24gcGF0Y2hlcyAxJjIgaW4gdGhpcyBzZXJpZXMuIE9uIHRo b3NlIGFsc28KPgo+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZm d2xsLmNoPgo+Cj4gYXMtaXMuCgpUaGFua3MuIEkgZmVlbCB5b3UuCgpBbmQgcmVtZW1iZXIsIGFs bCBJIGV2ZXIgd2FudGVkIHRvIGRvIHdhcwoKLXN0YXRpYyBzdHJ1Y3QgZmJfb3BzIGludGVsZmJf b3BzID0geworc3RhdGljIGNvbnN0IHN0cnVjdCBmYl9vcHMgaW50ZWxmYl9vcHMgPSB7CgppbiBk cml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2ZiZGV2LmMuCgoKQlIsCkphbmkuCgoK Pgo+IENoZWVycywgRGFuaWVsCj4+ICAKPj4gIHN0YXRpYyB2b2lkIHV2ZXNhZmJfaW5pdF9tdHJy KHN0cnVjdCBmYl9pbmZvICppbmZvKQo+PiAtLSAKPj4gMi4yMC4xCj4+IAo+PiBfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+PiBJbnRlbC1nZnggbWFpbGlu ZyBsaXN0Cj4+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApKYW5pIE5p a3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==