From: Richard Palethorpe <rpalethorpe@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] read_all: move blacklist to source
Date: Wed, 06 Nov 2019 15:40:54 +0100 [thread overview]
Message-ID: <87mud9dq4p.fsf@rpws.prws.suse.cz> (raw)
In-Reply-To: <20191106132751.GB8135@rei.lan>
hello,
Cyril Hrubis <chrubis@suse.cz> writes:
> Hi!
>> > +static char *blacklist[] = {
>> > + NULL, /* reserved for -e parameter */
>> > + "/sys/power/wakeup_count",
>> > +};
>>
>> The problem with this is that it is only required if we are running as a
>> privileged user. If -p is specified then it would be a bug if nobody can
>> read from any of these files.
>
> Good point.
>
>> So I guess we could disable the builtin blacklist if drop_privs (switch
>> to nobody) is specified and run this test twice on /sys with and without
>
> Sounds reasonable, will you send a patch?
Yeah, sure.
--
Thank you,
Richard.
next prev parent reply other threads:[~2019-11-06 14:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 12:23 [LTP] [PATCH v2 1/2] read_all: move blacklist to source Jan Stancek
2019-11-05 12:23 ` [LTP] [PATCH v2 2/2] read_all_sys: skip debugfs Jan Stancek
2019-11-05 12:38 ` [LTP] [PATCH v2 1/2] read_all: move blacklist to source Cyril Hrubis
2019-11-05 13:12 ` Jan Stancek
2019-11-05 13:14 ` Cyril Hrubis
2019-11-05 13:29 ` Jan Stancek
2019-11-06 12:33 ` Richard Palethorpe
2019-11-06 13:27 ` Cyril Hrubis
2019-11-06 14:40 ` Richard Palethorpe [this message]
2019-11-06 15:28 ` Jan Stancek
2019-11-07 10:33 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mud9dq4p.fsf@rpws.prws.suse.cz \
--to=rpalethorpe@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.