From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/iputils: enable systemd services
Date: Fri, 01 Nov 2019 11:14:31 +0100 [thread overview]
Message-ID: <87mudfhpiw.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20191101055531.GA6022@x230> (Petr Vorel's message of "Fri, 1 Nov 2019 06:55:31 +0100")
>>>>> "Petr" == Petr Vorel <petr.vorel@gmail.com> writes:
Hi,
> Maybe simplify IPUTILS_CONF_OPTS (diff to your patch)?
> +++ package/iputils/iputils.mk
> @@ -46,17 +46,17 @@ IPUTILS_DEPENDENCIES += linux-headers
> else
> IPUTILS_CONF_OPTS += -DUSE_CRYPTO=none
> # BUILD_NINFOD=true and USE_CRYPTO=none cannot be combined
> -IPUTILS_CONF_OPTS += -DBUILD_NINFOD=false
> IPUTILS_NO_NINFOD = y
> endif
> # ninfod requires <pthread.h>
> ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> -IPUTILS_CONF_OPTS += -DBUILD_NINFOD=false
> IPUTILS_NO_NINFOD = y
> endif
> ifneq ($(IPUTILS_NO_NINFOD),y)
> +IPUTILS_CONF_OPTS += -DBUILD_NINFOD=false
> +
> define IPUTILS_INSTALL_SERVICE_NINFOD
> mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> ln -sf ../../../../lib/systemd/system/ninfod.service \
This doesn't make sense. With this you diable ninfod (by passing
BUILD_NINFOD=false) AND install the service file.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-11-01 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 2:44 [Buildroot] [PATCH 1/1] package/iputils: enable systemd services James Hilliard
2019-11-01 5:55 ` Petr Vorel
2019-11-01 10:14 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mudfhpiw.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.