From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/virtio: print a single line with device features Date: Wed, 23 Oct 2019 16:18:06 +0300 Message-ID: <87mudreh2p.fsf@intel.com> References: <20191018113832.5460-1-kraxel@redhat.com> <20191022090533.GB11828@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20191022090533.GB11828@phenom.ffwll.local> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter , Gerd Hoffmann Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org On Tue, 22 Oct 2019, Daniel Vetter wrote: > On Fri, Oct 18, 2019 at 01:38:32PM +0200, Gerd Hoffmann wrote: >> Signed-off-by: Gerd Hoffmann >> --- >> drivers/gpu/drm/virtio/virtgpu_kms.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c >> index 0b3cdb0d83b0..2f5773e43557 100644 >> --- a/drivers/gpu/drm/virtio/virtgpu_kms.c >> +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c >> @@ -155,16 +155,15 @@ int virtio_gpu_init(struct drm_device *dev) >> #ifdef __LITTLE_ENDIAN >> if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_VIRGL)) >> vgdev->has_virgl_3d = true; >> - DRM_INFO("virgl 3d acceleration %s\n", >> - vgdev->has_virgl_3d ? "enabled" : "not supported by host"); >> -#else >> - DRM_INFO("virgl 3d acceleration not supported by guest\n"); >> #endif >> if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_EDID)) { >> vgdev->has_edid = true; >> - DRM_INFO("EDID support available.\n"); >> } >> >> + DRM_INFO("features: %cvirgl %cedid\n", >> + vgdev->has_virgl_3d ? '+' : '-', >> + vgdev->has_edid ? '+' : '-'); > > Maybe we should move the various yesno/onoff/enableddisabled helpers from > i915_utils.h to drm_utils.h and use them more widely? I'm trying to take it one step further by adding them to include/linux/string-choice.h [1]. Maybe, uh, fourth time's the charm? BR, Jani. [1] http://lore.kernel.org/r/20191023131308.9420-1-jani.nikula@intel.com -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0767CA9EB6 for ; Wed, 23 Oct 2019 13:18:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC4EF2173B for ; Wed, 23 Oct 2019 13:18:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC4EF2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B47E6EA9B; Wed, 23 Oct 2019 13:18:13 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9264E6EA9B for ; Wed, 23 Oct 2019 13:18:12 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:18:12 -0700 X-IronPort-AV: E=Sophos;i="5.68,221,1569308400"; d="scan'208";a="191826942" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:18:09 -0700 From: Jani Nikula To: Daniel Vetter , Gerd Hoffmann Subject: Re: [PATCH] drm/virtio: print a single line with device features In-Reply-To: <20191022090533.GB11828@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191018113832.5460-1-kraxel@redhat.com> <20191022090533.GB11828@phenom.ffwll.local> Date: Wed, 23 Oct 2019 16:18:06 +0300 Message-ID: <87mudreh2p.fsf@intel.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO GPU DRIVER" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191023131806.RKrlBuRk3wXMnjn68PhjB5WCFQiQzLFfGESuHwraQ9s@z> T24gVHVlLCAyMiBPY3QgMjAxOSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBGcmksIE9jdCAxOCwgMjAxOSBhdCAwMTozODozMlBNICswMjAwLCBHZXJkIEhvZmZt YW5uIHdyb3RlOgo+PiBTaWduZWQtb2ZmLWJ5OiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0 LmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfa21zLmMgfCA5 ICsrKystLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlv bnMoLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVf a21zLmMgYi9kcml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfa21zLmMKPj4gaW5kZXggMGIz Y2RiMGQ4M2IwLi4yZjU3NzNlNDM1NTcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS92 aXJ0aW8vdmlydGdwdV9rbXMuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRn cHVfa21zLmMKPj4gQEAgLTE1NSwxNiArMTU1LDE1IEBAIGludCB2aXJ0aW9fZ3B1X2luaXQoc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPj4gICNpZmRlZiBfX0xJVFRMRV9FTkRJQU4KPj4gIAlpZiAo dmlydGlvX2hhc19mZWF0dXJlKHZnZGV2LT52ZGV2LCBWSVJUSU9fR1BVX0ZfVklSR0wpKQo+PiAg CQl2Z2Rldi0+aGFzX3ZpcmdsXzNkID0gdHJ1ZTsKPj4gLQlEUk1fSU5GTygidmlyZ2wgM2QgYWNj ZWxlcmF0aW9uICVzXG4iLAo+PiAtCQkgdmdkZXYtPmhhc192aXJnbF8zZCA/ICJlbmFibGVkIiA6 ICJub3Qgc3VwcG9ydGVkIGJ5IGhvc3QiKTsKPj4gLSNlbHNlCj4+IC0JRFJNX0lORk8oInZpcmds IDNkIGFjY2VsZXJhdGlvbiBub3Qgc3VwcG9ydGVkIGJ5IGd1ZXN0XG4iKTsKPj4gICNlbmRpZgo+ PiAgCWlmICh2aXJ0aW9faGFzX2ZlYXR1cmUodmdkZXYtPnZkZXYsIFZJUlRJT19HUFVfRl9FRElE KSkgewo+PiAgCQl2Z2Rldi0+aGFzX2VkaWQgPSB0cnVlOwo+PiAtCQlEUk1fSU5GTygiRURJRCBz dXBwb3J0IGF2YWlsYWJsZS5cbiIpOwo+PiAgCX0KPj4gIAo+PiArCURSTV9JTkZPKCJmZWF0dXJl czogJWN2aXJnbCAlY2VkaWRcbiIsCj4+ICsJCSB2Z2Rldi0+aGFzX3ZpcmdsXzNkID8gJysnIDog Jy0nLAo+PiArCQkgdmdkZXYtPmhhc19lZGlkICAgICA/ICcrJyA6ICctJyk7Cj4KPiBNYXliZSB3 ZSBzaG91bGQgbW92ZSB0aGUgdmFyaW91cyB5ZXNuby9vbm9mZi9lbmFibGVkZGlzYWJsZWQgaGVs cGVycyBmcm9tCj4gaTkxNV91dGlscy5oIHRvIGRybV91dGlscy5oIGFuZCB1c2UgdGhlbSBtb3Jl IHdpZGVseT8KCkknbSB0cnlpbmcgdG8gdGFrZSBpdCBvbmUgc3RlcCBmdXJ0aGVyIGJ5IGFkZGlu ZyB0aGVtIHRvCmluY2x1ZGUvbGludXgvc3RyaW5nLWNob2ljZS5oIFsxXS4gTWF5YmUsIHVoLCBm b3VydGggdGltZSdzIHRoZSBjaGFybT8KCkJSLApKYW5pLgoKWzFdIGh0dHA6Ly9sb3JlLmtlcm5l bC5vcmcvci8yMDE5MTAyMzEzMTMwOC45NDIwLTEtamFuaS5uaWt1bGFAaW50ZWwuY29tCgoKLS0g CkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120DEC47E49 for ; Wed, 23 Oct 2019 13:18:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E768421928 for ; Wed, 23 Oct 2019 13:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391851AbfJWNSM (ORCPT ); Wed, 23 Oct 2019 09:18:12 -0400 Received: from mga05.intel.com ([192.55.52.43]:7044 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389425AbfJWNSM (ORCPT ); Wed, 23 Oct 2019 09:18:12 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:18:12 -0700 X-IronPort-AV: E=Sophos;i="5.68,221,1569308400"; d="scan'208";a="191826942" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 06:18:09 -0700 From: Jani Nikula To: Daniel Vetter , Gerd Hoffmann Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list\:VIRTIO GPU DRIVER" Subject: Re: [PATCH] drm/virtio: print a single line with device features In-Reply-To: <20191022090533.GB11828@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191018113832.5460-1-kraxel@redhat.com> <20191022090533.GB11828@phenom.ffwll.local> Date: Wed, 23 Oct 2019 16:18:06 +0300 Message-ID: <87mudreh2p.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Oct 2019, Daniel Vetter wrote: > On Fri, Oct 18, 2019 at 01:38:32PM +0200, Gerd Hoffmann wrote: >> Signed-off-by: Gerd Hoffmann >> --- >> drivers/gpu/drm/virtio/virtgpu_kms.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c >> index 0b3cdb0d83b0..2f5773e43557 100644 >> --- a/drivers/gpu/drm/virtio/virtgpu_kms.c >> +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c >> @@ -155,16 +155,15 @@ int virtio_gpu_init(struct drm_device *dev) >> #ifdef __LITTLE_ENDIAN >> if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_VIRGL)) >> vgdev->has_virgl_3d = true; >> - DRM_INFO("virgl 3d acceleration %s\n", >> - vgdev->has_virgl_3d ? "enabled" : "not supported by host"); >> -#else >> - DRM_INFO("virgl 3d acceleration not supported by guest\n"); >> #endif >> if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_EDID)) { >> vgdev->has_edid = true; >> - DRM_INFO("EDID support available.\n"); >> } >> >> + DRM_INFO("features: %cvirgl %cedid\n", >> + vgdev->has_virgl_3d ? '+' : '-', >> + vgdev->has_edid ? '+' : '-'); > > Maybe we should move the various yesno/onoff/enableddisabled helpers from > i915_utils.h to drm_utils.h and use them more widely? I'm trying to take it one step further by adding them to include/linux/string-choice.h [1]. Maybe, uh, fourth time's the charm? BR, Jani. [1] http://lore.kernel.org/r/20191023131308.9420-1-jani.nikula@intel.com -- Jani Nikula, Intel Open Source Graphics Center