From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert \(git\)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] pcie_root_port: Disable ACS on older machines
Date: Tue, 30 Jul 2019 15:42:23 +0200 [thread overview]
Message-ID: <87mugvk5a8.fsf@trasno.org> (raw)
In-Reply-To: <20190730093719.12958-3-dgilbert@redhat.com> (David Alan Gilbert's message of "Tue, 30 Jul 2019 10:37:19 +0100")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> ACS got added in 4.0 unconditionally, that broke older<->4.0 migration
> where there was a PCIe root port.
> Fix this by turning it off for 3.1 and older machines; note this
> fixes compatibility for older QEMUs but breaks compatibility with 4.0
> for older machine types.
>
> machine type source qemu dest qemu
> 3.1 3.1 4.0 broken
> 3.1 3.1 4.1rc2 broken
> 3.1 3.1 4.1+this OK ++
> 3.1 4.0 4.1rc2 OK
> 3.1 4.0 4.1+this broken --
> 4.0 4.0 4.1rc2 OK
> 4.0 4.0 4.1+this OK
>
> So we gain and lose; the consensus seems to be treat this as a
> fix for older machine types.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2019-07-30 13:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 9:37 [Qemu-devel] [for 4.1 PATCH 0/2] Disable PCIe ACS on older machines Dr. David Alan Gilbert (git)
2019-07-30 9:37 ` [Qemu-devel] [PATCH 1/2] pcie_root_port: Allow ACS to be disabled Dr. David Alan Gilbert (git)
2019-07-30 19:45 ` [Qemu-devel] [PULL " Michael S. Tsirkin
2019-07-30 10:25 ` [Qemu-devel] [PATCH " Igor Mammedov
2019-07-30 11:13 ` Dr. David Alan Gilbert
2019-07-30 12:03 ` Igor Mammedov
2019-07-30 12:41 ` Dr. David Alan Gilbert
2019-07-30 13:42 ` Juan Quintela
2019-07-30 9:37 ` [Qemu-devel] [PATCH 2/2] pcie_root_port: Disable ACS on older machines Dr. David Alan Gilbert (git)
2019-07-30 19:46 ` [Qemu-devel] [PULL " Michael S. Tsirkin
2019-07-30 12:05 ` [Qemu-devel] [PATCH " Igor Mammedov
2019-07-30 13:42 ` Juan Quintela [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-07-30 19:45 [Qemu-devel] [PULL 0/2] pci: bugfix Michael S. Tsirkin
2019-08-02 14:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mugvk5a8.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.