From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
pbonzini@redhat.com, richard.henderson@linaro.org,
philmd@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/4] Makefile: Rename targets for make recursion
Date: Wed, 03 Jul 2019 13:24:16 +0200 [thread overview]
Message-ID: <87muhvwecf.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190528082308.22032-4-armbru@redhat.com> (Markus Armbruster's message of "Tue, 28 May 2019 10:23:07 +0200")
Peter pointed out that this makes an incremental build without -k fail
once. By "once", I mean it works fine when you retry. Squashing in the
appended patch to avoid this inconvenience.
diff --git a/Makefile b/Makefile
index e68982bd99..34bbcfc590 100644
--- a/Makefile
+++ b/Makefile
@@ -500,6 +500,12 @@ capstone/all: .git-submodule-status
slirp/all: .git-submodule-status
$(call quiet-command,$(MAKE) -C $(SRC_PATH)/slirp BUILD_DIR="$(BUILD_DIR)/slirp" CC="$(CC)" AR="$(AR)" LD="$(LD)" RANLIB="$(RANLIB)" CFLAGS="$(QEMU_CFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)")
+# Compatibility gunk to keep make working across the rename of targets
+# for recursion, to be removed some time after 4.1.
+subdir-dtc: dtc/all
+subdir-capstone: capstone/all
+subdir-slirp: slirp/all
+
$(SUBDIR_RULES): libqemuutil.a $(common-obj-y) \
$(qom-obj-y) $(crypto-user-obj-$(CONFIG_USER_ONLY))
next prev parent reply other threads:[~2019-07-03 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 8:23 [Qemu-devel] [PATCH 0/4] Makefile: Generalize recursion machinery Markus Armbruster
2019-05-28 8:23 ` [Qemu-devel] [PATCH 1/4] Makefile: Remove code to smooth transition to config.status Markus Armbruster
2019-05-28 8:23 ` [Qemu-devel] [PATCH 2/4] Makefile: Drop bogus cleaning of $(ALL_SUBDIRS)/qemu-options.def Markus Armbruster
2019-05-28 8:23 ` [Qemu-devel] [PATCH 3/4] Makefile: Rename targets for make recursion Markus Armbruster
2019-07-03 11:24 ` Markus Armbruster [this message]
2019-07-03 11:49 ` Philippe Mathieu-Daudé
2019-05-28 8:23 ` [Qemu-devel] [PATCH 4/4] Makefile: Reuse all's recursion machinery for clean and install Markus Armbruster
2019-05-28 15:55 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muhvwecf.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.