From: Jiong Wang <jiong.wang@netronome.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Jiong Wang <jiong.wang@netronome.com>,
Edward Cree <ecree@solarflare.com>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH] bpf: optimize constant blinding
Date: Mon, 17 Jun 2019 22:01:56 +0100 [thread overview]
Message-ID: <87muig3ozf.fsf@netronome.com> (raw)
In-Reply-To: <CAADnVQLt7=9XQRccerLqHO8cdXTLy-uNBt-JOjbx=bAFouLf3Q@mail.gmail.com>
Alexei Starovoitov writes:
> On Mon, Jun 17, 2019 at 1:40 PM Jiong Wang <jiong.wang@netronome.com> wrote:
>>
>> After digest Alexei and Andrii's reply, I still don't see the need to turn
>> branch target into list, and I am not sure whether pool based list sound
>> good? it saves size, resize pool doesn't invalid allocated node (the offset
>> doesn't change) but requires one extra addition to calculate the pointer.
>
> I don't think it worth to do a pool to accelerate kmalloc.
Got it.
> I doubt it will be faster either.
Will benchmark.
Regards,
Jiong
next prev parent reply other threads:[~2019-06-17 21:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 11:32 [PATCH] bpf: optimize constant blinding Naveen N. Rao
2019-06-12 14:47 ` Alexei Starovoitov
2019-06-12 15:04 ` Jiong Wang
2019-06-12 15:25 ` Jiong Wang
2019-06-12 15:28 ` Alexei Starovoitov
2019-06-14 15:13 ` Jiong Wang
2019-06-14 17:05 ` Alexei Starovoitov
2019-06-14 22:28 ` Andrii Nakryiko
2019-06-17 19:47 ` Edward Cree
2019-06-17 19:59 ` Jiong Wang
2019-06-17 20:11 ` Edward Cree
2019-06-17 20:40 ` Jiong Wang
2019-06-17 20:53 ` Alexei Starovoitov
2019-06-17 21:01 ` Jiong Wang [this message]
2019-06-17 21:16 ` Edward Cree
2019-06-19 20:45 ` Jiong Wang
2019-06-14 4:30 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muig3ozf.fsf@netronome.com \
--to=jiong.wang@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ecree@solarflare.com \
--cc=jakub.kicinski@netronome.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.