From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Date: Tue, 02 Apr 2019 17:45:44 +0000 Subject: Re: [PATCH v5 2/2] fbcon: Silence fbcon logo on 'quiet' boots Message-Id: <87mul8pagn.fsf@igel.home> List-Id: References: <20190129134350.24049-1-prarit@redhat.com> <20190129134350.24049-3-prarit@redhat.com> <87ftr1ed4h.fsf@igel.home> <8590ff59-a4fb-5a02-fda4-086476efcbe6@redhat.com> In-Reply-To: <8590ff59-a4fb-5a02-fda4-086476efcbe6@redhat.com> (Prarit Bhargava's message of "Tue, 2 Apr 2019 07:31:49 -0400") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Prarit Bhargava Cc: Marko Myllynen , linux-fbdev@vger.kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , Daniel Vetter , Steven Rostedt , Yisheng Xie , Hans de Goede , dri-devel@lists.freedesktop.org, Thierry Reding On Apr 02 2019, Prarit Bhargava wrote: > On 4/1/19 3:31 PM, Andreas Schwab wrote: >> On Jan 29 2019, Prarit Bhargava wrote: >> >>> @@ -1066,6 +1069,9 @@ static void fbcon_init(struct vc_data *vc, int init) >>> >>> cap = info->flags; >>> >>> + if (console_loglevel <= CONSOLE_LOGLEVEL_QUIET) >>> + logo_shown = FBCON_LOGO_DONTSHOW; >>> + >>> if (vc != svc || logo_shown = FBCON_LOGO_DONTSHOW || >>> (info->fix.type = FB_TYPE_TEXT)) >>> logo = 0; >> >> This causes the scroll region to no longer be reset when the logo is >> removed. >> > > Andreas, my apologies but I'm not sure what you mean. Could you elaborate on > the broken and expected behaviour? If fbcon_init is called after the loglevel is reduced to CONSOLE_LOGLEVEL_QUIET, the logo is not drawn, but the scrolling region remains. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Subject: Re: [PATCH v5 2/2] fbcon: Silence fbcon logo on 'quiet' boots Date: Tue, 02 Apr 2019 19:45:44 +0200 Message-ID: <87mul8pagn.fsf@igel.home> References: <20190129134350.24049-1-prarit@redhat.com> <20190129134350.24049-3-prarit@redhat.com> <87ftr1ed4h.fsf@igel.home> <8590ff59-a4fb-5a02-fda4-086476efcbe6@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 28B0C89471 for ; Tue, 2 Apr 2019 17:45:51 +0000 (UTC) In-Reply-To: <8590ff59-a4fb-5a02-fda4-086476efcbe6@redhat.com> (Prarit Bhargava's message of "Tue, 2 Apr 2019 07:31:49 -0400") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Prarit Bhargava Cc: Marko Myllynen , linux-fbdev@vger.kernel.org, Kees Cook , Bartlomiej Zolnierkiewicz , Daniel Vetter , Steven Rostedt , Yisheng Xie , Hans de Goede , dri-devel@lists.freedesktop.org, Thierry Reding List-Id: dri-devel@lists.freedesktop.org T24gQXByIDAyIDIwMTksIFByYXJpdCBCaGFyZ2F2YSA8cHJhcml0QHJlZGhhdC5jb20+IHdyb3Rl OgoKPiBPbiA0LzEvMTkgMzozMSBQTSwgQW5kcmVhcyBTY2h3YWIgd3JvdGU6Cj4+IE9uIEphbiAy OSAyMDE5LCBQcmFyaXQgQmhhcmdhdmEgPHByYXJpdEByZWRoYXQuY29tPiB3cm90ZToKPj4gCj4+ PiBAQCAtMTA2Niw2ICsxMDY5LDkgQEAgc3RhdGljIHZvaWQgZmJjb25faW5pdChzdHJ1Y3QgdmNf ZGF0YSAqdmMsIGludCBpbml0KQo+Pj4gIAo+Pj4gIAljYXAgPSBpbmZvLT5mbGFnczsKPj4+ICAK Pj4+ICsJaWYgKGNvbnNvbGVfbG9nbGV2ZWwgPD0gQ09OU09MRV9MT0dMRVZFTF9RVUlFVCkKPj4+ ICsJCWxvZ29fc2hvd24gPSBGQkNPTl9MT0dPX0RPTlRTSE9XOwo+Pj4gKwo+Pj4gIAlpZiAodmMg IT0gc3ZjIHx8IGxvZ29fc2hvd24gPT0gRkJDT05fTE9HT19ET05UU0hPVyB8fAo+Pj4gIAkgICAg KGluZm8tPmZpeC50eXBlID09IEZCX1RZUEVfVEVYVCkpCj4+PiAgCQlsb2dvID0gMDsKPj4gCj4+ IFRoaXMgY2F1c2VzIHRoZSBzY3JvbGwgcmVnaW9uIHRvIG5vIGxvbmdlciBiZSByZXNldCB3aGVu IHRoZSBsb2dvIGlzCj4+IHJlbW92ZWQuCj4+IAo+Cj4gQW5kcmVhcywgbXkgYXBvbG9naWVzIGJ1 dCBJJ20gbm90IHN1cmUgd2hhdCB5b3UgbWVhbi4gIENvdWxkIHlvdSBlbGFib3JhdGUgb24KPiB0 aGUgYnJva2VuIGFuZCBleHBlY3RlZCBiZWhhdmlvdXI/CgpJZiBmYmNvbl9pbml0IGlzIGNhbGxl ZCBhZnRlciB0aGUgbG9nbGV2ZWwgaXMgcmVkdWNlZCB0bwpDT05TT0xFX0xPR0xFVkVMX1FVSUVU LCB0aGUgbG9nbyBpcyBub3QgZHJhd24sIGJ1dCB0aGUgc2Nyb2xsaW5nIHJlZ2lvbgpyZW1haW5z LgoKQW5kcmVhcy4KCi0tIApBbmRyZWFzIFNjaHdhYiwgc2Nod2FiQGxpbnV4LW02OGsub3JnCkdQ RyBLZXkgZmluZ2VycHJpbnQgPSA3NTc4IEVCNDcgRDRFNSA0RDY5IDI1MTAgIDI1NTIgREY3MyBF NzgwIEE5REEgQUVDMQoiQW5kIG5vdyBmb3Igc29tZXRoaW5nIGNvbXBsZXRlbHkgZGlmZmVyZW50 LiIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs