From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/2] Revert "drm/i915: Avoid waking the engines just to check if they are idle" Date: Thu, 28 Feb 2019 11:01:52 +0200 Message-ID: <87mumguvzz.fsf@gaia.fi.intel.com> References: <20190227204654.14907-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68F3689A61 for ; Thu, 28 Feb 2019 09:02:20 +0000 (UTC) In-Reply-To: <20190227204654.14907-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gVGhpcyBy ZXZlcnRzIGNvbW1pdCAwYjcwMmRjYTI2NTgwZTNiYmZiYmFmMjJkZmMyOTI4MGI2MjYzNDE0Lgo+ Cj4gQ0kgcmVwb3J0cyB0aGF0IHRoaXMgaXMgbm90IGFzIHJlbGlhYmxlIGFzIGl0IGZpcnN0IGFw cGVhcnMsIHdpdGgKPiBmYWlsdXJlcyBzdGFydGluZyB0byBzcG9yYWRpY2FsbHkgb2NjdXIgaW4g c2VsZnRlc3RzLgo+Cj4gRml4ZXM6IDBiNzAyZGNhMjY1OCAoImRybS9pOTE1OiBBdm9pZCB3YWtp bmcgdGhlIGVuZ2luZXMganVzdCB0byBjaGVjayBpZiB0aGV5IGFyZSBpZGxlIikKPiBTaWduZWQt b2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogTWlr YSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxq YW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFz LmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBNaWthIEt1b3BwYWxhIDxt aWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2VuZ2luZV9jcy5jIHwgMTcgKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+IGluZGV4IDRmMjQ0MDE5NTYwZC4uYjdiNjI2MTk1ZWRh IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBAQCAtOTY4LDcg Kzk2OCw2IEBAIHN0YXRpYyBib29sIHJpbmdfaXNfaWRsZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2Nz ICplbmdpbmUpCj4gIHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVu Z2luZS0+aTkxNTsKPiAgCWludGVsX3dha2VyZWZfdCB3YWtlcmVmOwo+IC0JdW5zaWduZWQgbG9u ZyBmbGFnczsKPiAgCWJvb2wgaWRsZSA9IHRydWU7Cj4gIAo+ICAJaWYgKEk5MTVfU0VMRlRFU1Rf T05MWSghZW5naW5lLT5tbWlvX2Jhc2UpKQo+IEBAIC05NzksMTkgKzk3OCwxNSBAQCBzdGF0aWMg Ym9vbCByaW5nX2lzX2lkbGUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJaWYg KCF3YWtlcmVmKQo+ICAJCXJldHVybiB0cnVlOwo+ICAKPiAtCXNwaW5fbG9ja19pcnFzYXZlKCZk ZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGZsYWdzKTsKPiArCS8qIEZpcnN0IGNoZWNrIHRoYXQgbm8g Y29tbWFuZHMgYXJlIGxlZnQgaW4gdGhlIHJpbmcgKi8KPiArCWlmICgoSTkxNV9SRUFEX0hFQUQo ZW5naW5lKSAmIEhFQURfQUREUikgIT0KPiArCSAgICAoSTkxNV9SRUFEX1RBSUwoZW5naW5lKSAm IFRBSUxfQUREUikpCj4gKwkJaWRsZSA9IGZhbHNlOwo+ICAKPiAtCS8qCj4gLQkgKiBDaGVjayB0 aGF0IG5vIGNvbW1hbmRzIGFyZSBsZWZ0IGluIHRoZSByaW5nLgo+IC0JICoKPiAtCSAqIElmIHRo ZSBlbmdpbmUgaXMgbm90IGF3YWtlLCBib3RoIHJlYWRzIHJldHVybiAwIGFzIHdlIGRvIHNvIHdp dGhvdXQKPiAtCSAqIGZvcmNld2FrZS4KPiAtCSAqLwo+IC0JaWYgKChJOTE1X1JFQURfRlcoUklO R19IRUFEKGVuZ2luZS0+bW1pb19iYXNlKSkgJiBIRUFEX0FERFIpICE9Cj4gLQkgICAgKEk5MTVf UkVBRF9GVyhSSU5HX1RBSUwoZW5naW5lLT5tbWlvX2Jhc2UpKSAmIFRBSUxfQUREUikpCj4gKwkv KiBObyBiaXQgZm9yIGdlbjIsIHNvIGFzc3VtZSB0aGUgQ1MgcGFyc2VyIGlzIGlkbGUgKi8KPiAr CWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID4gMiAmJiAhKEk5MTVfUkVBRF9NT0RFKGVuZ2luZSkg JiBNT0RFX0lETEUpKQo+ICAJCWlkbGUgPSBmYWxzZTsKPiAgCj4gLQlzcGluX3VubG9ja19pcnFy ZXN0b3JlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGZsYWdzKTsKPiAgCWludGVsX3J1bnRpbWVf cG1fcHV0KGRldl9wcml2LCB3YWtlcmVmKTsKPiAgCj4gIAlyZXR1cm4gaWRsZTsKPiAtLSAKPiAy LjIwLjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=