From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH v3 2/4] drm/vc4: Report underrun errors
Date: Fri, 25 Jan 2019 09:52:37 -0800
Message-ID: <87munovd3u.fsf@anholt.net>
References: <20190108145056.2276-1-paul.kocialkowski@bootlin.com> <20190108145056.2276-3-paul.kocialkowski@bootlin.com> <87a7jrus68.fsf@anholt.net> <70a1887da5ca55adeeceb0d1758ec7cfe2d747bb.camel@bootlin.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <70a1887da5ca55adeeceb0d1758ec7cfe2d747bb.camel@bootlin.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, Maxime Ripard <maxime.ripard@bootlin.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Eben Upton <eben@raspberrypi.org>, Daniel Vetter <daniel@ffwll.ch>, Boris Brezillon <boris.brezillon@bootlin.com>
List-Id: dri-devel@lists.freedesktop.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Paul Kocialkowski <paul.kocialkowski@bootlin.com> writes:

> Hi Eric,
>
> On Wed, 2019-01-23 at 10:47 -0800, Eric Anholt wrote:
>> Paul Kocialkowski <paul.kocialkowski@bootlin.com> writes:
>> > +void vc4_hvs_mask_underrun(struct drm_device *dev)
>> > +{
>> > +	struct vc4_dev *vc4 =3D to_vc4_dev(dev);
>> > +	u32 dispctrl =3D HVS_READ(SCALER_DISPCTRL);
>> > +
>> > +	dispctrl &=3D ~(SCALER_DISPCTRL_DSPEISLUR(0) |
>> > +		      SCALER_DISPCTRL_DSPEISLUR(1) |
>> > +		      SCALER_DISPCTRL_DSPEISLUR(2));
>> > +
>> > +	HVS_WRITE(SCALER_DISPCTRL, dispctrl);
>> > +}
>> > +
>> > +void vc4_hvs_unmask_underrun(struct drm_device *dev)
>> > +{
>> > +	struct vc4_dev *vc4 =3D to_vc4_dev(dev);
>> > +	u32 dispctrl =3D HVS_READ(SCALER_DISPCTRL);
>> > +
>> > +	dispctrl |=3D SCALER_DISPCTRL_DSPEISLUR(0) |
>> > +		    SCALER_DISPCTRL_DSPEISLUR(1) |
>> > +		    SCALER_DISPCTRL_DSPEISLUR(2);
>> > +
>> > +	HVS_WRITE(SCALER_DISPSTAT,
>> > +		  SCALER_DISPSTAT_EUFLOW(0) |
>> > +		  SCALER_DISPSTAT_EUFLOW(1) |
>> > +		  SCALER_DISPSTAT_EUFLOW(2));
>> > +	HVS_WRITE(SCALER_DISPCTRL, dispctrl);
>> > +}
>> > +
>> > +static void vc4_hvs_report_underrun(struct drm_device *dev)
>> > +{
>> > +	struct vc4_dev *vc4 =3D to_vc4_dev(dev);
>> > +
>> > +	atomic_inc(&vc4->underrun);
>> > +	DRM_DEV_ERROR(dev->dev, "HVS underrun\n");
>> > +}
>> > +
>> > +static irqreturn_t vc4_hvs_irq_handler(int irq, void *data)
>> > +{
>> > +	struct drm_device *dev =3D data;
>> > +	struct vc4_dev *vc4 =3D to_vc4_dev(dev);
>> > +	u32 status;
>> > +
>> > +	status =3D HVS_READ(SCALER_DISPSTAT);
>> > +
>> > +	if (status &
>> > +	    (SCALER_DISPSTAT_EUFLOW(0) | SCALER_DISPSTAT_EUFLOW(1) |
>> > +	     SCALER_DISPSTAT_EUFLOW(2))) {
>> > +		vc4_hvs_mask_underrun(dev);
>> > +		vc4_hvs_report_underrun(dev);
>> > +	}
>> > +
>> > +	HVS_WRITE(SCALER_DISPSTAT, status);
>> > +
>> > +	return status ? IRQ_HANDLED : IRQ_NONE;
>> > +}
>>=20
>> So, if UFLOW is set then we incremented the counter and disabled the
>> interrupt, otherwise we acked this specific interrupt and return?  Given
>> that a short-line error (the other potential cause of EISLUR) would be
>> likely to persist, we should probably either vc4_hvs_mask_underrun() in
>> that case too, or only return IRQ_HANDLED for the case we actually
>> handled.
>
> I see, there is definitely an inconsistency here. I don't think we
> should be disabling the interrupt if we get a short line indication,
> just in case the interrupt gets triggered later for a legitimate
> underrun (before the next commit).
>
> So I think we should just totally ignore the short line status bit for
> the IRQ return (although it certainly doesn't hurt to clear it as
> well). What do you think?

You just have to make sure that you return UNHANDLED for short line, so
an IRQ storm doesn't take down the machine.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlxLTOUACgkQtdYpNtH8
nuitZw/9F2VpeN7k2GBZI/uv73mvAPvmoVipB8ygbeZT0PsVt/ykTLlbmfc/rQNO
WucUauFgAXboeEryl+WzNYw69vOdCOBoKOeOT0Urn/gfJwtKDHyseVoE9Sxt41OE
MHo+/iRn0avKbzgLWxJPcbO67CH5ZPKLfelhDD/fPFYd5OMM5JxJeGlSPX1eGbaS
NPlVaPI6Wz227HaQzBuaKxMpk5wAcdCju9u9kPdPT+yYbyLvYYGReouio+zlvbsg
lcqdDlVycRHB7pHqNAQqB704z0lCKadOoX/NsOWA59YVvIh/MjZWSa543xLJo1mb
ucbVOuKJ/hW3CFvBnDQprcCjFTXRVDo9h2NKbr9NpKaNLzantlqmOp1DR4Txyvan
+5CEM7Gdf4S4CulXaSeadtvWPlBI7pD48O/Hye9r5htMzDJ8x7OfS4Ump1UbCmgs
KfrHQCBdFuqnPwzkc9Dg9M/1qkBMUeMR6m+9iGm9EdpyHsugNBPjA1Vr2GOg0UNQ
paeyYz41K5bSwA9f9HvYQHLBIynLscmXj+Mqd0IrAqwta29s4v17PXRo8gcwtYBs
wurDSqvvHsbw07dz8CW1Mxr2NFaRVj5TECxILKVYPwtc2x0WmyBABKVqN+aZw6pU
J4MwmCHxFVmENAlGw7W+8JlftmD5GY+YVnmhpQD5rTMX+UANqK4=
=vRly
-----END PGP SIGNATURE-----
--=-=-=--