From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYvY7-0004JZ-6Y for qemu-devel@nongnu.org; Mon, 17 Dec 2018 11:15:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYvY1-0004Es-DE for qemu-devel@nongnu.org; Mon, 17 Dec 2018 11:15:19 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:35774) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYvY0-0004Dr-Fv for qemu-devel@nongnu.org; Mon, 17 Dec 2018 11:15:13 -0500 Received: by mail-wr1-x442.google.com with SMTP id 96so12899957wrb.2 for ; Mon, 17 Dec 2018 08:15:12 -0800 (PST) References: <20181217150116.10446-1-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20181217150116.10446-1-alex.bennee@linaro.org> Date: Mon, 17 Dec 2018 16:15:10 +0000 Message-ID: <87mup4gmep.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v1 0/4] de-macrofy softmmu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: cota@braap.org Alex Benn=C3=A9e writes: > Hi, > > > Unfortunately in my simple boot test I see a slight performance > degradation: > > original: 10 times (100.00%), avg time 5.358 (0.02 varience/0.13 deviatio= n) > demacro: 10 times (100.00%), avg time 5.760 (0.08 varience/0.29 deviation) Moving stuff back into cputlb seems to help: 10 times (100.00%), avg time 5.583 (0.03 varience/0.17 deviation) > > Emilio, > > Any chance you could run this through your more comprehensive benchmark > suite? > > Alex Benn=C3=A9e (4): > accel/tcg: export some cputlb functions > accel/tcg: introduce softmmu.c > accel/tcg: use TLB helpers from softmmu.o > accel/tcg: remove softmmu_template.h > > accel/tcg/Makefile.objs | 1 + > accel/tcg/cputlb.c | 63 +---- > accel/tcg/cputlb.h | 21 ++ > accel/tcg/softmmu.c | 452 +++++++++++++++++++++++++++++++++++ > accel/tcg/softmmu_template.h | 446 ---------------------------------- > 5 files changed, 485 insertions(+), 498 deletions(-) > create mode 100644 accel/tcg/cputlb.h > create mode 100644 accel/tcg/softmmu.c > delete mode 100644 accel/tcg/softmmu_template.h -- Alex Benn=C3=A9e