From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] alsa-utils: add udev optional dependency
Date: Fri, 14 Dec 2018 06:40:40 +0200 [thread overview]
Message-ID: <87mup867qv.fsf@tkos.co.il> (raw)
In-Reply-To: <20181213214802.7730-1-fontaine.fabrice@gmail.com>
Hi Fabrice,
Fabrice Fontaine writes:
> Add udev optional dependency and fix build with pkgconf 1.5.3
>
> Since the bump to 1.5.3, pkgconf prepends the sysroot to all absolute
> paths found in the .pc file. This is correct when the paths refer to
> something in STAGING_DIR (e.g. libdir, includedir), but not when it
> refers to something used for the target.
>
> alsa-utils uses the udevdir variable from udev.pc to decide where to
> install things. Since DESTDIR is prepended to the install destination,
> this will end up in the wrong location.
>
> Until a better solution is found in pkgconf, pass the udevrulesdir to
> use explicitly instead of relying on udev.pc.
>
> Fixes:
> - http://autobuild.buildroot.org/results/d8ad140ae52b4fe8e153de3835f3f17e92b58e53
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/alsa-utils/alsa-utils.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/alsa-utils/alsa-utils.mk b/package/alsa-utils/alsa-utils.mk
> index 0bf2b432bd..422318796f 100644
> --- a/package/alsa-utils/alsa-utils.mk
> +++ b/package/alsa-utils/alsa-utils.mk
> @@ -28,6 +28,11 @@ ALSA_UTILS_CONF_OPTS = \
> --disable-rst2man \
> --with-curses=$(if $(BR2_PACKAGE_NCURSES_WCHAR),ncursesw,ncurses)
>
> +ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
> +ALSA_UTILS_CONF_OPTS += --with-udev-rules-dir=/usr/lib/udev/rules.d
> +ALSA_UTILS_DEPENDENCIES += udev
Is there a build time dependency of alsa-utils on udev? As far as I can
see alsa-utils only installs the .rules file, so the order of build
should not matter.
> +endif
> +
> ifeq ($(BR2_PACKAGE_ALSA_UTILS_ALSALOOP),y)
> ALSA_UTILS_CONF_OPTS += --enable-alsaloop
> else
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2018-12-14 4:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 21:48 [Buildroot] [PATCH 1/2] alsa-utils: add udev optional dependency Fabrice Fontaine
2018-12-13 21:48 ` [Buildroot] [PATCH 2/2] alsa-utils: fix systemd build with pkgconf 1.5.3 Fabrice Fontaine
2018-12-14 4:40 ` Baruch Siach [this message]
2018-12-14 7:52 ` [Buildroot] [PATCH 1/2] alsa-utils: add udev optional dependency Fabrice Fontaine
2018-12-14 8:09 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mup867qv.fsf@tkos.co.il \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.