From: Markus Armbruster <armbru@redhat.com>
To: Li Qiang <liq3ea@gmail.com>
Cc: pbonzini@redhat.com, f4bug@amsat.org, qemu-devel@nongnu.org,
qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qdev: fix a typo in comment
Date: Thu, 20 Sep 2018 20:00:53 +0200 [thread overview]
Message-ID: <87musccalm.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1536130141-2742-1-git-send-email-liq3ea@gmail.com> (Li Qiang's message of "Tue, 4 Sep 2018 23:49:01 -0700")
Could be merged via qemu-trivial (cc'ed).
Li Qiang <liq3ea@gmail.com> writes:
> Found by reading code.
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> hw/core/qdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 529b82de18..7e4bfcb8f7 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -643,7 +643,7 @@ static void qdev_get_legacy_property(Object *obj, Visitor *v,
> * the string depends on the property type. Legacy properties are only
> * needed for "info qtree".
> *
> - * Do not use this is new code! QOM Properties added through this interface
> + * Do not use this in new code! QOM Properties added through this interface
> * will be given names in the "legacy" namespace.
> */
> static void qdev_property_add_legacy(DeviceState *dev, Property *prop,
prev parent reply other threads:[~2018-09-20 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 6:49 [Qemu-devel] [PATCH] qdev: fix a typo in comment Li Qiang
2018-09-20 18:00 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87musccalm.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.