From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/2] drm/i915: Force reset on unready engine Date: Mon, 13 Aug 2018 12:58:10 +0300 Message-ID: <87mutq4mh9.fsf@gaia.fi.intel.com> References: <20180810140036.24240-1-mika.kuoppala@linux.intel.com> <20180810140036.24240-2-mika.kuoppala@linux.intel.com> <153391040793.12983.11406349176984550701@skylake-alporthouse-com> <87pnym4r40.fsf@gaia.fi.intel.com> <153414914466.23925.2644394062176644872@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E4CA6E0E4 for ; Mon, 13 Aug 2018 10:00:02 +0000 (UTC) In-Reply-To: <153414914466.23925.2644394062176644872@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE4LTA4LTEzIDA5OjE4OjA3KQo+PiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4gd3JpdGVzOgo+PiAKPj4gPiBRdW90aW5nIE1pa2EgS3Vv cHBhbGEgKDIwMTgtMDgtMTAgMTU6MDA6MzYpCj4+ID4+IElmIGVuZ2luZSByZXBvcnRzIHRoYXQg aXQgaXMgbm90IHJlYWR5IGZvciByZXNldCwgd2UKPj4gPj4gZ2l2ZSB1cC4gRXZpZGVuY2Ugc2hv d3MgdGhhdCBmb3JjaW5nIGEgcGVyIGVuZ2luZSByZXNldAo+PiA+PiBvbiBhbiBlbmdpbmUgd2hp Y2ggaXMgbm90IHJlcG9ydGluZyB0byBiZSByZWFkeSBmb3IgcmVzZXQsCj4+ID4+IGNhbiBicmlu ZyBpdCBiYWNrIGludG8gYSB3b3JraW5nIG9yZGVyLiBUaGVyZSBpcyByaXNrIHRoYXQKPj4gPj4g d2UgY29ycnVwdCB0aGUgY29udGV4dCBpbWFnZSBjdXJyZW50bHkgZXhlY3V0aW5nIG9uIHRoYXQK Pj4gPj4gZW5naW5lLiBCdXQgdGhhdCBpcyBhIHJpc2sgd29ydGggdGFraW5nIGFzIGlmIHdlIHVu YmxvY2sKPj4gPj4gdGhlIGVuZ2luZSwgd2UgcHJldmVudCBhIHdob2xlIGRldmljZSB3ZWRnaW5n IGluIGEgY2FzZQo+PiA+PiBvZiBmdWxsIGdwdSByZXNldC4KPj4gPj4gCj4+ID4+IFJlc2V0IGlu ZGl2aWR1YWwgZW5naW5lIGV2ZW4gaWYgaXQgcmVwb3J0cyB0aGF0IGl0IGlzIG5vdAo+PiA+PiBw cmVwYXJlZCBmb3IgcmVzZXQsIGJ1dCBvbmx5IGlmIHdlIGFpbSBmb3IgZnVsbCBncHUgcmVzZXQK Pj4gPj4gYW5kIG5vdCBvbiBmaXJzdCByZXNldCBhdHRlbXB0Lgo+PiA+PiAKPj4gPj4gdjI6IGZv cmNlIHJlc2V0IG9ubHkgb24gbGF0ZXIgYXR0ZW1wdHMsIHJlYWRhYmlsaXR5IChDaHJpcykKPj4g Pj4gCj4+ID4+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4g Pj4gU2lnbmVkLW9mZi1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRl bC5jb20+Cj4+ID4+IC0tLQo+PiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3Jl LmMgfCA0OSArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQo+PiA+PiAgMSBmaWxlIGNoYW5n ZWQsIDM5IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+PiA+PiAKPj4gPj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPj4gPj4gaW5kZXggMDI3ZDE0NTc0YmZhLi5kMjQwMjY4 MzliMTcgMTAwNjQ0Cj4+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29y ZS5jCj4+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4+ID4+ IEBAIC0yMDk5LDkgKzIwOTksNiBAQCBzdGF0aWMgaW50IGdlbjhfcmVzZXRfZW5naW5lX3N0YXJ0 KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4gPj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFJFU0VUX0NUTF9SRUFEWV9UT19SRVNFVCwKPj4gPj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDcwMCwgMCwKPj4gPj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwpOwo+PiA+PiAt ICAgICAgIGlmIChyZXQpCj4+ID4+IC0gICAgICAgICAgICAgICBEUk1fRVJST1IoIiVzOiByZXNl dCByZXF1ZXN0IHRpbWVvdXRcbiIsIGVuZ2luZS0+bmFtZSk7Cj4+ID4+IC0KPj4gPj4gICAgICAg ICByZXR1cm4gcmV0Owo+PiA+PiAgfQo+PiA+PiAgCj4+ID4+IEBAIC0yMTEzLDYgKzIxMTAsNDIg QEAgc3RhdGljIHZvaWQgZ2VuOF9yZXNldF9lbmdpbmVfY2FuY2VsKHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSkKPj4gPj4gICAgICAgICAgICAgICAgICAgICAgIF9NQVNLRURfQklUX0RJ U0FCTEUoUkVTRVRfQ1RMX1JFUVVFU1RfUkVTRVQpKTsKPj4gPj4gIH0KPj4gPj4gIAo+PiA+PiAr c3RhdGljIGludCByZXNldF9lbmdpbmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ PiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGVuZ2luZV9tYXNrLAo+ PiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHJldHJ5KQo+PiA+PiAr ewo+PiA+PiArICAgICAgIGlmIChJTlRFTF9HRU4oaTkxNSkgPj0gMTEpCj4+ID4+ICsgICAgICAg ICAgICAgICByZXR1cm4gZ2VuMTFfcmVzZXRfZW5naW5lcyhpOTE1LCBlbmdpbmVfbWFzayk7Cj4+ ID4+ICsgICAgICAgZWxzZQo+PiA+PiArICAgICAgICAgICAgICAgcmV0dXJuIGdlbjZfcmVzZXRf ZW5naW5lcyhpOTE1LCBlbmdpbmVfbWFzaywgcmV0cnkpOwo+PiA+PiArfQo+PiA+PiArCj4+ID4+ ICtzdGF0aWMgaW50IGdlbjhfcHJlcGFyZV9lbmdpbmVfZm9yX3Jlc2V0KHN0cnVjdCBpbnRlbF9l bmdpbmVfY3MgKmVuZ2luZSwKPj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB1bnNpZ25lZCBpbnQgcmV0cnkpCj4+ID4+ICt7Cj4+ID4+ICsgICAgICAgY29uc3Qg Ym9vbCBmb3JjZV9yZXNldF9vbl9ub25fcmVhZHkgPSByZXRyeSA+PSAxOwo+PiA+PiArICAgICAg IGludCByZXQ7Cj4+ID4+ICsKPj4gPj4gKyAgICAgICByZXQgPSBnZW44X3Jlc2V0X2VuZ2luZV9z dGFydChlbmdpbmUpOwo+PiA+PiArCj4+ID4+ICsgICAgICAgaWYgKHJldCAmJiBmb3JjZV9yZXNl dF9vbl9ub25fcmVhZHkpIHsKPj4gPj4gKyAgICAgICAgICAgICAgIC8qCj4+ID4+ICsgICAgICAg ICAgICAgICAgKiBUcnkgdG8gdW5ibG9jayBhIHNpbmdsZSBub24tcmVhZHkgZW5naW5lIGJ5IHJp c2tpbmcKPj4gPj4gKyAgICAgICAgICAgICAgICAqIGNvbnRleHQgY29ycnVwdGlvbi4KPj4gPj4g KyAgICAgICAgICAgICAgICAqLwo+PiA+PiArICAgICAgICAgICAgICAgcmV0ID0gcmVzZXRfZW5n aW5lcyhlbmdpbmUtPmk5MTUsCj4+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGludGVsX2VuZ2luZV9mbGFnKGVuZ2luZSksCj4+ID4+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJldHJ5KTsKPj4gPj4gKyAgICAgICAgICAgICAgIGlmICghcmV0KQo+ PiA+PiArICAgICAgICAgICAgICAgICAgICAgICByZXQgPSBnZW44X3Jlc2V0X2VuZ2luZV9zdGFy dChlbmdpbmUpOwo+PiA+PiArCj4+ID4+ICsgICAgICAgICAgICAgICBEUk1fRVJST1IoIiVzOiBy ZXNldCByZXF1ZXN0IHRpbWVvdXQsIGZvcmNpbmcgcmVzZXQgKCVkKVxuIiwKPj4gPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICBlbmdpbmUtPm5hbWUsIHJldCk7Cj4+ID4KPj4gPiBUaGlzIGxv b2tzIGR1YmlvdXMgbm93IDspCj4+ID4KPj4gPiBBZnRlciB0aGUgZm9yY2UgeW91IHRoZW4gZG8g YSByZXNldCBpbiB0aGUgY2FsbGVyLiBUd2ljZSB0aGUgcmVzZXQgZm9yCj4+ID4gdHdpY2UgdGhl IHVucHJlcGFyZWRuZXNzLgo+PiAKPj4gSXQgaXMgaW50ZW50aW9uYWwuIEZpcnN0IHdlIG1ha2Ug dGhlIGVuZ2luZSB1bnN0dWNrIGFuZCB0aGVuIGRvCj4+IGEgZnVsbCBjeWNsZSB3aXRoIHJlYWR5 IHRvIHJlc2V0IGludm9sdmVkLiBJIGRvbid0IGtub3cgaWYKPj4gaXQgcmVhbGx5IG1hdHRlcnMg dGhvLiBJdCBjb3VsZCBiZSB0aGF0IHRoZSBlbmdpbmUgaXMgYWxyZWFkeQo+PiBpbiBwcmlzdGlu ZSBjb25kaXRpb24gYWZ0ZXIgZmlyc3QuCj4KPiBMb29rcyBleHRyZW1lbHkgd2VpcmQgd2F5IG9m IGdvaW5nIGFib3V0IGl0LiBJZiB5b3Ugd2FudCB0byBkbyBhIGRvdWJsZQo+IHJlc2V0IGFmdGVy IHRoZSBmaXJzdCB0cnkgZmFpbHMsIHRyeQoKVGhlIGNydXggaXM6IGZhaWxpbmcgdG8gcmVzZXQg b3IgZmFpbGluZyB0byBwcmVwYXJpbmcgdG8gcmVzZXQuCkl0IGlzIHRoZSByZWFkeSBmb3IgcmVz ZXQgZGFuY2Ugbm90IHdvcmtpbmcgdGhhdCB3ZSBhcmUgdHJ5aW5nIHRvCmJ5IGRvaW5nIGV4dHJh IHBlciBlbmdpbmUgcmVzZXQuIFNvIHRyeWluZyBpbiB0aGUgaGlnaGVyIGxldmVyLAphZ2FpbiB3 aXRoIHRoZSBzYW1lIHByZWNvbmRpdGlvbnMgd291bGQgbm90IGhlbHAuCgotTWlrYQoKPgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMKPiBpbmRleCA0ZTU4MjYwNDVjYmYuLjZmZTEzN2Q3ZDQ1 NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jlc2V0LmMKPiBAQCAtNDUwLDYgKzQ1MCw4IEBA IGludCBpbnRlbF9ncHVfcmVzZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsIHVuc2ln bmVkIGludCBlbmdpbmVfbWFzaykKPiAgICAgICAgICAgICAgICAgICAgICAgICBHRU1fVFJBQ0Uo ImVuZ2luZV9tYXNrPSV4XG4iLCBlbmdpbmVfbWFzayk7Cj4gICAgICAgICAgICAgICAgICAgICAg ICAgcHJlZW1wdF9kaXNhYmxlKCk7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0ID0gcmVz ZXQoaTkxNSwgZW5naW5lX21hc2spOwo+ICsgICAgICAgICAgICAgICAgICAgICAgIGlmIChyZXRy eSA+IDAgJiYgIXJldCkgLyogRG91YmxlIGNoZWNrIHJlc2V0IHdvcmtlZCAqLwo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcmV0ID0gcmVzZXQoaTkxNSwgZW5naW5lX21hc2spOwo+ ICAgICAgICAgICAgICAgICAgICAgICAgIHByZWVtcHRfZW5hYmxlKCk7Cj4gICAgICAgICAgICAg ICAgIH0KPiAgICAgICAgICAgICAgICAgaWYgKHJldCAhPSAtRVRJTUVET1VUIHx8IGVuZ2luZV9t YXNrICE9IEFMTF9FTkdJTkVTKQo+Cj4gYXMgYSBzZXBhcmF0ZSBwYXRjaC4KPgo+IFAuUy4geW91 IHJlYWxseSBuZWVkIHRvIHJldmlldyB0aGUgaTkxNV9yZXNldC5jIHBhdGNoIDspCj4gLUNocmlz Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=