From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fo7Il-0007Nc-04 for ath10k@lists.infradead.org; Fri, 10 Aug 2018 13:18:01 +0000 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: RE: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips In-Reply-To: References: <1533724802-30944-1-git-send-email-wgong@codeaurora.org> <1533724802-30944-3-git-send-email-wgong@codeaurora.org> <87sh3pdtpg.fsf@toke.dk> Date: Fri, 10 Aug 2018 15:17:35 +0200 Message-ID: <87mutue4y8.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong , Wen Gong , "ath10k@lists.infradead.org" , "johannes@sipsolutions.net" Cc: "linux-wireless@vger.kernel.org" V2VuIEdvbmcgPHdnb25nQHF0aS5xdWFsY29tbS5jb20+IHdyaXRlczoKCj4+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IGF0aDEwayA8YXRoMTBrLWJvdW5jZXNAbGlzdHMuaW5m cmFkZWFkLm9yZz4gT24gQmVoYWxmIE9mIFRva2UKPj4gSMO4aWxhbmQtSsO4cmdlbnNlbgo+PiBT ZW50OiBXZWRuZXNkYXksIEF1Z3VzdCA4LCAyMDE4IDY6NDQgUE0KPj4gVG86IFdlbiBHb25nIDx3 Z29uZ0Bjb2RlYXVyb3JhLm9yZz47IGF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnOwo+PiBqb2hh bm5lc0BzaXBzb2x1dGlvbnMubmV0Cj4+IENjOiBsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5v cmcKPj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAyLzJdIGF0aDEwazogU2V0IHNrX3BhY2luZ19z aGlmdCB0byA2IGZvciAxMUFDIFdpRmkKPj4gY2hpcHMKPj4gCj4+IFdlbiBHb25nIDx3Z29uZ0Bj b2RlYXVyb3JhLm9yZz4gd3JpdGVzOgo+PiAKPj4gPiBVcHN0cmVhbSBrZXJuZWwgaGFzIGFuIGlu dGVyZmFjZSB0byBoZWxwIGFkanVzdCBza19wYWNpbmdfc2hpZnQgdG8KPj4gPiBoZWxwIGltcHJv dmUgVENQIFVMIHRocm91Z2hwdXQuCj4+ID4gVGhlIHNrX3BhY2luZ19zaGlmdCBpcyA4IGluIG1h YzgwMjExLCB0aGlzIGlzIGJhc2VkIG9uIHRlc3Qgd2l0aCAxMU4KPj4gPiBXaUZpIGNoaXBzIHdp dGggYXRoOWsuIEZvciBRQ0E2MTc0L1FDQTkzNzcgUENJIDExQUMgY2hpcHMsIHRoZSAxMUFDCj4+ ID4gVkhUODAgVENQIFVMIHRocm91Z2hwdXQgdGVzdGluZyByZXN1bHQgc2hvd3MgNiBpcyB0aGUg b3B0aW1hbC4KPj4gPiBPdmVyd3JpdGUgdGhlIHNrX3BhY2luZ19zaGlmdCB0byA2IGluIGF0aDEw ayBkcml2ZXIgZm9yIFFDQTYxNzQvOTM3NyBQQ0kuCj4+ID4KPj4gPiBUZXN0ZWQgd2l0aCBRQ0E2 MTc0IFBDSSB3aXRoIGZpcm13YXJlCj4+ID4gV0xBTi5STS40LjQuMS0wMDEwOS1RQ0FSTVNXUFot MSwgYnV0IHRoaXMgd2lsbCBhbHNvIGFmZmVjdCBRQ0E5Mzc3Cj4+IFBDSS4KPj4gPiBJdCdzIG5v dCBhIHJlZ3Jlc3Npb24gd2l0aCBuZXcgZmlybXdhcmUgcmVsZWFzZXMuCj4+ID4KPj4gPiBUaGVy ZSBoYXZlIDIgdGVzdCByZXN1bHQgb2YgZGlmZmVyZW50IHNldHRpbmdzOgo+PiA+Cj4+ID4gQVJN IENQVSBiYXNlZCBkZXZpY2Ugd2l0aCBRQ0E2MTc0QSBQQ0kgd2l0aCBkaWZmZXJlbnQKPj4gPiBz a19wYWNpbmdfc2hpZnQ6Cj4+ID4KPj4gPiAgc2tfcGFjaW5nX3NoaWZ0ICB0aHJvdWdocHV0KE1i cHMpICAgICAgICAgICAgIENQVSB1dGlsaXphdGlvbgo+PiA+ICAgICAgICAgIDYgICAgICAgICAg ICA1MDAoLVA1KSAgICAgIH43NSUgaWRsZSwgRm9jdXMgb24gQ1BVMTogfjE0JWlkbGUKPj4gPiAg ICAgICAgICA3ICAgICAgICAgICAgNDU0KC1QNSkgICAgICB+ODAlIGlkbGUsIEZvY3VzIG9uIENQ VTE6IH40JWlkbGUKPj4gPiAgICAgICAgICA4ICAgICAgICAgICAgICAgMjg4ICAgICAgICB+OTAl IGlkbGUsIEZvY3VzIG9uIENQVTE6IH4zNSVpZGxlCj4+ID4gICAgICAgICAgOSAgICAgICAgICAg ICAgfjIwMCAgICAgICAgfjkyJSBpZGxlLCBGb2N1cyBvbiBDUFUxOiB+NTAlaWRsZQo+PiA+Cj4+ ID4gNUcgVENQIFVMIFZUSDgwIG9uIFg4NiBwbGF0Zm9ybSB3aXRoIFFDQTYxNzRBIFBDSSB3aXRo Cj4+ID4gc2tfcGFja2luZ19zaGlmdCBzZXQgdG8gNjoKPj4gPgo+PiA+ICAgdGNwX2xpbWl0X291 dHB1dF9ieXRlcyAgICAgICAgICAgIHRocm91Z2hwdXQoTWJwcykKPj4gPiAgZGVmYXVsdCgyNjIx NDQpKzEgU3RyZWFtICAgICAgICAgICAgICAgICAzMzYKPj4gPiAgZGVmYXVsdCgyNjIxNDQpKzIg U3RyZWFtcyAgICAgICAgICAgICAgICA1NTgKPj4gPiAgZGVmYXVsdCgyNjIxNDQpKzMgU3RyZWFt cyAgICAgICAgICAgICAgICA1ODQKPj4gPiAgZGVmYXVsdCgyNjIxNDQpKzQgU3RyZWFtcyAgICAg ICAgICAgICAgICA2MDIKPj4gPiAgZGVmYXVsdCgyNjIxNDQpKzUgU3RyZWFtcyAgICAgICAgICAg ICAgICA1OTgKPj4gPiAgY2hhbmdlZCgyNjIxNDQwKSsxIFN0cmVhbSAgICAgICAgICAgICAgICA1 OTgKPj4gPiAgY2hhbmdlZCgyNjIxNDQwKSsyIFN0cmVhbXMgICAgICAgICAgICAgICA2MDEKPj4g Cj4+IFlvdSBzdGlsbCBoYXZlbid0IHByb3ZpZGVkIGFueSBsYXRlbmN5IG51bWJlcnMgZm9yIHRo ZXNlIHRlc3RzLCB3aGljaCBtYWtlcwo+PiBpdCBpbXBvc3NpYmxlIHRvIHZlcmlmeSB0aGF0IHNl dHRpbmcgc2tfcGFjaW5nX3NoaWZ0IHRvIDYgaXMgdGhlIHJpZ2h0IHRyYWRlb2ZmLgo+PiAKPj4g QXMgSSBzYWlkIGJlZm9yZSwgZnJvbSB5b3VyIG51bWJlcnMgSSBzdXNwZWN0IHRoZSByaWdodCBz ZXR0aW5nIGlzIGFjdHVhbGx5IDcsCj4+IHdoaWNoIHdvdWxkIGJlIDEwLTIwbXMgbGVzcyBsYXRl bmN5IHVuZGVyIGxvYWQ7IHdheSBtb3JlIGltcG9ydGFudCB0aGFuCj4+IH41MCBNYnBzLi4uCj4+ IAo+IEhpIFRva2UsCj4gQ291bGQgeW91IGdpdmUgdGhlIGNvbW1hbmQgbGluZSBmb3IgdGhlIGxh dGVuY3kgdGVzdD8KPiBodHRwczovL2ZsZW50Lm9yZy9pbnRyby5odG1sI3F1aWNrLXN0YXJ0Cj4g SSB1c2VkIHRoZSBjb21tYW5kIGJ1dCB0ZXN0IGZhaWxlZDoKPiBmbGVudCB0Y3BfZG93bmxvYWQg LXAgMSAtbCA2MCAtSCAxOTIuMTY4LjEuNSAtdCB0ZXh0LXRvLWJlLWluY2x1ZGVkLWluLXBsb3Qg LW8gZmlsZTEucG5nCj4gZXJyb3IgbG9hZGluZyBwbG90dGVyOiB1bmFibGUgdG8gZmluZCBwbG90 IGNvbmZpZ3VyYXRpb24gIjEiCgpUcnkgc29tZXRoaW5nIGxpa2U6CgoKZmxlbnQgLUggMTkyLjE2 OC4xLjUgLXQgInNrX3BhY2luZ19zaGlmdCA3IiB0Y3BfbnVwIC0tdGVzdC1wYXJhbWV0ZXIgdXBs b2FkX3N0cmVhbXM9MQoKClRoaXMgd2lsbCBub3RlIHRoZSB2YWx1ZSBvZiBza19wYWNpbmdfc2hp ZnQgeW91IGFyZSB0ZXN0aW5nIGluIHRoZSBkYXRhCmZpbGUgKHNvIGNoYW5nZSB0aGF0IGFzIGFw cHJvcHJpYXRlKSwgYW5kIHlvdSBjYW4gdmFyeSB0aGUgbnVtYmVyIG9mIFRDUApzdHJlYW1zIGJ5 IGNoYW5naW5nIHRoZSB1cGxvYWRfc3RyZWFtcyBwYXJhbWV0ZXIuCgpOb3RlIHRoYXQgaW4gdGhp cyBjYXNlIEknbSBhc3N1bWluZyB5b3UgYXJlIHJ1bm5pbmcgRmxlbnQgb24gdGhlIGRldmljZQp3 aXRoIHRoZSBrZXJuZWwgeW91IGFyZSB0cnlpbmcgdG8gdGVzdCwgc28geW91IHdhbnQgYSBUQ1Ag dHJhbnNmZXIgZ29pbmcKKmZyb20qIHRoZSBkZXZpY2UuIElmIG5vdCwgY2hhbmdlICJ0Y3BfbnVw IiB0byAidGNwX25kb3duIiBhbmQKInVwbG9hZF9zdHJlYW1zIiB0byAiZG93bmxvYWRfc3RyZWFt cyIuIFVwbG9hZCBpcyBuZXRwZXJmIFRDUF9TVFJFQU0KdGVzdCwgYW5kIGRvd25sb2FkIGlzIFRD UF9NQUVSVFMuCgpXaGVuIHJ1bm5pbmcgdGhlIGFib3ZlIGNvbW1hbmQgeW91J2xsIGdldCBhIHN1 bW1hcnkgb3V0cHV0IG9uIHRoZQp0ZXJtaW5hbCB0aGF0IHlvdSBjYW4gcGFzdGUgb24gdGhlIGxp c3Q7IGFuZCBhbHNvIGEgZGF0YSBmaWxlIHRvIHBsb3QKdGhpbmdzIGZvcm0uIEZvciBpbnN0YW5j ZSwgeW91IGNhbiBkbyBzb21ldGhpbmcgbGlrZSAnZmxlbnQgLXAgcGluZ19jZGYKKi5mbGVudC5n eicgdG8gZ2V0IGEgQ0RGIHBsb3Qgb2YgYWxsIHlvdXIgdGVzdCByZXN1bHRzIGFmdGVyd2FyZHMu IFlvdQphcmUgYWxzbyB2ZXJ5IHdlbGNvbWUgdG8gc2VuZCBtZSB0aGUgLmZsZW50Lmd6IGRhdGEg ZmlsZXMgYW5kIEknbGwgdGFrZQphIGxvb2sgdG8gbWFrZSBzdXJlIGV2ZXJ5dGhpbmcgbG9va3Mg cmVhc29uYWJsZSA6KQoKLVRva2UKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVhZC5v cmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.toke.dk ([52.28.52.200]:34691 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727534AbeHJPrf (ORCPT ); Fri, 10 Aug 2018 11:47:35 -0400 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Wen Gong , Wen Gong , "ath10k\@lists.infradead.org" , "johannes\@sipsolutions.net" Cc: "linux-wireless\@vger.kernel.org" Subject: RE: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC WiFi chips In-Reply-To: References: <1533724802-30944-1-git-send-email-wgong@codeaurora.org> <1533724802-30944-3-git-send-email-wgong@codeaurora.org> <87sh3pdtpg.fsf@toke.dk> Date: Fri, 10 Aug 2018 15:17:35 +0200 Message-ID: <87mutue4y8.fsf@toke.dk> (sfid-20180810_151750_374044_F981C74A) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Wen Gong writes: >> -----Original Message----- >> From: ath10k On Behalf Of Toke >> H=C3=B8iland-J=C3=B8rgensen >> Sent: Wednesday, August 8, 2018 6:44 PM >> To: Wen Gong ; ath10k@lists.infradead.org; >> johannes@sipsolutions.net >> Cc: linux-wireless@vger.kernel.org >> Subject: Re: [PATCH v2 2/2] ath10k: Set sk_pacing_shift to 6 for 11AC Wi= Fi >> chips >>=20 >> Wen Gong writes: >>=20 >> > Upstream kernel has an interface to help adjust sk_pacing_shift to >> > help improve TCP UL throughput. >> > The sk_pacing_shift is 8 in mac80211, this is based on test with 11N >> > WiFi chips with ath9k. For QCA6174/QCA9377 PCI 11AC chips, the 11AC >> > VHT80 TCP UL throughput testing result shows 6 is the optimal. >> > Overwrite the sk_pacing_shift to 6 in ath10k driver for QCA6174/9377 P= CI. >> > >> > Tested with QCA6174 PCI with firmware >> > WLAN.RM.4.4.1-00109-QCARMSWPZ-1, but this will also affect QCA9377 >> PCI. >> > It's not a regression with new firmware releases. >> > >> > There have 2 test result of different settings: >> > >> > ARM CPU based device with QCA6174A PCI with different >> > sk_pacing_shift: >> > >> > sk_pacing_shift throughput(Mbps) CPU utilization >> > 6 500(-P5) ~75% idle, Focus on CPU1: ~14%idle >> > 7 454(-P5) ~80% idle, Focus on CPU1: ~4%idle >> > 8 288 ~90% idle, Focus on CPU1: ~35%idle >> > 9 ~200 ~92% idle, Focus on CPU1: ~50%idle >> > >> > 5G TCP UL VTH80 on X86 platform with QCA6174A PCI with >> > sk_packing_shift set to 6: >> > >> > tcp_limit_output_bytes throughput(Mbps) >> > default(262144)+1 Stream 336 >> > default(262144)+2 Streams 558 >> > default(262144)+3 Streams 584 >> > default(262144)+4 Streams 602 >> > default(262144)+5 Streams 598 >> > changed(2621440)+1 Stream 598 >> > changed(2621440)+2 Streams 601 >>=20 >> You still haven't provided any latency numbers for these tests, which ma= kes >> it impossible to verify that setting sk_pacing_shift to 6 is the right t= radeoff. >>=20 >> As I said before, from your numbers I suspect the right setting is actua= lly 7, >> which would be 10-20ms less latency under load; way more important than >> ~50 Mbps... >>=20 > Hi Toke, > Could you give the command line for the latency test? > https://flent.org/intro.html#quick-start > I used the command but test failed: > flent tcp_download -p 1 -l 60 -H 192.168.1.5 -t text-to-be-included-in-pl= ot -o file1.png > error loading plotter: unable to find plot configuration "1" Try something like: flent -H 192.168.1.5 -t "sk_pacing_shift 7" tcp_nup --test-parameter upload= _streams=3D1 This will note the value of sk_pacing_shift you are testing in the data file (so change that as appropriate), and you can vary the number of TCP streams by changing the upload_streams parameter. Note that in this case I'm assuming you are running Flent on the device with the kernel you are trying to test, so you want a TCP transfer going *from* the device. If not, change "tcp_nup" to "tcp_ndown" and "upload_streams" to "download_streams". Upload is netperf TCP_STREAM test, and download is TCP_MAERTS. When running the above command you'll get a summary output on the terminal that you can paste on the list; and also a data file to plot things form. For instance, you can do something like 'flent -p ping_cdf *.flent.gz' to get a CDF plot of all your test results afterwards. You are also very welcome to send me the .flent.gz data files and I'll take a look to make sure everything looks reasonable :) -Toke