From mboxrd@z Thu Jan  1 00:00:00 1970
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Subject: Re: [PATCH bpf-next v2 2/2] samples/bpf: Add xdp_sample_pkts example
Date: Tue, 05 Jun 2018 11:20:54 +0200
Message-ID: <87muw9fv2h.fsf@toke.dk>
References: <152813003609.3465.618891361534945522.stgit@alrua-kau> <152813003614.3465.11049830599815911223.stgit@alrua-kau> <20180604153205.72678576@cakuba.netronome.com> <1ef5fdfd-3225-89e2-c6b5-d3fe2573d655@iogearbox.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: netdev@vger.kernel.org
To: Daniel Borkmann <daniel@iogearbox.net>,
        Jakub Kicinski <kubakici@wp.pl>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.toke.dk ([52.28.52.200]:54549 "EHLO mail.toke.dk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751497AbeFEJUs (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 5 Jun 2018 05:20:48 -0400
In-Reply-To: <1ef5fdfd-3225-89e2-c6b5-d3fe2573d655@iogearbox.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Daniel Borkmann <daniel@iogearbox.net> writes:

> On 06/05/2018 12:32 AM, Jakub Kicinski wrote:
>> On Mon, 04 Jun 2018 18:33:56 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wro=
te:
>>> +	if (load_bpf_file(filename)) {
>>=20
>> Would you mind using libbpf instead of bpf_load.o?  I converted some
>> samples in be5bca44aa6b ("samples: bpf: convert some XDP samples from
>> bpf_load to libbpf"), it's pretty straight forward.  Maybe we can kill
>> bpf_load.o one day :)
>
> Agreed, we should only be using libbpf going forward.

Right, I'll rework to load using libbpf instead.