From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2] drm/i915/vma: Move the bind_count vs pin_count assertion to a helper Date: Tue, 05 Jun 2018 13:22:17 +0300 Message-ID: <87muw9pm7a.fsf@gaia.fi.intel.com> References: <20180605093420.30594-1-chris@chris-wilson.co.uk> <20180605094107.31367-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 024FF6E0B9 for ; Tue, 5 Jun 2018 10:22:39 +0000 (UTC) In-Reply-To: <20180605094107.31367-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gVG8gc3Bh cmUgb3Vyc2VsdmVzIGEgbG9uZyBsaW5lIGxhdGVyLCByZWZhY3RvciB0aGUgcmVwZWF0ZWQgY2hl Y2sgb2YKPiBiaW5kX2NvdW50IHZzIHBpbl9jb3VudCB0byBhIGhlbHBlci4KPgo+IHYyOiBGaXgg dXAgdGhlIGNvbW1lbnRhcnkhCgpNYXRjaGVzIHRoZSBjb2RlIG5vdywgZGlkbid0IG5vdGljZSBv biB0aGUgZmlyc3Qgcm91bmQgKmJsdXNoKgoKUmV2aWV3ZWQtYnk6IE1pa2EgS3VvcHBhbGEgPG1p a2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgoKPgo+IFN1Z2dlc3RlZC1ieTogSm9vbmFzIExh aHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6 IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBKb29uYXMgTGFo dGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1pa2EgS3VvcHBh bGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBNYXR0aGV3IEF1bGQgPG1h dHRoZXcud2lsbGlhbS5hdWxkQGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV92bWEuYyB8IDE2ICsrKysrKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE0 IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV92bWEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdm1hLmMK PiBpbmRleCA5MzI0ZDQ3NmUwYTcuLjEwYmY2NTRjZDAyMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3ZtYS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV92bWEuYwo+IEBAIC00NTksNiArNDU5LDE4IEBAIGJvb2wgaTkxNV9nZW1fdmFsaWRfZ3R0X3Nw YWNlKHN0cnVjdCBpOTE1X3ZtYSAqdm1hLCB1bnNpZ25lZCBsb25nIGNhY2hlX2xldmVsKQo+ICAJ cmV0dXJuIHRydWU7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGFzc2VydF9iaW5kX2NvdW50KGNv bnN0IHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCj4gK3sKPiArCS8qCj4gKwkgKiBD b21iaW5lIHRoZSBhc3NlcnRpb24gdGhhdCB0aGUgb2JqZWN0IGlzIGJvdW5kIGFuZCB0aGF0IHdl IGhhdmUKPiArCSAqIHBpbm5lZCBpdHMgcGFnZXMuIEJ1dCB3ZSBzaG91bGQgbmV2ZXIgaGF2ZSBi b3VuZCB0aGUgb2JqZWN0Cj4gKwkgKiBtb3JlIHRoYW4gd2UgaGF2ZSBwaW5uZWQgaXRzIHBhZ2Vz LiAoRm9yIGNvbXBsZXRlIGFjY3VyYWN5LCB3ZQo+ICsJICogYXNzdW1lIHRoYXQgbm8gZWxzZSBp cyBwaW5uaW5nIHRoZSBwYWdlcywgYnV0IGFzIGEgcm91Z2ggYXNzZXJ0aW9uCj4gKwkgKiB0aGF0 IHdlIHdpbGwgbm90IHJ1biBpbnRvIHByb2JsZW1zIGxhdGVyLCB0aGlzIHdpbGwgZG8hKQo+ICsJ ICovCj4gKwlHRU1fQlVHX09OKGF0b21pY19yZWFkKCZvYmotPm1tLnBhZ2VzX3Bpbl9jb3VudCkg PCBvYmotPmJpbmRfY291bnQpOwo+ICt9Cj4gKwo+ICAvKioKPiAgICogaTkxNV92bWFfaW5zZXJ0 IC0gZmluZHMgYSBzbG90IGZvciB0aGUgdm1hIGluIGl0cyBhZGRyZXNzIHNwYWNlCj4gICAqIEB2 bWE6IHRoZSB2bWEKPiBAQCAtNTk1LDcgKzYwNyw3IEBAIGk5MTVfdm1hX2luc2VydChzdHJ1Y3Qg aTkxNV92bWEgKnZtYSwgdTY0IHNpemUsIHU2NCBhbGlnbm1lbnQsIHU2NCBmbGFncykKPiAgCW9i ai0+YmluZF9jb3VudCsrOwo+ICAJc3Bpbl91bmxvY2soJmRldl9wcml2LT5tbS5vYmpfbG9jayk7 Cj4gIAo+IC0JR0VNX0JVR19PTihhdG9taWNfcmVhZCgmb2JqLT5tbS5wYWdlc19waW5fY291bnQp IDwgb2JqLT5iaW5kX2NvdW50KTsKPiArCWFzc2VydF9iaW5kX2NvdW50KG9iaik7Cj4gIAo+ICAJ cmV0dXJuIDA7Cj4gIAo+IEBAIC02MzMsNyArNjQ1LDcgQEAgaTkxNV92bWFfcmVtb3ZlKHN0cnVj dCBpOTE1X3ZtYSAqdm1hKQo+ICAJICogcmVhcGVkIGJ5IHRoZSBzaHJpbmtlci4KPiAgCSAqLwo+ ICAJaTkxNV9nZW1fb2JqZWN0X3VucGluX3BhZ2VzKG9iaik7Cj4gLQlHRU1fQlVHX09OKGF0b21p Y19yZWFkKCZvYmotPm1tLnBhZ2VzX3Bpbl9jb3VudCkgPCBvYmotPmJpbmRfY291bnQpOwo+ICsJ YXNzZXJ0X2JpbmRfY291bnQob2JqKTsKPiAgfQo+ICAKPiAgaW50IF9faTkxNV92bWFfZG9fcGlu KHN0cnVjdCBpOTE1X3ZtYSAqdm1hLAo+IC0tIAo+IDIuMTcuMQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK