From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present Date: Tue, 08 May 2018 12:33:57 +0300 Message-ID: <87muxa5w56.fsf@intel.com> References: <20180504141349.5878-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4C17D6E64F for ; Tue, 8 May 2018 09:31:20 +0000 (UTC) In-Reply-To: <20180504141349.5878-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org Cc: Ondrej Zary List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAwNCBNYXkgMjAxOCwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBWQlQgc2VlbXMgdG8gaGF2ZSBzb21lIGJpdHMgdG8gdGVsbCB1 cyB3aGV0aGVyIHRoZSBpbnRlcm5hbCBMVkRTIHBvcnQKPiBoYXMgc29tZXRoaW5nIGhvb2tlZCB1 cC4gSW4gdGhlb3J5IG9uZSBtaWdodCBleHBlY3QgdGhlIFZCVCB0byBub3QgaGF2ZQo+IGEgY2hp bGQgZGV2aWNlIGZvciB0aGUgTFZEUyBwb3J0IGlmIHRoZXJlJ3Mgbm8gcGFuZWwgaG9va2VkIHVw LCBidXQKPiBpbiBwcmFjdGljZSBtYW55IFZCVHMgc3RpbGwgYWRkIHRoZSBjaGlsZCBkZXZpY2Uu IFRoZSAiTFZEUyBjb25maWciIGJpdHMKPiBzZWVtIG1vcmUgcmVsaWFibGUgdGhvdWdoLCBzbyBs ZXQncyBjaGVjayB0aG9zZS4KPgo+IFNvIGZhciB3ZSd2ZSB1c2VkIHRoZSAiTFZEUyBjb25maWci IGJpdHMgdG8gY2hlY2sgZm9yIGVEUCBzdXBwb3J0IG9uCj4gSUxLKywgYW5kIGRpc2FibGUgdGhl IGludGVybmFsIExWRFMgd2hlbiB0aGUgdmFsdWUgaXMgMy4gVGhhdCB2YWx1ZQo+IGlzIGFjdHVh bGx5IGRvY3VtZW50ZWQgYXMgIkJvdGggaW50ZXJuYWwgTFZEUyBhbmQgU0RWTyBMVkRTIiwgYnV0 IGluCj4gcHJhY3RpY2UgaXQgbG9va3MgdG8gbWVhbiAiZURQIiBvbiBhbGwgdGhlIGlsaysgVkJU cyBJJ3ZlIHNlZW4uIFNvIGxldCdzCj4ga2VlcCB0aGF0IGludGVycHJldGF0aW9uLCBidXQgZm9y IHByZS1JTEsgd2Ugd2lsbCBjb25zaWRlciB0aGUgdmFsdWUKPiAzIHRvIGFsc28gaW5kaWNhdGUg dGhlIHByZXNlbmNlIG9mIHRoZSBpbnRlcm5hbCBMVkRTLgo+Cj4gQ3VycmVudGx5IHdlIGhhdmUg MjUgRE1JIG1hdGNoZXMgZm9yIHRoZSAibm8gaW50ZXJuYWwgTFZEUyIgcXVpcmsuIEluIGFuCj4g ZWZmb3J0IHRvIHJlZHVjZSB0aGF0IGxldCdzIHRvc3MgaW4gYSBXQVJOIHdoZW4gdGhlIERNSSBt YXRjaCBhbmQgVkJUCj4gYm90aCB0ZWxsIHVzIHRoYXQgdGhlIGludGVybmFsIExWRFMgaXMgbm90 IHByZXNlbnQuIFRoZSBob3BlIGlzIHRoYXQKPiBwZW9wbGUgd2lsbCByZXBvcnQgYSBidWcsIGFu ZCB0aGVuIHdlIGNhbiBqdXN0IG51a2UgdGhlIGNvcnJlc3BvbmRpbmcKPiBlbnRyeSBmcm9tIHRo ZSBETUkgcXVpcmsgbGlzdC4gQ3JlZGl0cyB0byBKYW5pIGZvciB0aGlzIGlkZWEuCj4KPiBDYzog SmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KPiBDYzogT25kcmVqIFphcnkgPGxp bnV4QHJhaW5ib3ctc29mdHdhcmUub3JnPgo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRl c2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU0NjgKPiBSZWZlcmVuY2VzOiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9pbnRlbC1nZngvMjAxOC1NYXJjaC8xNTg0MDgu aHRtbAo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAg ICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyAgICAgfCAyMCAr KysrKysrKysrKysrKysrKystLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9sdmRzLmMg ICAgIHwgMTQgKysrKysrKysrLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdmJ0 X2RlZnMuaCB8ICAxICsKPiAgNCBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCA3IGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggMDRlMjc4MDZlNTgx Li5mZmQwYzhkMzMzMzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMTA1Miw2 ICsxMDUyLDcgQEAgc3RydWN0IGludGVsX3ZidF9kYXRhIHsKPiAgCXVuc2lnbmVkIGludCBsdmRz X3ZidDoxOwo+ICAJdW5zaWduZWQgaW50IGludF9jcnRfc3VwcG9ydDoxOwo+ICAJdW5zaWduZWQg aW50IGx2ZHNfdXNlX3NzYzoxOwo+ICsJdW5zaWduZWQgaW50IGludF9sdmRzX3N1cHBvcnQ6MTsK PiAgCXVuc2lnbmVkIGludCBkaXNwbGF5X2Nsb2NrX21vZGU6MTsKPiAgCXVuc2lnbmVkIGludCBm ZGlfcnhfcG9sYXJpdHlfaW52ZXJ0ZWQ6MTsKPiAgCXVuc2lnbmVkIGludCBwYW5lbF90eXBlOjQ7 Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IGluZGV4IDcwMmQzZmFiOTdmYy4uZjc1NTQx YjExZjExIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IEBAIC01MTgsOCArNTE4 LDIxIEBAIHBhcnNlX2RyaXZlcl9mZWF0dXJlcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gIAlpZiAoIWRyaXZlcikKPiAgCQlyZXR1cm47Cj4gIAoKSSBsaWtlIHRoZSBjaGFu Z2VzIGluIGludGVsX2x2ZHNfaW5pdCgpLCBwYXJ0aWN1bGFybHkgdGhlIGZhY3QgdGhhdCB0aGUK ZURQIGNoZWNrIGlzIGFic3RyYWN0ZWQgYXdheSBmcm9tIHRoZXJlLiBCdXQgdGhlIHN0dWZmIGJl bG93IGlzIHJlYWxseQpzdWJ0bGUuIEknbGwgd2FsayB0aHJvdWdoIGl0IHdpdGggY29tbWVudGFy eS4KCj4gLQlpZiAoZHJpdmVyLT5sdmRzX2NvbmZpZyA9PSBCREJfRFJJVkVSX0ZFQVRVUkVfRURQ KQo+IC0JCWRldl9wcml2LT52YnQuZWRwLnN1cHBvcnQgPSAxOwo+ICsJaWYgKElOVEVMX0dFTihk ZXZfcHJpdikgPj0gNSkgewoKT2theSwgc28gdGhlIGVEUCBjaGVjayBpbiBpbnRlbF9sdmRzX2lu aXQoKSBpcyB3cmFwcGVkIGluCkhBU19QQ0hfU1BMSVQoKSwgYnV0IFZMVi9DSFYgZG9uJ3QgaGF2 ZSBMVkRTIHNvIHN3aXRjaGluZyB0byBhIGdlbiA1CmNoZWNrIGhlcmUgaXMgZmluZS4gV2UgYWxz byBvbmx5IGhhdmUgZURQIHNpbmNlIGdlbiA1LiBTbyBmYXIgc28gZ29vZC4KCj4gKwkJaWYgKGRy aXZlci0+bHZkc19jb25maWcgIT0gQkRCX0RSSVZFUl9GRUFUVVJFX0lOVF9MVkRTKQo+ICsJCQlk ZXZfcHJpdi0+dmJ0LmludF9sdmRzX3N1cHBvcnQgPSAwOwoKSGVyZSdzIHRoZSBjaGFuZ2UgZm9y IElCWC9DUFQgKHRoZSBvbmx5IGdlbiA1KyB0aGF0IGNhbiBoYXZlIExWRFMpLiBJdAp1c2VkIHRv IGJlIHRoYXQgdmFsdWUgMyBkaXNhYmxlZCBMVkRTLCBidXQgbm93IDAsIDIgYW5kIDMgZGlzYWJs ZQpMVkRTLiBJdCBzdGFuZHMgdG8gcmVhc29uIDAgYW5kIDIgZGlzYWJsZSBMVkRTLCBidXQgbG9v a2luZyBhdCB0aGUgc3BlYywKaXQgc2VlbXMgb2RkIHRoYXQgdmFsdWUgMyBkaXNhYmxlcyBMVkRT Li4uCgpTbyBmb3IgSUJYL0NQVCB3ZSBkaXNhYmxlIExWRFMgbW9yZSBwZXIgVkJULgoKPiArCj4g KwkJLyoKPiArCQkgKiBOb3RlIHRoYXQgdGhlIFZCVCBzcGVjIGRvZXNuJ3QgYWdyZWUgd2l0aCB0 aGlzCj4gKwkJICogaW50ZXJwcmV0YXRpb24sIGJ1dCByZWFsIHdvcmxkIFZCVHMgc2VlbSB0by4K PiArCQkgKi8KPiArCQlpZiAoZHJpdmVyLT5sdmRzX2NvbmZpZyA9PSBCREJfRFJJVkVSX0ZFQVRV UkVfRURQKQo+ICsJCQlkZXZfcHJpdi0+dmJ0LmVkcC5zdXBwb3J0ID0gMTsKCkluIGEgc3VycHJp c2UgdHdpc3QsIHRoaXMgaXMgbm93IHVzZWxlc3MuIFdlIGNvdWxkIHJlbW92ZSBpdCBhbHRvZ2V0 aGVyLAphcyBpdCB3YXMgb25seSBldmVyIHVzZWQgdG8gZGlzYWJsZSBMVkRTLiBBbmQgc29tZSBs aWtlbHkgdXNlbGVzcwpsb2dnaW5nLiBSZWFsbHkuCgpNYXliZSB0aGVuIHdlIHNob3VsZCB0aHJv dyBCREJfRFJJVkVSX0ZFQVRVUkVfRURQIG1hY3JvIG91dCBpbiBmYXZvciBvZgpCREJfRFJJVkVS X0ZFQVRVUkVfSU5UX1NEVk9fTFZEUyB0b28sIHRvIG1hdGNoIHRoZSBzcGVjLgoKPiArCX0gZWxz ZSB7Cj4gKwkJaWYgKGRyaXZlci0+bHZkc19jb25maWcgIT0gQkRCX0RSSVZFUl9GRUFUVVJFX0lO VF9MVkRTICYmCj4gKwkJICAgIGRyaXZlci0+bHZkc19jb25maWcgIT0gQkRCX0RSSVZFUl9GRUFU VVJFX0lOVF9TRFZPX0xWRFMpCj4gKwkJCWRldl9wcml2LT52YnQuaW50X2x2ZHNfc3VwcG9ydCA9 IDA7CgpGb3IgcHJlLWdlbjUgd2Ugc3RhcnQgbG9va2luZyBhdCBWQlQgZm9yIGNsdWVzLiBXZSBl bmFibGUgTFZEUyBmb3IKdmFsdWVzIDEgYW5kIDMsIGRpc2FibGUgb3RoZXJ3aXNlLiBUaGlzIG1h dGNoZXMgdGhlIHNwZWMgKHVubGlrZSBmb3IKZ2VuNSspLiBUaGlzIGlzIGxpa2VseSB0aGUgdXNl ZnVsIGNoYW5nZSBmb3IgdGhlIHJlZmVyZW5jZWQgYnVnLCBhbmQKbWFueSBvZiB0aGUgcXVpcmtz LgoKT3ZlcmFsbCBJIGxpa2UgdGhlIGRpcmVjdGlvbiBoZXJlLCB2ZXJ5IG11Y2gsIGJ1dCBhdCB0 aGUgc2FtZSB0aW1lIEknbQp3b25kZXJpbmcgaWYgd2Ugc2hvdWxkIHNwbGl0IHRoaXMgdXAgYSBi aXQganVzdCBmb3IgY2F1dGlvbi4gRmlyc3QgcGFydCwKYWxsIHRoZSBjaGFuZ2VzIGluIGludGVs X2x2ZHNfaW5pdCgpIHlvdSBoYXZlLCBhcyBpcywgYW5kIHRocm93aW5nCmVkcC5zdXBwb3J0IG91 dCwgYnV0IGtlZXBpbmcgdGhlIHNhbWUgbG9naWMgZm9yIExWRFMgdnMuIG5vIExWRFMuIFNlY29u ZApwYXJ0LCBhY3R1YWxseSBjaGFuZ2luZyB0aGUgbG9naWMgaGVyZSBmb3Igc2V0dGluZwppbnRf bHZkc19zdXBwb3J0LiBNaW5pbWl6ZXMgYW5kIGxvY2FsaXplcyB0aGUgbG9naWMgY2hhbmdpbmcg cGF0Y2ggaW4KY2FzZSB3ZSBuZWVkIHRvIHJldmVydCBpdC4KCkhvdyBkb2VzIHRoYXQgc291bmQ/ IFRvbyB3aW1weT8gOykKCkJSLApKYW5pLgoKPiArCX0KPiAgCj4gIAlEUk1fREVCVUdfS01TKCJE UlJTIFN0YXRlIEVuYWJsZWQ6JWRcbiIsIGRyaXZlci0+ZHJyc19lbmFibGVkKTsKPiAgCS8qCj4g QEAgLTE1MTIsNiArMTUyNSw5IEBAIGluaXRfdmJ0X2RlZmF1bHRzKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiAgCWRldl9wcml2LT52YnQuaW50X3R2X3N1cHBvcnQgPSAxOwo+ ICAJZGV2X3ByaXYtPnZidC5pbnRfY3J0X3N1cHBvcnQgPSAxOwo+ICAKPiArCS8qIGRyaXZlciBm ZWF0dXJlcyAqLwo+ICsJZGV2X3ByaXYtPnZidC5pbnRfbHZkc19zdXBwb3J0ID0gMTsKPiArCj4g IAkvKiBEZWZhdWx0IHRvIHVzaW5nIFNTQyAqLwo+ICAJZGV2X3ByaXYtPnZidC5sdmRzX3VzZV9z c2MgPSAxOwo+ICAJLyoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf bHZkcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jCj4gaW5kZXggZDM1ZDJk NTBmNTk1Li5mNjU5NmM1Y2U5NzMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfbHZkcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHZkcy5jCj4g QEAgLTk2Miw4ICs5NjIsMTYgQEAgdm9pZCBpbnRlbF9sdmRzX2luaXQoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCXJldHVybjsKPiAgCj4gIAkvKiBTa2lwIGluaXQgb24g bWFjaGluZXMgd2Uga25vdyBmYWxzZWx5IHJlcG9ydCBMVkRTICovCj4gLQlpZiAoZG1pX2NoZWNr X3N5c3RlbShpbnRlbF9ub19sdmRzKSkKPiArCWlmIChkbWlfY2hlY2tfc3lzdGVtKGludGVsX25v X2x2ZHMpKSB7Cj4gKwkJV0FSTighZGV2X3ByaXYtPnZidC5pbnRfbHZkc19zdXBwb3J0LAo+ICsJ CSAgICAgIlVzZWxlc3MgRE1JIG1hdGNoLiBJbnRlcm5hbCBMVkRTIHN1cHBvcnQgZGlzYWJsZWQg YnkgVkJUXG4iKTsKPiAgCQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJaWYgKCFkZXZfcHJpdi0+dmJ0 LmludF9sdmRzX3N1cHBvcnQpIHsKPiArCQlEUk1fREVCVUdfS01TKCJJbnRlcm5hbCBMVkRTIHN1 cHBvcnQgZGlzYWJsZWQgYnkgVkJULlxuIik7Cj4gKwkJcmV0dXJuOwo+ICsJfQo+ICAKPiAgCWlm IChIQVNfUENIX1NQTElUKGRldl9wcml2KSkKPiAgCQlsdmRzX3JlZyA9IFBDSF9MVkRTOwo+IEBA IC05NzUsMTAgKzk4Myw2IEBAIHZvaWQgaW50ZWxfbHZkc19pbml0KHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiAgCWlmIChIQVNfUENIX1NQTElUKGRldl9wcml2KSkgewo+ICAJ CWlmICgobHZkcyAmIExWRFNfREVURUNURUQpID09IDApCj4gIAkJCXJldHVybjsKPiAtCQlpZiAo ZGV2X3ByaXYtPnZidC5lZHAuc3VwcG9ydCkgewo+IC0JCQlEUk1fREVCVUdfS01TKCJkaXNhYmxl IExWRFMgZm9yIGVEUCBzdXBwb3J0XG4iKTsKPiAtCQkJcmV0dXJuOwo+IC0JCX0KPiAgCX0KPiAg Cj4gIAlwaW4gPSBHTUJVU19QSU5fUEFORUw7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3ZidF9kZWZzLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF92YnRf ZGVmcy5oCj4gaW5kZXggNDU4NDY4MjM3YjVmLi5hMWQ1ZTM5ZjlhMDAgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdmJ0X2RlZnMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3ZidF9kZWZzLmgKPiBAQCAtNjM1LDYgKzYzNSw3IEBAIHN0cnVjdCBi ZGJfc2R2b19sdmRzX29wdGlvbnMgewo+ICAjZGVmaW5lIEJEQl9EUklWRVJfRkVBVFVSRV9OT19M VkRTCQkwCj4gICNkZWZpbmUgQkRCX0RSSVZFUl9GRUFUVVJFX0lOVF9MVkRTCQkxCj4gICNkZWZp bmUgQkRCX0RSSVZFUl9GRUFUVVJFX1NEVk9fTFZEUwkJMgo+ICsjZGVmaW5lIEJEQl9EUklWRVJf RkVBVFVSRV9JTlRfU0RWT19MVkRTCTMKPiAgI2RlZmluZSBCREJfRFJJVkVSX0ZFQVRVUkVfRURQ CQkJMwo+ICAKPiAgc3RydWN0IGJkYl9kcml2ZXJfZmVhdHVyZXMgewoKLS0gCkphbmkgTmlrdWxh LCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK