From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753115AbdK3P7I (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 10:59:08 -0500
Received: from foss.arm.com ([217.140.101.70]:56746 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752135AbdK3P7H (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 10:59:07 -0500
References: <20171024122556.15872-1-brendan.jackman@arm.com> <20171024122556.15872-2-brendan.jackman@arm.com> <CAKfTPtDu33pC-VofPzkcW9=f1KN-LsezAQnupjb93iE2RYkLWw@mail.gmail.com>
User-agent: mu4e 0.9.18; emacs 25.2.2
From: Brendan Jackman <brendan.jackman@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>
Subject: Re: [PATCH 1/2] sched: force update of blocked load of idle cpus
In-reply-to: <CAKfTPtDu33pC-VofPzkcW9=f1KN-LsezAQnupjb93iE2RYkLWw@mail.gmail.com>
Date: Thu, 30 Nov 2017 15:59:01 +0000
Message-ID: <87mv33u5a2.fsf@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Vincent,

On Mon, Nov 20 2017 at 09:04, Vincent Guittot wrote:
> On 24 October 2017 at 14:25, Brendan Jackman <brendan.jackman@arm.com> wrote:
>> @@ -9062,7 +9109,12 @@ static __latent_entropy void run_rebalance_domains(struct softirq_action *h)
>>          * and abort nohz_idle_balance altogether if we pull some load.
>>          */
>>         nohz_idle_balance(this_rq, idle);
>> -       rebalance_domains(this_rq, idle);
>> +       update_blocked_averages(this_rq->cpu);
>> +       if (!test_bit(NOHZ_STATS_KICK, nohz_flags(this_rq->cpu)))
>
> The NOHZ_STATS_KICK field is only defined with CONFIG_NO_HZ_COMMON.

Damn, sorry. Will fix this and the similar issue you pointed out on
patch 2/2 and send a v2.

Thanks for reviewing,
Brendan