From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 4/6] drm/i915: Include engine state on detecting a missed breadcrumb/seqno Date: Wed, 22 Nov 2017 11:29:58 +0200 Message-ID: <87mv3e4q5l.fsf@gaia.fi.intel.com> References: <20171121093941.15459-1-chris@chris-wilson.co.uk> <20171121093941.15459-4-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id B85916E60B for ; Wed, 22 Nov 2017 09:30:02 +0000 (UTC) In-Reply-To: <20171121093941.15459-4-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gTm93IHRo YXQgd2UgaGF2ZSBhIGNvbW1vbiBlbmdpbmUgc3RhdGUgcHJldHR5IHByaW50ZXIsIHdlIGNhbiB1 c2UgdGhhdAo+IGluc3RlYWQgb2YgdGhlIGFkaG9jIGluZm9ybWF0aW9uIHByaW50ZWQgd2hlbiB3 ZSBtaXNzIGEgYnJlYWRjcnVtYi4KPgo+IHYyOiBSZWFycmFuZ2UgaW50ZWxfZW5naW5lX2Rpc2Fy bV9icmVhZGNydW1icygpIHRvIGF2b2lkIGNhbGxpbmcKPiBpbnRlbF9lbmdpbmVfZHVtcCgpIHVu ZGVyIHRoZSByYiBzcGlubG9jayAoTWlrYSkgYW5kIHRvIHByZXR0eS1wcmludCB0aGUKPiBlcnJv ciBzdGF0ZSBlYXJseSBzbyB0aGF0IHdlIGluY2x1ZGUgdGhlIGZ1bGwgbGlzdCBvZiB3YWl0ZXJz Lgo+IHYzOiBQYXNzIG1pc3NlZCBicmVhZGNydW1iIG1zZyB0byBwcmV0dHktcHJpbnRlciBhcyB0 aGUgaGVhZGVyCj4gdjQ6IFByZXNlcnZlIERSTV9ERUJVR19EUklWRVIgZmlsdGVyaW5nLgo+Cj4g U2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4g Q2M6IE1pa2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAaW50ZWwuY29tPgo+IENjOiBUdnJ0a28g VXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IE1pa2EgS3Vv cHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyB8IDI1ICsrKysrKysrKysrKysrLS0tLS0t LS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgICB8ICA2ICsr KysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJz LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4gaW5kZXggNWFl MmQyNzZmN2YzLi4yNGM2ZmVmZGQwYjEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfYnJlYWRjcnVtYnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2JyZWFkY3J1bWJzLmMKPiBAQCAtNjQsMTIgKzY0LDEzIEBAIHN0YXRpYyB1bnNpZ25lZCBsb25n IHdhaXRfdGltZW91dCh2b2lkKQo+ICAKPiAgc3RhdGljIG5vaW5saW5lIHZvaWQgbWlzc2VkX2Jy ZWFkY3J1bWIoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICB7Cj4gLQlEUk1fREVC VUdfRFJJVkVSKCIlcyBtaXNzZWQgYnJlYWRjcnVtYiBhdCAlcFMsIGlycSBwb3N0ZWQ/ICVzLCBj dXJyZW50IHNlcW5vPSV4LCBsYXN0PSV4XG4iLAo+IC0JCQkgZW5naW5lLT5uYW1lLCBfX2J1aWx0 aW5fcmV0dXJuX2FkZHJlc3MoMCksCj4gLQkJCSB5ZXNubyh0ZXN0X2JpdChFTkdJTkVfSVJRX0JS RUFEQ1JVTUIsCj4gLQkJCQkJJmVuZ2luZS0+aXJxX3Bvc3RlZCkpLAo+IC0JCQkgaW50ZWxfZW5n aW5lX2dldF9zZXFubyhlbmdpbmUpLAo+IC0JCQkgaW50ZWxfZW5naW5lX2xhc3Rfc3VibWl0KGVu Z2luZSkpOwo+ICsJaWYgKGRybV9kZWJ1ZyAmIERSTV9VVF9EUklWRVIpIHsKPiArCQlzdHJ1Y3Qg ZHJtX3ByaW50ZXIgcCA9IGRybV9kZWJ1Z19wcmludGVyKF9fZnVuY19fKTsKPiArCj4gKwkJaW50 ZWxfZW5naW5lX2R1bXAoZW5naW5lLCAmcCwKPiArCQkJCSAgIiVzIG1pc3NlZCBicmVhZGNydW1i IGF0ICVwU1xuIiwKPiArCQkJCSAgZW5naW5lLT5uYW1lLCBfX2J1aWx0aW5fcmV0dXJuX2FkZHJl c3MoMCkpOwo+ICsJfQo+ICAKPiAgCXNldF9iaXQoZW5naW5lLT5pZCwgJmVuZ2luZS0+aTkxNS0+ Z3B1X2Vycm9yLm1pc3NlZF9pcnFfcmluZ3MpOwo+ICB9Cj4gQEAgLTIxMywyOCArMjE0LDMwIEBA IHZvaWQgaW50ZWxfZW5naW5lX3VucGluX2JyZWFkY3J1bWJzX2lycShzdHJ1Y3QgaW50ZWxfZW5n aW5lX2NzICplbmdpbmUpCj4gIHZvaWQgaW50ZWxfZW5naW5lX2Rpc2FybV9icmVhZGNydW1icyhz dHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9icmVh ZGNydW1icyAqYiA9ICZlbmdpbmUtPmJyZWFkY3J1bWJzOwo+IC0Jc3RydWN0IGludGVsX3dhaXQg KndhaXQsICpuLCAqZmlyc3Q7Cj4gKwlzdHJ1Y3QgaW50ZWxfd2FpdCAqd2FpdCwgKm47Cj4gIAo+ ICAJaWYgKCFiLT5pcnFfYXJtZWQpCj4gIAkJcmV0dXJuOwo+ICAKPiAtCS8qIFdlIG9ubHkgZGlz YXJtIHRoZSBpcnEgd2hlbiB3ZSBhcmUgaWRsZSAoYWxsIHJlcXVlc3RzIGNvbXBsZXRlZCksCj4g KwkvKgo+ICsJICogV2Ugb25seSBkaXNhcm0gdGhlIGlycSB3aGVuIHdlIGFyZSBpZGxlIChhbGwg cmVxdWVzdHMgY29tcGxldGVkKSwKPiAgCSAqIHNvIGlmIHRoZSBib3R0b20taGFsZiByZW1haW5z IGFzbGVlcCwgaXQgbWlzc2VkIHRoZSByZXF1ZXN0Cj4gIAkgKiBjb21wbGV0aW9uLgo+ICAJICov Cj4gKwlpZiAoaW50ZWxfZW5naW5lX3dha2V1cChlbmdpbmUpICYgRU5HSU5FX1dBS0VVUF9BU0xF RVApCj4gKwkJbWlzc2VkX2JyZWFkY3J1bWIoZW5naW5lKTsKPiAgCj4gIAlzcGluX2xvY2tfaXJx KCZiLT5yYl9sb2NrKTsKPiAgCj4gIAlzcGluX2xvY2soJmItPmlycV9sb2NrKTsKPiAtCWZpcnN0 ID0gZmV0Y2hfYW5kX3plcm8oJmItPmlycV93YWl0KTsKPiArCWItPmlycV93YWl0ID0gTlVMTDsK PiAgCWlmIChiLT5pcnFfYXJtZWQpCj4gIAkJX19pbnRlbF9lbmdpbmVfZGlzYXJtX2JyZWFkY3J1 bWJzKGVuZ2luZSk7Cj4gIAlzcGluX3VubG9jaygmYi0+aXJxX2xvY2spOwo+ICAKPiAgCXJidHJl ZV9wb3N0b3JkZXJfZm9yX2VhY2hfZW50cnlfc2FmZSh3YWl0LCBuLCAmYi0+d2FpdGVycywgbm9k ZSkgewo+ICAJCVJCX0NMRUFSX05PREUoJndhaXQtPm5vZGUpOwo+IC0JCWlmICh3YWtlX3VwX3By b2Nlc3Mod2FpdC0+dHNrKSAmJiB3YWl0ID09IGZpcnN0KQo+IC0JCQltaXNzZWRfYnJlYWRjcnVt YihlbmdpbmUpOwo+ICsJCXdha2VfdXBfcHJvY2Vzcyh3YWl0LT50c2spOwo+ICAJfQo+ICAJYi0+ d2FpdGVycyA9IFJCX1JPT1Q7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9lbmdpbmVfY3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9j cy5jCj4gaW5kZXggZTlkNWNkMjgyOTFmLi5hYTQ5MDEyMDc0OWEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+IEBAIC0xODIyLDYgKzE4MjIsMTIgQEAgdm9pZCBp bnRlbF9lbmdpbmVfZHVtcChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gIAl9Cj4g IAlzcGluX3VubG9ja19pcnEoJmItPnJiX2xvY2spOwo+ICAKPiArCWRybV9wcmludGYobSwgIklS UT8gMHglbHggKGJyZWFkY3J1bWJzPyAlcykgKGV4ZWNsaXN0cz8gJXMpXG4iLAo+ICsJCSAgIGVu Z2luZS0+aXJxX3Bvc3RlZCwKPiArCQkgICB5ZXNubyh0ZXN0X2JpdChFTkdJTkVfSVJRX0JSRUFE Q1JVTUIsCj4gKwkJCQkgICZlbmdpbmUtPmlycV9wb3N0ZWQpKSwKPiArCQkgICB5ZXNubyh0ZXN0 X2JpdChFTkdJTkVfSVJRX0VYRUNMSVNULAo+ICsJCQkJICAmZW5naW5lLT5pcnFfcG9zdGVkKSkp Owo+ICAJZHJtX3ByaW50ZihtLCAiSWRsZT8gJXNcbiIsIHllc25vKGludGVsX2VuZ2luZV9pc19p ZGxlKGVuZ2luZSkpKTsKPiAgCWRybV9wcmludGYobSwgIlxuIik7Cj4gIH0KPiAtLSAKPiAyLjE1 LjAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==