From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eAHLj-0001E5-2n for ath10k@lists.infradead.org; Thu, 02 Nov 2017 15:24:20 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: move pci suspend/resume functions Date: Thu, 2 Nov 2017 15:23:42 +0000 Message-ID: <87mv44ln5v.fsf@qca.qualcomm.com> References: <20171102110903.2886660-1-arnd@arndb.de> In-Reply-To: <20171102110903.2886660-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 2 Nov 2017 12:08:53 +0100") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Arnd Bergmann Cc: Govind Singh , Ryan Hsu , "netdev@vger.kernel.org" , Brian Norris , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ath10k@lists.infradead.org" , Srinivas Kandagatla , Colin Ian King , Ben Greear , Ashok Raj Nagarajan Arnd Bergmann writes: > The combination of two patches has led to a build failure: > > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend': > drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-Werror=implicit-function-declaration] > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume': > drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-Werror=implicit-function-declaration] > > This moves the functions outside of the now incorrect #ifdef. > > Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is supported but disabled") > Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused") > Signed-off-by: Arnd Bergmann Brian has already fixed this, please check that: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=20665a9076d48e9abd9a2db13d307f58f7ef6647 But apparently I forgot to merge ath-next to wireless-drivers-next, will do that soon. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]:46704 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933418AbdKBPXp (ORCPT ); Thu, 2 Nov 2017 11:23:45 -0400 From: Kalle Valo To: Arnd Bergmann CC: Ryan Hsu , Govind Singh , Srinivas Kandagatla , Ashok Raj Nagarajan , Ben Greear , "Brian Norris" , Colin Ian King , "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ath10k: move pci suspend/resume functions Date: Thu, 2 Nov 2017 15:23:42 +0000 Message-ID: <87mv44ln5v.fsf@qca.qualcomm.com> (sfid-20171102_162357_643339_372D1884) References: <20171102110903.2886660-1-arnd@arndb.de> In-Reply-To: <20171102110903.2886660-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 2 Nov 2017 12:08:53 +0100") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Arnd Bergmann writes: > The combination of two patches has led to a build failure: > > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend= ': > drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration= of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-= Werror=3Dimplicit-function-declaration] > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume'= : > drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration= of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-We= rror=3Dimplicit-function-declaration] > > This moves the functions outside of the now incorrect #ifdef. > > Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is support= ed but disabled") > Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused") > Signed-off-by: Arnd Bergmann Brian has already fixed this, please check that: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=3Da= th-next&id=3D20665a9076d48e9abd9a2db13d307f58f7ef6647 But apparently I forgot to merge ath-next to wireless-drivers-next, will do that soon. --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933763AbdKBPXr (ORCPT ); Thu, 2 Nov 2017 11:23:47 -0400 Received: from sabertooth01.qualcomm.com ([65.197.215.72]:46704 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933418AbdKBPXp (ORCPT ); Thu, 2 Nov 2017 11:23:45 -0400 X-IronPort-AV: E=Sophos;i="5.44,334,1505804400"; d="scan'208";a="116387911" X-IronPort-AV: E=McAfee;i="5900,7806,8702"; a="1525717657" X-MGA-submission: =?us-ascii?q?MDHK7kvN9UmRQwqP/85uUvQb5iPG+fnfd0pebr?= =?us-ascii?q?NgKxWfNp1SFuVM2ZK4Sa+ZYQSIseYfIJT55VTlnswMIriTKPedAu7lDn?= =?us-ascii?q?7lQhZuaoyhF2Ean/wGbOh34oSwFjh5bdJLgXAa8gk5PRfgsMvGV65DP7?= =?us-ascii?q?oD?= From: Kalle Valo To: Arnd Bergmann CC: Ryan Hsu , Govind Singh , Srinivas Kandagatla , Ashok Raj Nagarajan , Ben Greear , "Brian Norris" , Colin Ian King , "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ath10k: move pci suspend/resume functions Thread-Topic: [PATCH] ath10k: move pci suspend/resume functions Thread-Index: AQHTU8sIUwjYYm0/ZUGKqAY2G2HYKA== Date: Thu, 2 Nov 2017 15:23:42 +0000 Message-ID: <87mv44ln5v.fsf@qca.qualcomm.com> References: <20171102110903.2886660-1-arnd@arndb.de> In-Reply-To: <20171102110903.2886660-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 2 Nov 2017 12:08:53 +0100") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vA2FNp0B011028 Arnd Bergmann writes: > The combination of two patches has led to a build failure: > > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend': > drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-Werror=implicit-function-declaration] > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume': > drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-Werror=implicit-function-declaration] > > This moves the functions outside of the now incorrect #ifdef. > > Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is supported but disabled") > Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused") > Signed-off-by: Arnd Bergmann Brian has already fixed this, please check that: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=20665a9076d48e9abd9a2db13d307f58f7ef6647 But apparently I forgot to merge ath-next to wireless-drivers-next, will do that soon. -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] ath10k: move pci suspend/resume functions Date: Thu, 2 Nov 2017 15:23:42 +0000 Message-ID: <87mv44ln5v.fsf@qca.qualcomm.com> References: <20171102110903.2886660-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Ryan Hsu , Govind Singh , Srinivas Kandagatla , Ashok Raj Nagarajan , Ben Greear , "Brian Norris" , Colin Ian King , "ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" To: Arnd Bergmann Return-path: In-Reply-To: <20171102110903.2886660-1-arnd-r2nGTMty4D4@public.gmane.org> (Arnd Bergmann's message of "Thu, 2 Nov 2017 12:08:53 +0100") Content-Language: en-US Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Arnd Bergmann writes: > The combination of two patches has led to a build failure: > > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_suspend= ': > drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit declaration= of function 'ath10k_pci_suspend'; did you mean 'ath10k_pci_pm_suspend'? [-= Werror=3Dimplicit-function-declaration] > drivers/net/wireless/ath/ath10k/pci.c: In function 'ath10k_pci_pm_resume'= : > drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit declaration= of function 'ath10k_pci_resume'; did you mean 'ath10k_pci_pm_resume'? [-We= rror=3Dimplicit-function-declaration] > > This moves the functions outside of the now incorrect #ifdef. > > Fixes: 96378bd2c6cd ("ath10k: fix core PCI suspend when WoWLAN is support= ed but disabled") > Fixes: 6af1de2e4ec4 ("ath10k: mark PM functions as __maybe_unused") > Signed-off-by: Arnd Bergmann Brian has already fixed this, please check that: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=3Da= th-next&id=3D20665a9076d48e9abd9a2db13d307f58f7ef6647 But apparently I forgot to merge ath-next to wireless-drivers-next, will do that soon. --=20 Kalle Valo=