From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare] Date: Tue, 24 Oct 2017 12:46:46 +0300 Message-ID: <87mv4gj2t5.fsf@intel.com> References: <87po9dhqoi.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 980956E3EB for ; Tue, 24 Oct 2017 09:45:20 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Binderman , "patrik.r.jakobsson@gmail.com" , "airlied@linux.ie" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyNCBPY3QgMjAxNywgRGF2aWQgQmluZGVybWFuIDxkY2IzMTRAaG90bWFpbC5jb20+ IHdyb3RlOgo+IEhlbGxvIHRoZXJlLAo+Cj4KPiBDb2RlIEkgbG9va2VkIGF0IGlzIGluIGxpbnV4 LTQuMTQtcmM2LCByZWxlYXNlZCAyMDE3MTAyMywgc28gcmVhc29uYWJseQo+Cj4gdXAgdG8gZGF0 ZS4KPgo+Cj4gSSBkaWQgYSBmdXJ0aGVyIGNoZWNrIG9uIGdpdGh1Yi5jb20vdG9ydmFsZHMvbGlu dXggYW5kIHRoZSBjb2RlCj4KPiBsb29rcyB3cm9uZyB0aGVyZSwgdG9vLgo+Cj4KPiBTbyBJIGRv bid0IHNlZSB0aGUgZml4IHlvdSBtZW50aW9uZWQgaW4gZWl0aGVyIG9mIHRoZSBwbGFjZXMgSSBs b29rZWQuCgpJdCdzIGluIGRybS1uZXh0IGJyYW5jaCBvZiBbMV0gaGVhZGluZyBmb3IgdjQuMTUu IFBsZWFzZSBzZWUgTUFJTlRBSU5FUlMKaW4gdGhlIGtlcm5lbCBzb3VyY2Ugcm9vdCBmb3IgYWxs IHRoZSB0cmVlcy4KCkJSLApKYW5pLgoKClsxXSBodHRwczovL2NnaXQuZnJlZWRlc2t0b3Aub3Jn L35haXJsaWVkL2xpbnV4LwoKCj4KPgo+IFJlZ2FyZHMKPgo+Cj4gRGF2aWQgQmluZGVybWFuCj4K PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEZyb206IEphbmkgTmlrdWxhIDxq YW5pLm5pa3VsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2VudDogMjQgT2N0b2JlciAyMDE3IDA4OjU0 Cj4gVG86IERhdmlkIEJpbmRlcm1hbjsgcGF0cmlrLnIuamFrb2Jzc29uQGdtYWlsLmNvbTsgYWly bGllZEBsaW51eC5pZTsgZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsgbGludXgta2Vy bmVsQHZnZXIua2VybmVsLm9yZwo+IFN1YmplY3Q6IFJlOiBkcml2ZXJzL2dwdS9kcm0vZ21hNTAw L21kZmxkX2ludGVsX2Rpc3BsYXkuYzoxMDI6Mzc6IHdhcm5pbmc6IGJpdHdpc2UgY29tcGFyaXNv biBhbHdheXMgZXZhbHVhdGVzIHRvIGZhbHNlIFstV3RhdXRvbG9naWNhbC1jb21wYXJlXQo+Cj4g T24gTW9uLCAyMyBPY3QgMjAxNywgRGF2aWQgQmluZGVybWFuIDxkY2IzMTRAaG90bWFpbC5jb20+ IHdyb3RlOgo+PiBIZWxsbyB0aGVyZSwKPj4KPj4gU291cmNlIGNvZGUgaXMKPj4KPj4gICAgICAg ICBpZiAoKHRlbXAgJiBQSVBFQUNPTkZfUElQRV9TVEFURSkgPT0gMSkKPj4gICAgICAgICAgICAg YnJlYWs7Cj4+Cj4+IGJ1dAo+Pgo+PiAkIGZncmVwIFBJUEVBQ09ORl9QSVBFX1NUQVRFIGBmaW5k IGRyaXZlcnMvZ3B1L2RybS9nbWE1MDAgLW5hbWUgXCouaCAtcHJpbnRgCj4+IGRyaXZlcnMvZ3B1 L2RybS9nbWE1MDAvcHNiX2ludGVsX3JlZy5oOiNkZWZpbmUgUElQRUFDT05GX1BJUEVfU1RBVEUg ICAgICAgICAgICgxIDw8IDMwKQo+PiAkCj4+Cj4+IFN1Z2dlc3QgbmV3IGNvZGUKPj4KPj4gICAg ICAgICBpZiAoKHRlbXAgJiBQSVBFQUNPTkZfUElQRV9TVEFURSkgIT0gMCkKPj4gICAgICAgICAg ICAgYnJlYWs7Cj4KPiBTdWdnZXN0IGxvb2tpbmcgYXQgbGF0ZXN0IHNvdXJjZXMuIDspCj4KPiBG aXhlZCBieSA2N2EzYjYzYTU0Y2IgKCJkcm06IGdtYTUwMDogZml4IGxvZ2ljIGVycm9yIikuCj4K PiBCUiwKPiBKYW5pLgo+Cj4gLS0KPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVj aG5vbG9neSBDZW50ZXIKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5v bG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932429AbdJXJpX (ORCPT ); Tue, 24 Oct 2017 05:45:23 -0400 Received: from mga05.intel.com ([192.55.52.43]:53968 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbdJXJpT (ORCPT ); Tue, 24 Oct 2017 05:45:19 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,427,1503385200"; d="scan'208";a="913108258" From: Jani Nikula To: David Binderman , "patrik.r.jakobsson\@gmail.com" , "airlied\@linux.ie" , "dri-devel\@lists.freedesktop.org" , "linux-kernel\@vger.kernel.org" Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare] In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <87po9dhqoi.fsf@intel.com> Date: Tue, 24 Oct 2017 12:46:46 +0300 Message-ID: <87mv4gj2t5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Oct 2017, David Binderman wrote: > Hello there, > > > Code I looked at is in linux-4.14-rc6, released 20171023, so reasonably > > up to date. > > > I did a further check on github.com/torvalds/linux and the code > > looks wrong there, too. > > > So I don't see the fix you mentioned in either of the places I looked. It's in drm-next branch of [1] heading for v4.15. Please see MAINTAINERS in the kernel source root for all the trees. BR, Jani. [1] https://cgit.freedesktop.org/~airlied/linux/ > > > Regards > > > David Binderman > > ________________________________ > From: Jani Nikula > Sent: 24 October 2017 08:54 > To: David Binderman; patrik.r.jakobsson@gmail.com; airlied@linux.ie; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org > Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare] > > On Mon, 23 Oct 2017, David Binderman wrote: >> Hello there, >> >> Source code is >> >> if ((temp & PIPEACONF_PIPE_STATE) == 1) >> break; >> >> but >> >> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print` >> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE (1 << 30) >> $ >> >> Suggest new code >> >> if ((temp & PIPEACONF_PIPE_STATE) != 0) >> break; > > Suggest looking at latest sources. ;) > > Fixed by 67a3b63a54cb ("drm: gma500: fix logic error"). > > BR, > Jani. > > -- > Jani Nikula, Intel Open Source Technology Center -- Jani Nikula, Intel Open Source Technology Center