From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbdHHIo4 (ORCPT ); Tue, 8 Aug 2017 04:44:56 -0400 Received: from canardo.mork.no ([148.122.252.1]:33885 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925AbdHHIoy (ORCPT ); Tue, 8 Aug 2017 04:44:54 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Oleg Kokorin Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] append Qualcomm GOBI 2K chipset ID for Panasonic CF-U1 Toughbook Organization: m References: <20170807160140.GA27426@localhost> Date: Tue, 08 Aug 2017 10:44:38 +0200 In-Reply-To: <20170807160140.GA27426@localhost> (Johan Hovold's message of "Mon, 7 Aug 2017 18:01:40 +0200") Message-ID: <87mv7a1ma1.fsf@miraculix.mork.no> User-Agent: Gnus/5.130015 (Ma Gnus v0.15) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v788j1cj011858 Johan Hovold writes: > On Mon, Aug 07, 2017 at 04:22:27PM +0200, Oleg Kokorin wrote: >> From 336f8adb0292a25ea41f0515a80850031f814b9b Mon Sep 17 00:00:00 2001 >> From: Oleg Kokorin >> Date: Mon, 7 Aug 2017 15:35:53 +0200 >> Subject: [PATCH] append Qualcomm GOBI 2K chipset ID for Panasonic CF-U1 >> Toughbook > > Please use > > USB: serial: qcserial: add support for Panasonic CF-U1 Toughbook > > as Subject (patch summary), and also add a commit message here (e.g. > your current summary). > >> Signed-off-by: Oleg Kokorin >> --- >> drivers/usb/serial/qcserial.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c >> index ebc0bee..53786ce 100644 >> --- a/drivers/usb/serial/qcserial.c >> +++ b/drivers/usb/serial/qcserial.c >> @@ -76,6 +76,8 @@ static const struct usb_device_id id_table[] = { >> {DEVICE_G1K(0x1bc7, 0x900e)}, /* Telit Gobi QDL device */ >> >> /* Gobi 2000 devices */ >> + {USB_DEVICE(0x04da, 0x250e)}, /* Panasonic Gobi 2000 QDL device */ >> + {USB_DEVICE(0x04da, 0x250f)}, /* Panasonic Gobi 2000 Modem device */ > > This patch is whitespace-damaged and does not apply. Please try sending > the patch to yourself first (e.g. using git-send-email) and make sure > you can apply it it with git am. Running checkpatch on the result is > also a good idea. And please send a patch for qmi_wwan too, assuming this really is a Gobi 2000 modem. Thanks. Bjørn